From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.42]) by mx.groups.io with SMTP id smtpd.web10.390.1636738825490493654 for ; Fri, 12 Nov 2021 09:40:25 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=k4mrA4NC; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.42, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V32bKoJd8wq3u33bL8JNYuxkB72lmNHhuyfy0BmfOVeZjxSpVMW3rVdIikmFYBVyw7hQQmUBZojkjTvKbvNWPXUalVeKSfA2DOd+vQZYFVBQcMJZAl8XC3GoWCF7Sf405WQ9AQUeECgFB2Aud/uDk/xhzbYZkSMdoPn3LCoCkOyNMraEqNuf5hWaj7fws6HGY5GVWoXikmt3CnfjTjunKTq1ztTrAlgLy5nXeTcNaFq0kb5k5jHIm1KZLQ/xErCl4hjYMvCCSpANZa2Ms8uh6Pj4FIJSPApqGmsOq3XILxikInFJH+naNqxQQanUkEsekebOZZs0pMG0u/GgXR5bgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eDKr64qQewFHb0w1u9Kwb1YhDCSZvqkWDhSh3lOC+30=; b=XnBv1MPmXu3+anoW2GF0AXHxv6y7m5bdHsZSyhKeRiwfnbM23gx3cVlus4uICXyhloKpq0uNFgd4+WIZ5GE5tq8/X+z3vmlE35zgs+7kNBYX+x5M0gaQopqg4A7/ajx/ssNeoPiBYuEvqa0Dq3J1v8kIyy1ZDAqzyP4tU+eKTllQFrFjpvsZXxojrKEfNhWFGOVz7kVqJP7q8UXG8XZE3G+2/xY8rf9nC1/km1I3Pz55C3SPa44u8XmA86646g88fFlI6xWTMXyhvZQfidrKujz8S/c08SXBoZa3366EA4T2i34IE2GPpiZ+DN8Q9CqgB68UaKgU5MQ0LV6pej4zEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eDKr64qQewFHb0w1u9Kwb1YhDCSZvqkWDhSh3lOC+30=; b=k4mrA4NCSxqJrvWvABkqaLQlribHlVaTP6UXPEBjFIrhUoqBtZuEU2hBHp5EnuJ9ZviKoZov4ogKaz6Ntp+Uq4HeRlSQ0DVo+8ZVUUqcXTpd5bJpaIZLBWtxW+PR8Qrf8LUA8HJDZAXqoUqMPv71KsMeNXzXhMr3i3zH2TSUHcM= Received: from BN0PR04CA0203.namprd04.prod.outlook.com (2603:10b6:408:e9::28) by CO6PR12MB5490.namprd12.prod.outlook.com (2603:10b6:303:13d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Fri, 12 Nov 2021 17:40:23 +0000 Received: from BN8NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::dc) by BN0PR04CA0203.outlook.office365.com (2603:10b6:408:e9::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.19 via Frontend Transport; Fri, 12 Nov 2021 17:40:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT014.mail.protection.outlook.com (10.13.177.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4690.15 via Frontend Transport; Fri, 12 Nov 2021 17:40:23 +0000 Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 12 Nov 2021 11:40:19 -0600 From: "Brijesh Singh" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , "Michael D Kinney" , Liming Gao , Zhiguang Liu , Ray Ni , Rahul Kumar , Eric Dong , Brijesh Singh , Michael Roth Subject: [PATCH v13 04/32] OvmfPkg/ResetVector: introduce SEV metadata descriptor for VMM use Date: Fri, 12 Nov 2021 11:39:31 -0600 Message-ID: <20211112173959.2505972-5-brijesh.singh@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211112173959.2505972-1-brijesh.singh@amd.com> References: <20211112173959.2505972-1-brijesh.singh@amd.com> MIME-Version: 1.0 Return-Path: brijesh.singh@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c3b179fc-5eb3-4ccb-3e82-08d9a603817a X-MS-TrafficTypeDiagnostic: CO6PR12MB5490: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: exjr2PrCY48ujuomzt1HdjShE5NN3k5X4tSN36nVl5BSVQloXFHkNtf9u0uSBPeefR5ts+wjnD5iR3qdzMsF3n1JWwBRknwuaDWBdGneR0EeG9g8SakzVfViiEOLZDuqfKk+LUVZp+wMFo404qHRlFmdGv9CdpMRlvVhsJ60zO5o0XXbOWdCjNkdUogiB1roKfsxpAzjn+9jb5uOFHslN0uLWhe7Smu5U83iVuh/r7Qv/hHS7NQKA7FtTXqoheoAaEHsMIYtzYn/FGGLLL1K7hGCKIdQwzKvNrzlUoQiRTuYwSDPuy70CuE5DddydCv7sYKF6CGYlTJ9nWddG7K7ZeaMaiSDUPMXZT/TK4XEUwqf17ypdy3FO0b/H+kfOgFYRs/mnpzq/+ke6pJbeCC7wQRGII4mOtgZHJ6iAf4tNKiGAOSYDMVOAc76Yr5uHSHp2mC5rbIzts7ALZ7Sp1duzpJK+cZNN8hjx18cAqrwdDpElr/ojpUiIWuGOvkubWmUbc7RmkcLaQcpCrry6XH0m+oX7mC4v0MJi1pVApRVGrDKdAgBqYia9SSgaoAlmOhqDCE5wg0F/KMqhBz6NwsWsq15hKtCbq6we2hYi/Yzmck84zTApI0yhRGEnOc+Vsn86U6pipR2jwklu33IUvb3/bS0+zUQ423I1LrEHZGRS3JmhcSHygdi6GMFVOOI7l34k8Kvfj739lb/zdvdWSQjpnKpY+KcUC5CruHHkc3aEKvIoUDeFE/kDQk5LMuDSTbAacLyJevlnqgiKGMLtM+/Dv3Jhf7Nn1VdsA/eni48XXYCdyspz4yf9gb3cbtvcPrc X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36860700001)(2906002)(86362001)(36756003)(47076005)(44832011)(6916009)(356005)(966005)(81166007)(426003)(54906003)(19627235002)(8676002)(7416002)(5660300002)(2616005)(4326008)(316002)(6666004)(1076003)(16526019)(336012)(186003)(8936002)(83380400001)(508600001)(82310400003)(26005)(70206006)(70586007)(7696005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 17:40:23.6581 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c3b179fc-5eb3-4ccb-3e82-08d9a603817a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5490 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The OvmfPkgX86 build reserves memory regions in MEMFD. The memory regions get accessed in the SEC phase. AMD SEV-SNP require that the guest's private memory be accepted or validated before access. Introduce a Guided metadata structure that describes the reserved memory regions. The VMM can locate the metadata structure by iterating through the reset vector guid and process the areas based on the platform specific requirements. Cc: Michael Roth Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Brijesh Singh --- OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm | 14 ++++++++ OvmfPkg/ResetVector/ResetVector.nasmb | 1 + OvmfPkg/ResetVector/X64/OvmfSevMetadata.asm | 34 ++++++++++++++++++++ 3 files changed, 49 insertions(+) create mode 100644 OvmfPkg/ResetVector/X64/OvmfSevMetadata.asm diff --git a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm b/OvmfPkg/ResetVe= ctor/Ia16/ResetVectorVtf0.asm index dee2e3f9de31..12f2cedd6767 100644 --- a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm +++ b/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm @@ -64,6 +64,20 @@ tdxMetadataOffsetStart: DB 0x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2 tdxMetadataOffsetEnd: =20 +; +; SEV metadata descriptor +; +; Provide the start offset of the metadata blob within the OVMF binary. + +; GUID : dc886566-984a-4798-A75e-5585a7bf67cc +; +OvmfSevMetadataOffsetStart: + DD (fourGigabytes - OvmfSevMetadataGuid) + DW OvmfSevMetadataOffsetEnd - OvmfSevMetadataOffsetStart + DB 0x66, 0x65, 0x88, 0xdc, 0x4a, 0x98, 0x98, 0x47 + DB 0xA7, 0x5e, 0x55, 0x85, 0xa7, 0xbf, 0x67, 0xcc +OvmfSevMetadataOffsetEnd: + %endif =20 ; SEV Hash Table Block diff --git a/OvmfPkg/ResetVector/ResetVector.nasmb b/OvmfPkg/ResetVector/Re= setVector.nasmb index 87effedb9c60..d847794feadb 100644 --- a/OvmfPkg/ResetVector/ResetVector.nasmb +++ b/OvmfPkg/ResetVector/ResetVector.nasmb @@ -109,6 +109,7 @@ %include "Ia32/AmdSev.asm" %include "Ia32/PageTables64.asm" %include "Ia32/IntelTdx.asm" +%include "X64/OvmfSevMetadata.asm" %endif =20 %include "Ia16/Real16ToFlat32.asm" diff --git a/OvmfPkg/ResetVector/X64/OvmfSevMetadata.asm b/OvmfPkg/ResetVec= tor/X64/OvmfSevMetadata.asm new file mode 100644 index 000000000000..9d8c3e8194a4 --- /dev/null +++ b/OvmfPkg/ResetVector/X64/OvmfSevMetadata.asm @@ -0,0 +1,34 @@ +;-------------------------------------------------------------------------= ---- +; @file +; OVMF metadata for the AMD SEV confidential computing guests +; +; Copyright (c) 2021, AMD Inc. All rights reserved.
+; +; SPDX-License-Identifier: BSD-2-Clause-Patent +;-------------------------------------------------------------------------= ---- + +BITS 64 + +%define OVMF_SEV_METADATA_VERSION 1 + +; The section must be accepted or validated by the VMM before the boot +%define OVMF_SECTION_TYPE_SNP_SEC_MEM 0x1 + +ALIGN 16 + +TIMES (15 - ((OvmfSevGuidedStructureEnd - OvmfSevGuidedStructureStart + 15= ) % 16)) DB 0 + +OvmfSevGuidedStructureStart: +; +; OvmfSev metadata descriptor +; +OvmfSevMetadataGuid: + +_DescriptorSev: + DB 'A','S','E','V' ; Signature + DD OvmfSevGuidedStructureEnd - _DescriptorSev ; Length + DD OVMF_SEV_METADATA_VERSION ; Version + DD (OvmfSevGuidedStructureEnd - _DescriptorSev - 16) / 12 ; Number of se= ctions + +OvmfSevGuidedStructureEnd: + ALIGN 16 --=20 2.25.1