* [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved
@ 2021-11-18 11:31 Dov Murik
2021-11-19 11:29 ` [edk2-devel] " Gerd Hoffmann
2021-11-22 15:42 ` Brijesh Singh
0 siblings, 2 replies; 4+ messages in thread
From: Dov Murik @ 2021-11-18 11:31 UTC (permalink / raw)
To: devel
Cc: Dov Murik, Ard Biesheuvel, Jordan Justen, Gerd Hoffmann,
Brijesh Singh, Erdem Aktas, James Bottomley, Jiewen Yao, Min Xu,
Tom Lendacky, Tobin Feldman-Fitzthum
Mark the SEV launch secret MEMFD area as reserved, which will allow the
guest OS to use it during the lifetime of the OS, without creating
copies of the sensitive content.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
---
OvmfPkg/AmdSev/SecretPei/SecretPei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/AmdSev/SecretPei/SecretPei.c b/OvmfPkg/AmdSev/SecretPei/SecretPei.c
index db94c26b54d1..6bf1a55dea64 100644
--- a/OvmfPkg/AmdSev/SecretPei/SecretPei.c
+++ b/OvmfPkg/AmdSev/SecretPei/SecretPei.c
@@ -19,7 +19,7 @@ InitializeSecretPei (
BuildMemoryAllocationHob (
PcdGet32 (PcdSevLaunchSecretBase),
ALIGN_VALUE (PcdGet32 (PcdSevLaunchSecretSize), EFI_PAGE_SIZE),
- EfiBootServicesData
+ EfiReservedMemoryType
);
return EFI_SUCCESS;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved
2021-11-18 11:31 [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved Dov Murik
@ 2021-11-19 11:29 ` Gerd Hoffmann
2021-11-22 15:42 ` Brijesh Singh
1 sibling, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2021-11-19 11:29 UTC (permalink / raw)
To: devel, dovmurik
Cc: Ard Biesheuvel, Jordan Justen, Brijesh Singh, Erdem Aktas,
James Bottomley, Jiewen Yao, Min Xu, Tom Lendacky,
Tobin Feldman-Fitzthum
Hi,
> BuildMemoryAllocationHob (
> PcdGet32 (PcdSevLaunchSecretBase),
> ALIGN_VALUE (PcdGet32 (PcdSevLaunchSecretSize), EFI_PAGE_SIZE),
> - EfiBootServicesData
> + EfiReservedMemoryType
> );
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved
2021-11-18 11:31 [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved Dov Murik
2021-11-19 11:29 ` [edk2-devel] " Gerd Hoffmann
@ 2021-11-22 15:42 ` Brijesh Singh
2021-11-22 15:57 ` Yao, Jiewen
1 sibling, 1 reply; 4+ messages in thread
From: Brijesh Singh @ 2021-11-22 15:42 UTC (permalink / raw)
To: Dov Murik, devel
Cc: brijesh.singh, Ard Biesheuvel, Jordan Justen, Gerd Hoffmann,
Erdem Aktas, James Bottomley, Jiewen Yao, Min Xu, Tom Lendacky,
Tobin Feldman-Fitzthum
On 11/18/21 5:31 AM, Dov Murik wrote:
> Mark the SEV launch secret MEMFD area as reserved, which will allow the
> guest OS to use it during the lifetime of the OS, without creating
> copies of the sensitive content.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
> ---
> OvmfPkg/AmdSev/SecretPei/SecretPei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/AmdSev/SecretPei/SecretPei.c b/OvmfPkg/AmdSev/SecretPei/SecretPei.c
> index db94c26b54d1..6bf1a55dea64 100644
> --- a/OvmfPkg/AmdSev/SecretPei/SecretPei.c
> +++ b/OvmfPkg/AmdSev/SecretPei/SecretPei.c
> @@ -19,7 +19,7 @@ InitializeSecretPei (
> BuildMemoryAllocationHob (
> PcdGet32 (PcdSevLaunchSecretBase),
> ALIGN_VALUE (PcdGet32 (PcdSevLaunchSecretSize), EFI_PAGE_SIZE),
> - EfiBootServicesData
> + EfiReservedMemoryType
> );
>
> return EFI_SUCCESS;
>
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved
2021-11-22 15:42 ` Brijesh Singh
@ 2021-11-22 15:57 ` Yao, Jiewen
0 siblings, 0 replies; 4+ messages in thread
From: Yao, Jiewen @ 2021-11-22 15:57 UTC (permalink / raw)
To: Brijesh Singh, Dov Murik, devel@edk2.groups.io
Cc: Ard Biesheuvel, Justen, Jordan L, Gerd Hoffmann, Erdem Aktas,
James Bottomley, Xu, Min M, Tom Lendacky, Tobin Feldman-Fitzthum
Acked-by: Jiewen Yao <Jiewen.Yao@intel.com>
> -----Original Message-----
> From: Brijesh Singh <brijesh.singh@amd.com>
> Sent: Monday, November 22, 2021 11:43 PM
> To: Dov Murik <dovmurik@linux.ibm.com>; devel@edk2.groups.io
> Cc: brijesh.singh@amd.com; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Erdem Aktas <erdemaktas@google.com>; James
> Bottomley <jejb@linux.ibm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Xu,
> Min M <min.m.xu@intel.com>; Tom Lendacky <thomas.lendacky@amd.com>;
> Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
> Subject: Re: [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area
> as reserved
>
>
>
> On 11/18/21 5:31 AM, Dov Murik wrote:
> > Mark the SEV launch secret MEMFD area as reserved, which will allow the
> > guest OS to use it during the lifetime of the OS, without creating
> > copies of the sensitive content.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
> > Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
> > ---
> > OvmfPkg/AmdSev/SecretPei/SecretPei.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/AmdSev/SecretPei/SecretPei.c
> b/OvmfPkg/AmdSev/SecretPei/SecretPei.c
> > index db94c26b54d1..6bf1a55dea64 100644
> > --- a/OvmfPkg/AmdSev/SecretPei/SecretPei.c
> > +++ b/OvmfPkg/AmdSev/SecretPei/SecretPei.c
> > @@ -19,7 +19,7 @@ InitializeSecretPei (
> > BuildMemoryAllocationHob (
> > PcdGet32 (PcdSevLaunchSecretBase),
> > ALIGN_VALUE (PcdGet32 (PcdSevLaunchSecretSize), EFI_PAGE_SIZE),
> > - EfiBootServicesData
> > + EfiReservedMemoryType
> > );
> >
> > return EFI_SUCCESS;
> >
>
>
> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
>
> thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-22 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-18 11:31 [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved Dov Murik
2021-11-19 11:29 ` [edk2-devel] " Gerd Hoffmann
2021-11-22 15:42 ` Brijesh Singh
2021-11-22 15:57 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox