public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael Kubacki <michael.kubacki@microsoft.com>
Subject: [Patch V2 0/3] Remove git reset and optimize
Date: Tue, 23 Nov 2021 08:30:58 -0800	[thread overview]
Message-ID: <20211123163101.786-1-michael.d.kinney@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986

New in V2
----------
* Change temp directory path from Build/ecctemp to
  Build/.pytool/Plugin/EccCheck to provide a unique
  temp directory location for any .pytool Plugin.
* Set working directory when ECC runs to temp directory
  to guarantee all temp files created by EccCheck are
  cleaned up.

* Use temp directory for all operations to prevent any
  changed to git state.
* Remove git reset operation that could corrupt staged
  and local changes.
* Improve performance by removing redundant directory scans
* Improve performance and reduce log file sizes by using
  --output option of git diff to a temp file instead of
  using stdout.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (3):
  .pytool/Plugin/EccCheck: Remove RevertCode()
  .pytool/Plugin/EccCheck: Remove temp directory on exception
  .pytool/Plugin/EccCheck: Add performance optimizations

 .pytool/Plugin/EccCheck/EccCheck.py | 242 +++++++++++++++++++---------
 1 file changed, 169 insertions(+), 73 deletions(-)

-- 
2.32.0.windows.1


             reply	other threads:[~2021-11-23 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 16:30 Michael D Kinney [this message]
2021-11-23 16:30 ` [Patch V2 1/3] .pytool/Plugin/EccCheck: Remove RevertCode() Michael D Kinney
2021-11-23 16:31 ` [Patch V2 2/3] .pytool/Plugin/EccCheck: Remove temp directory on exception Michael D Kinney
2021-11-23 16:31 ` [Patch V2 3/3] .pytool/Plugin/EccCheck: Add performance optimizations Michael D Kinney
2021-11-24  6:23 ` 回复: [Patch V2 0/3] Remove git reset and optimize gaoliming
2021-11-26 15:53 ` [edk2-devel] " Sean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211123163101.786-1-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox