From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.13776.1637685074761235619 for ; Tue, 23 Nov 2021 08:31:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: michael.d.kinney@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10176"; a="298466162" X-IronPort-AV: E=Sophos;i="5.87,258,1631602800"; d="scan'208";a="298466162" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2021 08:31:13 -0800 X-IronPort-AV: E=Sophos;i="5.87,258,1631602800"; d="scan'208";a="571112436" Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.59.198]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2021 08:31:13 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Liming Gao , Michael Kubacki Subject: [Patch V2 0/3] Remove git reset and optimize Date: Tue, 23 Nov 2021 08:30:58 -0800 Message-Id: <20211123163101.786-1-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.32.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 New in V2 ---------- * Change temp directory path from Build/ecctemp to Build/.pytool/Plugin/EccCheck to provide a unique temp directory location for any .pytool Plugin. * Set working directory when ECC runs to temp directory to guarantee all temp files created by EccCheck are cleaned up. * Use temp directory for all operations to prevent any changed to git state. * Remove git reset operation that could corrupt staged and local changes. * Improve performance by removing redundant directory scans * Improve performance and reduce log file sizes by using --output option of git diff to a temp file instead of using stdout. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Michael D Kinney Michael D Kinney (3): .pytool/Plugin/EccCheck: Remove RevertCode() .pytool/Plugin/EccCheck: Remove temp directory on exception .pytool/Plugin/EccCheck: Add performance optimizations .pytool/Plugin/EccCheck/EccCheck.py | 242 +++++++++++++++++++--------- 1 file changed, 169 insertions(+), 73 deletions(-) -- 2.32.0.windows.1