From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io
Cc: Sami Mujawar <sami.mujawar@arm.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>
Subject: [PATCH v3 15/15] DynamicTablesPkg: Handle 16550_WITH_GAS id
Date: Tue, 23 Nov 2021 18:08:38 +0100 [thread overview]
Message-ID: <20211123170838.143805-16-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20211123170838.143805-1-Pierre.Gondois@arm.com>
From: Pierre Gondois <Pierre.Gondois@arm.com>
Handle the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
id when generating an AML description of a serial port. The same
_HID/_CID as the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
are generated.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
Notes:
v2:
- New patch. [Pierre]
.../Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
index 79e1fabc9223..85c7293bb4a6 100644
--- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
+++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
@@ -83,7 +83,9 @@ ValidateSerialPortInfo (
(SerialPortInfo->PortSubtype !=
EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC) &&
(SerialPortInfo->PortSubtype !=
- EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550)) {
+ EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550) &&
+ (SerialPortInfo->PortSubtype !=
+ EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS)) {
DEBUG ((
DEBUG_ERROR,
"ERROR: UART port subtype is invalid."
@@ -143,6 +145,7 @@ FixupIds (
// Get the _CID and _HID value to write.
switch (SerialPortInfo->PortSubtype) {
case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550:
+ case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS:
{
// If there is a non-BSA compliant HID, use that.
NonBsaHid = (CONST CHAR8*)PcdGetPtr (PcdNonBsaCompliant16550SerialHid);
--
2.25.1
prev parent reply other threads:[~2021-11-23 17:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 17:08 [PATCH v3 00/15] Implement a FdtHwInfoParserLib PierreGondois
2021-11-23 17:08 ` [PATCH v3 01/15] DynamicTablesPkg: Definition for HwInfoParser interface PierreGondois
2021-11-23 17:08 ` [PATCH v3 02/15] DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper PierreGondois
2021-11-23 17:08 ` [PATCH v3 03/15] DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions PierreGondois
2021-11-23 17:08 ` [PATCH v3 04/15] DynamicTablesPkg: FdtHwInfoParser: Add Boot Arch parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 05/15] DynamicTablesPkg: FdtHwInfoParser: Generic Timer Parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 06/15] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 07/15] DynamicTablesPkg: FdtHwInfoParser: Add GICC parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 08/15] DynamicTablesPkg: FdtHwInfoParser: Add GICD parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 09/15] DynamicTablesPkg: FdtHwInfoParser: Add MSI Frame parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 10/15] DynamicTablesPkg: FdtHwInfoParser: Add ITS parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 11/15] DynamicTablesPkg: FdtHwInfoParser: Add GICR parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 12/15] DynamicTablesPkg: FdtHwInfoParser: Add GIC dispatcher PierreGondois
2021-11-23 17:08 ` [PATCH v3 13/15] DynamicTablesPkg: FdtHwInfoParser: Add PCI config parser PierreGondois
2021-11-23 17:08 ` [PATCH v3 14/15] DynamicTablesPkg: Add FdtHwInfoParser library PierreGondois
2021-11-23 17:08 ` PierreGondois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123170838.143805-16-Pierre.Gondois@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox