public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS
@ 2021-11-23 17:25 Michael D Kinney
  2021-11-23 17:49 ` [edk2-devel] " Michael Kubacki
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Michael D Kinney @ 2021-11-23 17:25 UTC (permalink / raw)
  To: devel; +Cc: Andrew Fish, Ray Ni, Michael Kubacki

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3747

* Remove deprecated option /Gm that generates a warning.
* Remove /Zi and use '=' instead of '== to let DEBUG/RELEASE/NOOPT
  profile from tools_def.txt enable debug information
* Remove /Gs8192 option that is overriding the larger setting of
  /GS32768 from tools_def.txt that generates a warning.

Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 EmulatorPkg/Win/Host/WinHost.inf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/EmulatorPkg/Win/Host/WinHost.inf b/EmulatorPkg/Win/Host/WinHost.inf
index 4d2ce19620a1..2030ac084702 100644
--- a/EmulatorPkg/Win/Host/WinHost.inf
+++ b/EmulatorPkg/Win/Host/WinHost.inf
@@ -86,7 +86,7 @@ [Pcd]
 
 [BuildOptions]
   MSFT:*_*_*_DLINK_FLAGS            == /out:"$(BIN_DIR)\$(BASE_NAME).exe" /base:0x10000000 /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb"
-  MSFT:*_*_*_CC_FLAGS               == /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /Gs8192 /Zi /Gm /D _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
+  MSFT:*_*_*_CC_FLAGS                = /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /D _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
   MSFT:*_*_*_PP_FLAGS               == /nologo /E /TC /FIAutoGen.h
 
   MSFT:*_VS2015_IA32_DLINK_FLAGS     = /LIBPATH:"%VS2015_PREFIX%Lib" /LIBPATH:"%VS2015_PREFIX%VC\Lib" /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86" /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib vcruntimed.lib ucrtd.lib
-- 
2.32.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS
  2021-11-23 17:25 [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS Michael D Kinney
@ 2021-11-23 17:49 ` Michael Kubacki
  2021-11-24  6:12 ` 回复: " gaoliming
  2021-11-25  0:13 ` Ni, Ray
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Kubacki @ 2021-11-23 17:49 UTC (permalink / raw)
  To: devel, michael.d.kinney; +Cc: Andrew Fish, Ray Ni, Michael Kubacki

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 11/23/2021 12:25 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3747
> 
> * Remove deprecated option /Gm that generates a warning.
> * Remove /Zi and use '=' instead of '== to let DEBUG/RELEASE/NOOPT
>    profile from tools_def.txt enable debug information
> * Remove /Gs8192 option that is overriding the larger setting of
>    /GS32768 from tools_def.txt that generates a warning.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   EmulatorPkg/Win/Host/WinHost.inf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/Win/Host/WinHost.inf b/EmulatorPkg/Win/Host/WinHost.inf
> index 4d2ce19620a1..2030ac084702 100644
> --- a/EmulatorPkg/Win/Host/WinHost.inf
> +++ b/EmulatorPkg/Win/Host/WinHost.inf
> @@ -86,7 +86,7 @@ [Pcd]
>   
>   [BuildOptions]
>     MSFT:*_*_*_DLINK_FLAGS            == /out:"$(BIN_DIR)\$(BASE_NAME).exe" /base:0x10000000 /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb"
> -  MSFT:*_*_*_CC_FLAGS               == /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /Gs8192 /Zi /Gm /D _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
> +  MSFT:*_*_*_CC_FLAGS                = /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /D _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
>     MSFT:*_*_*_PP_FLAGS               == /nologo /E /TC /FIAutoGen.h
>   
>     MSFT:*_VS2015_IA32_DLINK_FLAGS     = /LIBPATH:"%VS2015_PREFIX%Lib" /LIBPATH:"%VS2015_PREFIX%VC\Lib" /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86" /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib vcruntimed.lib ucrtd.lib
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* 回复: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS
  2021-11-23 17:25 [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS Michael D Kinney
  2021-11-23 17:49 ` [edk2-devel] " Michael Kubacki
@ 2021-11-24  6:12 ` gaoliming
  2021-11-25  0:13 ` Ni, Ray
  2 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2021-11-24  6:12 UTC (permalink / raw)
  To: devel, michael.d.kinney
  Cc: 'Andrew Fish', 'Ray Ni',
	'Michael Kubacki'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2021年11月24日 1:26
> 收件人: devel@edk2.groups.io
> 抄送: Andrew Fish <afish@apple.com>; Ray Ni <ray.ni@intel.com>; Michael
> Kubacki <michael.kubacki@microsoft.com>
> 主题: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3747
> 
> * Remove deprecated option /Gm that generates a warning.
> * Remove /Zi and use '=' instead of '== to let DEBUG/RELEASE/NOOPT
>   profile from tools_def.txt enable debug information
> * Remove /Gs8192 option that is overriding the larger setting of
>   /GS32768 from tools_def.txt that generates a warning.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  EmulatorPkg/Win/Host/WinHost.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/Win/Host/WinHost.inf
> b/EmulatorPkg/Win/Host/WinHost.inf
> index 4d2ce19620a1..2030ac084702 100644
> --- a/EmulatorPkg/Win/Host/WinHost.inf
> +++ b/EmulatorPkg/Win/Host/WinHost.inf
> @@ -86,7 +86,7 @@ [Pcd]
> 
>  [BuildOptions]
>    MSFT:*_*_*_DLINK_FLAGS            ==
> /out:"$(BIN_DIR)\$(BASE_NAME).exe" /base:0x10000000
> /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb"
> -  MSFT:*_*_*_CC_FLAGS               == /nologo /W4 /WX /Gy /c /D
> UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /Gs8192 /Zi /Gm /D
> _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
> +  MSFT:*_*_*_CC_FLAGS                = /nologo /W4 /WX /Gy /c /D
> UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /D
> _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
>    MSFT:*_*_*_PP_FLAGS               == /nologo /E /TC /FIAutoGen.h
> 
>    MSFT:*_VS2015_IA32_DLINK_FLAGS     =
> /LIBPATH:"%VS2015_PREFIX%Lib" /LIBPATH:"%VS2015_PREFIX%VC\Lib"
> /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86"
> /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86"
> /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP
> /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib Gdi32.lib
> User32.lib Winmm.lib Advapi32.lib vcruntimed.lib ucrtd.lib
> --
> 2.32.0.windows.1
> 
> 
> 
> 
> 






^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS
  2021-11-23 17:25 [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS Michael D Kinney
  2021-11-23 17:49 ` [edk2-devel] " Michael Kubacki
  2021-11-24  6:12 ` 回复: " gaoliming
@ 2021-11-25  0:13 ` Ni, Ray
  2 siblings, 0 replies; 4+ messages in thread
From: Ni, Ray @ 2021-11-25  0:13 UTC (permalink / raw)
  To: Kinney, Michael D, devel@edk2.groups.io; +Cc: Andrew Fish, Michael Kubacki

Reviewed-by: Ray Ni <ray.ni@Intel.com>

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, November 24, 2021 1:26 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>
> Subject: [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3747
> 
> * Remove deprecated option /Gm that generates a warning.
> * Remove /Zi and use '=' instead of '== to let DEBUG/RELEASE/NOOPT
>   profile from tools_def.txt enable debug information
> * Remove /Gs8192 option that is overriding the larger setting of
>   /GS32768 from tools_def.txt that generates a warning.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  EmulatorPkg/Win/Host/WinHost.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/Win/Host/WinHost.inf b/EmulatorPkg/Win/Host/WinHost.inf
> index 4d2ce19620a1..2030ac084702 100644
> --- a/EmulatorPkg/Win/Host/WinHost.inf
> +++ b/EmulatorPkg/Win/Host/WinHost.inf
> @@ -86,7 +86,7 @@ [Pcd]
> 
>  [BuildOptions]
>    MSFT:*_*_*_DLINK_FLAGS            == /out:"$(BIN_DIR)\$(BASE_NAME).exe" /base:0x10000000
> /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb"
> -  MSFT:*_*_*_CC_FLAGS               == /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /Gs8192 /Zi /Gm
> /D _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
> +  MSFT:*_*_*_CC_FLAGS                = /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /D
> _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
>    MSFT:*_*_*_PP_FLAGS               == /nologo /E /TC /FIAutoGen.h
> 
>    MSFT:*_VS2015_IA32_DLINK_FLAGS     = /LIBPATH:"%VS2015_PREFIX%Lib" /LIBPATH:"%VS2015_PREFIX%VC\Lib"
> /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86"
> /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB
> /IGNORE:4086 /MAP /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib Gdi32.lib User32.lib Winmm.lib
> Advapi32.lib vcruntimed.lib ucrtd.lib
> --
> 2.32.0.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-25  0:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-23 17:25 [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS Michael D Kinney
2021-11-23 17:49 ` [edk2-devel] " Michael Kubacki
2021-11-24  6:12 ` 回复: " gaoliming
2021-11-25  0:13 ` Ni, Ray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox