* [Patch 00/12] Update Package YAML to ignore specific ECC files/errors
@ 2021-11-23 21:21 Michael D Kinney
2021-11-23 21:21 ` [Patch 01/12] ArmPkg: Update " Michael D Kinney
` (12 more replies)
0 siblings, 13 replies; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar, Gerd Hoffmann,
Jiewen Yao, Jian J Wang, Xiaoyu Lu, Guomin Jiang, Andrew Fish,
Ray Ni, Zhiguang Liu, Qi Zhang, Rahul Kumar, Zhichao Gao,
Supreeth Venkatesh, Guo Dong, Maurice Ma, Benjamin You,
Sean Brogan, Bret Barkelew, Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Michael D Kinney (12):
ArmPkg: Update YAML to ignore specific ECC files/errors
ArmPlatformPkg: Update YAML to ignore specific ECC files/errors
ArmVirtPkg: Update YAML to ignore specific ECC files/errors
CryptoPkg: Update YAML to ignore specific ECC files/errors
EmulatorPkg: Update YAML to ignore specific ECC files/errors
MdeModulePkg: Update YAML to ignore specific ECC files/errors
MdePkg: Update YAML to ignore specific ECC files/errors
SecurityPkg: Update YAML to ignore specific ECC files/errors
ShellPkg: Update YAML to ignore specific ECC files/errors
StandaloneMmPkg: Update YAML to ignore specific ECC files/errors
UefiPayloadPkg: Update YAML to ignore specific ECC files/errors
UnitTestFrameworkPkg: Update YAML to ignore specific ECC files/errors
ArmPkg/ArmPkg.ci.yaml | 5 ++-
ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 +-
ArmVirtPkg/ArmVirtPkg.ci.yaml | 1 +
CryptoPkg/CryptoPkg.ci.yaml | 10 ++++--
EmulatorPkg/EmulatorPkg.ci.yaml | 7 ++++
MdeModulePkg/MdeModulePkg.ci.yaml | 9 ++---
MdePkg/MdePkg.ci.yaml | 34 ++++++++++++++++++-
SecurityPkg/SecurityPkg.ci.yaml | 3 ++
ShellPkg/ShellPkg.ci.yaml | 1 +
StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 12 +++++++
UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 6 ++++
.../UnitTestFrameworkPkg.ci.yaml | 5 ++-
12 files changed, 83 insertions(+), 13 deletions(-)
--
2.32.0.windows.1
^ permalink raw reply [flat|nested] 33+ messages in thread
* [Patch 01/12] ArmPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-24 10:35 ` [edk2-devel] " Sami Mujawar
2021-11-24 11:57 ` Leif Lindholm
2021-11-23 21:21 ` [Patch 02/12] ArmPlatformPkg: " Michael D Kinney
` (11 subsequent siblings)
12 siblings, 2 replies; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Leif Lindholm, Ard Biesheuvel, Sean Brogan, Bret Barkelew,
Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
ArmPkg/ArmPkg.ci.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
index a0d6a75fe881..b7e07aaef675 100644
--- a/ArmPkg/ArmPkg.ci.yaml
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -19,7 +19,10 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
- "Library/ArmSoftFloatLib/berkeley-softfloat-3"
+ "Library/ArmSoftFloatLib/berkeley-softfloat-3",
+ "Library/ArmSoftFloatLib/ArmSoftFloatLib.c",
+ "Library/CompilerIntrinsicsLib",
+ "Universal/Smbios/SmbiosMiscDxe"
]
},
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
2021-11-23 21:21 ` [Patch 01/12] ArmPkg: Update " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-24 10:36 ` [edk2-devel] " Sami Mujawar
` (2 more replies)
2021-11-23 21:21 ` [Patch 03/12] ArmVirtPkg: " Michael D Kinney
` (10 subsequent siblings)
12 siblings, 3 replies; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Leif Lindholm, Ard Biesheuvel, Sean Brogan, Bret Barkelew,
Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
index 3dbbcc673bf0..03632e74df73 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
+++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
@@ -19,7 +19,8 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
- "Scripts/Ds5/"
+ "Scripts/Ds5/",
+ "Drivers/PL061GpioDxe/PL061Gpio.c"
]
},
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 03/12] ArmVirtPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
2021-11-23 21:21 ` [Patch 01/12] ArmPkg: Update " Michael D Kinney
2021-11-23 21:21 ` [Patch 02/12] ArmPlatformPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-24 10:40 ` Sami Mujawar
2021-11-24 11:58 ` Leif Lindholm
2021-11-23 21:21 ` [Patch 04/12] CryptoPkg: " Michael D Kinney
` (9 subsequent siblings)
12 siblings, 2 replies; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar, Gerd Hoffmann,
Sean Brogan, Bret Barkelew, Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
index f80500ab53b0..67b0e9594f3e 100644
--- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
+++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
@@ -24,6 +24,7 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
+ "Library/PlatformBootManagerLib/PlatformBm.c"
]
},
## options defined .pytool/Plugin/CompilerPlugin
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (2 preceding siblings ...)
2021-11-23 21:21 ` [Patch 03/12] ArmVirtPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
[not found] ` <CO1PR11MB4929B441ED557EE00D2596BCD2639@CO1PR11MB4929.namprd11.prod.outlook.com>
2021-11-28 7:33 ` Wang, Jian J
2021-11-23 21:21 ` [Patch 05/12] EmulatorPkg: " Michael D Kinney
` (8 subsequent siblings)
12 siblings, 2 replies; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Jiewen Yao, Jian J Wang, Xiaoyu Lu, Guomin Jiang, Sean Brogan,
Bret Barkelew, Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index 1448299073de..eeb388ae71c5 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -19,6 +19,9 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "8001", "IsLeap",
+ "8001", "OBJ_get0_data",
+ "8001", "OBJ_length"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
@@ -26,14 +29,15 @@
# The unit testing folder is not to be checked
"Test/UnitTest",
# This has OpenSSL interfaces that aren't UEFI spec compliant
- "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
+ "Library/BaseCryptLib/SysCall",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/OpensslLib/rand_pool.c",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/Include/CrtLibSupport.h",
# These directories contain auto-generated OpenSSL content
- "Library/OpensslLib/X64",
- "Library/OpensslLib/X64Gcc"
+ "Library/OpensslLib",
+ "Library/IntrinsicLib",
+ "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
]
},
"CompilerPlugin": {
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 05/12] EmulatorPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (3 preceding siblings ...)
2021-11-23 21:21 ` [Patch 04/12] CryptoPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-30 5:05 ` Ni, Ray
2021-11-23 21:21 ` [Patch 06/12] MdeModulePkg: " Michael D Kinney
` (7 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Andrew Fish, Ray Ni, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
EmulatorPkg/EmulatorPkg.ci.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml b/EmulatorPkg/EmulatorPkg.ci.yaml
index 97fdef17abf4..338d5fc2d381 100644
--- a/EmulatorPkg/EmulatorPkg.ci.yaml
+++ b/EmulatorPkg/EmulatorPkg.ci.yaml
@@ -22,6 +22,13 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
+ "EmuBlockIoDxe/EmuBlockIo.c",
+ "EmuGopDxe/GopInput.c",
+ "EmuSnpDxe/EmuSnpDxe.c",
+ "EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c",
+ "FvbServicesRuntimeDxe/FWBlockService.c",
+ "Win/Host/WinFileSystem.c",
+ "Win/Host/WinInclude.h"
]
},
## options defined .pytool/Plugin/CompilerPlugin
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 06/12] MdeModulePkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (4 preceding siblings ...)
2021-11-23 21:21 ` [Patch 05/12] EmulatorPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-27 1:40 ` 回复: [edk2-devel] " gaoliming
2021-11-23 21:21 ` [Patch 07/12] MdePkg: " Michael D Kinney
` (6 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Liming Gao, Sean Brogan, Bret Barkelew,
Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
MdeModulePkg/MdeModulePkg.ci.yaml | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index b8d15a3e952e..f69989087b4c 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -23,12 +23,9 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
- "Library/BrotliCustomDecompressLib/brotli",
- "Universal/RegularExpressionDxe/oniguruma",
- "Library/LzmaCustomDecompressLib/Sdk/DOC",
- "Library/LzmaCustomDecompressLib/Sdk/C",
- "Universal/RegularExpressionDxe/OnigurumaUefiPort.h",
- "Universal/RegularExpressionDxe/OnigurumaUefiPort.c"
+ "Library/LzmaCustomDecompressLib",
+ "Library/BrotliCustomDecompressLib",
+ "Universal/RegularExpressionDxe"
]
},
## options defined ci/Plugin/CompilerPlugin
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 07/12] MdePkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (5 preceding siblings ...)
2021-11-23 21:21 ` [Patch 06/12] MdeModulePkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-27 1:42 ` 回复: [edk2-devel] " gaoliming
2021-11-23 21:21 ` [Patch 08/12] SecurityPkg: " Michael D Kinney
` (5 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel; +Cc: Liming Gao, Zhiguang Liu, Sean Brogan, Bret Barkelew,
Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
MdePkg/MdePkg.ci.yaml | 34 +++++++++++++++++++++++++++++++++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index 3ea8eec33152..054233ebc7bd 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -17,10 +17,42 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "9005", "@VDD",
+ "8005", "gST",
+ "8005", "gBS",
+ "8005", "gDS",
+ "8005", "gDS",
+ "8002", "va_list",
+ "8005", "EFI_BLUETOOTH_LE_SCAN_CALLBACK_INFORMATION.RSSI",
+ "8005", "void",
+ "8005", "va_list.__ap",
+ "8005", "__stack_chk_guard",
+ "8001", "MSG_IPv6_DP",
+ "8001", "MSG_IPv4_DP",
+ "8001", "DEFAULT_ToS",
+ "8001", "EFI_SERIAL_IO_PROTOCOL_REVISION1p1",
+ "8001", "EFI_ABS_AltActive",
+ "8001", "EFI_ABSP_SupportsAltActive",
+ "8001", "_ReadWriteBarrier",
+ "8001", "__va_copy",
+ "8003", "__va_copy",
+ "7007", "_EFI_LEGACY_SPI_CONTROLLER_PROTOCOL",
+ "7007", "_EFI_LEGACY_SPI_FLASH_PROTOCOL",
+ "7007", "_EFI_SPI_NOR_FLASH_PROTOCOL",
+ "7007", "_EFI_SPI_HC_PROTOCOL",
+ "8002", "aligned (",
+ "4002", "_ReturnAddress"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
- "Include/IndustryStandard/Acpi64.h"
+ "Include/IndustryStandard/Acpi64.h",
+ "Include/IndustryStandard/Tpm12.h",
+ "Include/IndustryStandard/Tpm20.h",
+ "Include/IndustryStandard/IoRemappingTable.h",
+ "Include/IndustryStandard/UefiTcgPlatform.h",
+ "Include/Library/PcdLib.h",
+ "Include/Library/SafeIntLib.h",
+ "Test/UnitTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.c"
]
},
## options defined ci/Plugin/CompilerPlugin
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 08/12] SecurityPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (6 preceding siblings ...)
2021-11-23 21:21 ` [Patch 07/12] MdePkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-30 6:03 ` Qi Zhang
2021-11-23 21:21 ` [Patch 09/12] ShellPkg: " Michael D Kinney
` (4 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Qi Zhang, Rahul Kumar, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
SecurityPkg/SecurityPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.ci.yaml b/SecurityPkg/SecurityPkg.ci.yaml
index d7b9e1f4e239..791214239899 100644
--- a/SecurityPkg/SecurityPkg.ci.yaml
+++ b/SecurityPkg/SecurityPkg.ci.yaml
@@ -18,6 +18,9 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
+ "Library/TcgStorageCoreLib/TcgStorageUtil.c",
+ "Library/TcgStorageCoreLib/TcgStorageCore.c",
+ "Library/Tpm2CommandLib/Tpm2NVStorage.c"
]
},
"CompilerPlugin": {
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 09/12] ShellPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (7 preceding siblings ...)
2021-11-23 21:21 ` [Patch 08/12] SecurityPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-24 5:41 ` Gao, Zhichao
2021-11-30 5:05 ` Ni, Ray
2021-11-23 21:21 ` [Patch 10/12] StandaloneMmPkg: " Michael D Kinney
` (3 subsequent siblings)
12 siblings, 2 replies; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Ray Ni, Zhichao Gao, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
ShellPkg/ShellPkg.ci.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
index 30894d44bc3a..e741402459e5 100644
--- a/ShellPkg/ShellPkg.ci.yaml
+++ b/ShellPkg/ShellPkg.ci.yaml
@@ -15,6 +15,7 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "8001", "ShellCommandLineParse"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (8 preceding siblings ...)
2021-11-23 21:21 ` [Patch 09/12] ShellPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-24 10:55 ` Sami Mujawar
2021-11-23 21:21 ` [Patch 11/12] UefiPayloadPkg: " Michael D Kinney
` (2 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Sami Mujawar, Jiewen Yao, Supreeth Venkatesh,
Sean Brogan, Bret Barkelew, Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
index 06bef683cdaf..4777532a7ede 100644
--- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
+++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
@@ -5,6 +5,18 @@
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ "4002", "HobConstructor"
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "StandaloneMmPkg.dsc"
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 11/12] UefiPayloadPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (9 preceding siblings ...)
2021-11-23 21:21 ` [Patch 10/12] StandaloneMmPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-29 16:30 ` Guo Dong
2021-11-23 21:21 ` [Patch 12/12] UnitTestFrameworkPkg: " Michael D Kinney
2021-11-23 23:28 ` [Patch 00/12] Update Package " Ard Biesheuvel
12 siblings, 1 reply; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel
Cc: Guo Dong, Ray Ni, Maurice Ma, Benjamin You, Sean Brogan,
Bret Barkelew, Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
index 35e6fb3540d1..93f4d3603db9 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
+++ b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
@@ -18,6 +18,12 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
+ "Include/Coreboot.h",
+ "Library/CbParseLib/CbParseLib.c",
+ "Library/CbParseLib/CbParseLib.c",
+ "PayloadLoaderPeim/ElfLib/ElfCommon.h",
+ "PayloadLoaderPeim/ElfLib/Elf32.h",
+ "PayloadLoaderPeim/ElfLib/Elf64.h"
]
},
## options defined .pytool/Plugin/CompilerPlugin
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [Patch 12/12] UnitTestFrameworkPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (10 preceding siblings ...)
2021-11-23 21:21 ` [Patch 11/12] UefiPayloadPkg: " Michael D Kinney
@ 2021-11-23 21:21 ` Michael D Kinney
2021-11-27 2:19 ` [EXTERNAL] " Bret Barkelew
2021-11-23 23:28 ` [Patch 00/12] Update Package " Ard Biesheuvel
12 siblings, 1 reply; 33+ messages in thread
From: Michael D Kinney @ 2021-11-23 21:21 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Liming Gao, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
index 9e9ffc1af113..1b247a831593 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
@@ -15,10 +15,13 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "9005", "@MRT",
+ "7007", "_UNIT_TEST_FAILURE_TYPE_STRING"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
- "Library/CmockaLib/cmocka"
+ "Library/CmockaLib/cmocka",
+ "Library/UnitTestLib/RunTestsCmocka.c"
]
},
## options defined .pytool/Plugin/CompilerPlugin
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [Patch 00/12] Update Package YAML to ignore specific ECC files/errors
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
` (11 preceding siblings ...)
2021-11-23 21:21 ` [Patch 12/12] UnitTestFrameworkPkg: " Michael D Kinney
@ 2021-11-23 23:28 ` Ard Biesheuvel
12 siblings, 0 replies; 33+ messages in thread
From: Ard Biesheuvel @ 2021-11-23 23:28 UTC (permalink / raw)
To: Michael D Kinney
Cc: edk2-devel-groups-io, Leif Lindholm, Ard Biesheuvel, Sami Mujawar,
Gerd Hoffmann, Jiewen Yao, Jian J Wang, Xiaoyu Lu, Guomin Jiang,
Andrew Fish, Ray Ni, Zhiguang Liu, Qi Zhang, Rahul Kumar,
Zhichao Gao, Supreeth Venkatesh, Guo Dong, Maurice Ma,
Benjamin You, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
On Tue, 23 Nov 2021 at 22:21, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Where needed,
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Michael D Kinney (12):
> ArmPkg: Update YAML to ignore specific ECC files/errors
> ArmPlatformPkg: Update YAML to ignore specific ECC files/errors
> ArmVirtPkg: Update YAML to ignore specific ECC files/errors
> CryptoPkg: Update YAML to ignore specific ECC files/errors
> EmulatorPkg: Update YAML to ignore specific ECC files/errors
> MdeModulePkg: Update YAML to ignore specific ECC files/errors
> MdePkg: Update YAML to ignore specific ECC files/errors
> SecurityPkg: Update YAML to ignore specific ECC files/errors
> ShellPkg: Update YAML to ignore specific ECC files/errors
> StandaloneMmPkg: Update YAML to ignore specific ECC files/errors
> UefiPayloadPkg: Update YAML to ignore specific ECC files/errors
> UnitTestFrameworkPkg: Update YAML to ignore specific ECC files/errors
>
> ArmPkg/ArmPkg.ci.yaml | 5 ++-
> ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 +-
> ArmVirtPkg/ArmVirtPkg.ci.yaml | 1 +
> CryptoPkg/CryptoPkg.ci.yaml | 10 ++++--
> EmulatorPkg/EmulatorPkg.ci.yaml | 7 ++++
> MdeModulePkg/MdeModulePkg.ci.yaml | 9 ++---
> MdePkg/MdePkg.ci.yaml | 34 ++++++++++++++++++-
> SecurityPkg/SecurityPkg.ci.yaml | 3 ++
> ShellPkg/ShellPkg.ci.yaml | 1 +
> StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 12 +++++++
> UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 6 ++++
> .../UnitTestFrameworkPkg.ci.yaml | 5 ++-
> 12 files changed, 83 insertions(+), 13 deletions(-)
>
> --
> 2.32.0.windows.1
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 09/12] ShellPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 09/12] ShellPkg: " Michael D Kinney
@ 2021-11-24 5:41 ` Gao, Zhichao
2021-11-30 5:05 ` Ni, Ray
1 sibling, 0 replies; 33+ messages in thread
From: Gao, Zhichao @ 2021-11-24 5:41 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Ni, Ray, Sean Brogan, Bret Barkelew, Liming Gao, Michael Kubacki
Acked-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, November 24, 2021 5:21 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Michael Kubacki <michael.kubacki@microsoft.com>
> Subject: [Patch 09/12] ShellPkg: Update YAML to ignore specific ECC
> files/errors
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are already present.
> These issues must be fixed in the future, but should not block source code
> changes for these known issues.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> ShellPkg/ShellPkg.ci.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml index
> 30894d44bc3a..e741402459e5 100644
> --- a/ShellPkg/ShellPkg.ci.yaml
> +++ b/ShellPkg/ShellPkg.ci.yaml
> @@ -15,6 +15,7 @@
> ## "<ErrorID>", "<KeyWord>"
> ## ]
> "ExceptionList": [
> + "8001", "ShellCommandLineParse"
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [edk2-devel] [Patch 01/12] ArmPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 01/12] ArmPkg: Update " Michael D Kinney
@ 2021-11-24 10:35 ` Sami Mujawar
2021-11-24 11:57 ` Leif Lindholm
1 sibling, 0 replies; 33+ messages in thread
From: Sami Mujawar @ 2021-11-24 10:35 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: Leif Lindholm, Ard Biesheuvel, Sean Brogan, Bret Barkelew,
Liming Gao, Michael Kubacki, nd
Hi Mike,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 23/11/2021 09:21 PM, Michael D Kinney via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> ArmPkg/ArmPkg.ci.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index a0d6a75fe881..b7e07aaef675 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -19,7 +19,10 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> - "Library/ArmSoftFloatLib/berkeley-softfloat-3"
> + "Library/ArmSoftFloatLib/berkeley-softfloat-3",
> + "Library/ArmSoftFloatLib/ArmSoftFloatLib.c",
> + "Library/CompilerIntrinsicsLib",
> + "Universal/Smbios/SmbiosMiscDxe"
> ]
> },
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [edk2-devel] [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 02/12] ArmPlatformPkg: " Michael D Kinney
@ 2021-11-24 10:36 ` Sami Mujawar
2021-11-24 11:58 ` Leif Lindholm
2021-12-01 14:33 ` PierreGondois
2 siblings, 0 replies; 33+ messages in thread
From: Sami Mujawar @ 2021-11-24 10:36 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: Leif Lindholm, Ard Biesheuvel, Sean Brogan, Bret Barkelew,
Liming Gao, Michael Kubacki, nd
Hi Mike,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 23/11/2021 09:21 PM, Michael D Kinney via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> index 3dbbcc673bf0..03632e74df73 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> +++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> @@ -19,7 +19,8 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> - "Scripts/Ds5/"
> + "Scripts/Ds5/",
> + "Drivers/PL061GpioDxe/PL061Gpio.c"
> ]
> },
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 03/12] ArmVirtPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 03/12] ArmVirtPkg: " Michael D Kinney
@ 2021-11-24 10:40 ` Sami Mujawar
2021-11-24 11:58 ` Leif Lindholm
1 sibling, 0 replies; 33+ messages in thread
From: Sami Mujawar @ 2021-11-24 10:40 UTC (permalink / raw)
To: Michael D Kinney, devel
Cc: Leif Lindholm, Ard Biesheuvel, Gerd Hoffmann, Sean Brogan,
Bret Barkelew, Liming Gao, Michael Kubacki, nd
Hi Mike,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 23/11/2021 09:21 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> ArmVirtPkg/ArmVirtPkg.ci.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index f80500ab53b0..67b0e9594f3e 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -24,6 +24,7 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> + "Library/PlatformBootManagerLib/PlatformBm.c"
> ]
> },
> ## options defined .pytool/Plugin/CompilerPlugin
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 10/12] StandaloneMmPkg: " Michael D Kinney
@ 2021-11-24 10:55 ` Sami Mujawar
2021-11-24 23:27 ` [edk2-devel] " Michael D Kinney
0 siblings, 1 reply; 33+ messages in thread
From: Sami Mujawar @ 2021-11-24 10:55 UTC (permalink / raw)
To: Michael D Kinney, devel
Cc: Ard Biesheuvel, Jiewen Yao, Supreeth Venkatesh, Sean Brogan,
Bret Barkelew, Liming Gao, Michael Kubacki, nd
Hi Mike,
On 23/11/2021 09:21 PM, Michael D Kinney wrote:
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + "4002", "HobConstructor"
> + ],
I noticed there are other ECC errors with ID 4002 in StandaloneMmPkg.
e.g.
edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLib.c(24):
[4002]Function header doesn't exist Function [CreateHob] has NO comment
immediately preceding it.
edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLibInternal.c(24):
[4002]Function header doesn't exist Function [HobConstructor] has NO
comment immediately preceding it.
edk2\StandaloneMmPkg\Library\StandaloneMmHobLib\StandaloneMmHobLib.c(247):
[4002]Function header doesn't exist Function [CreateHob] has NO comment
immediately preceding it.
edk2\StandaloneMmPkg\Library\StandaloneMmPeCoffExtraActionLib\AArch64\StandaloneMmPeCoffExtraActionLib.c(26):
[4002]Function header doesn't exist Function [UpdatePeCoffPermissions]
has NO comment immediately preceding it.
I am trying to undestand how the ExceptionList works. Would Keyword =
HobConstructor ignore the other errors too?
We will look into getting these issues fixed. However, to unblock this
patch can proceed.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 01/12] ArmPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 01/12] ArmPkg: Update " Michael D Kinney
2021-11-24 10:35 ` [edk2-devel] " Sami Mujawar
@ 2021-11-24 11:57 ` Leif Lindholm
1 sibling, 0 replies; 33+ messages in thread
From: Leif Lindholm @ 2021-11-24 11:57 UTC (permalink / raw)
To: Michael D Kinney
Cc: devel, Ard Biesheuvel, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
On Tue, Nov 23, 2021 at 13:21:11 -0800, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> ArmPkg/ArmPkg.ci.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index a0d6a75fe881..b7e07aaef675 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -19,7 +19,10 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> - "Library/ArmSoftFloatLib/berkeley-softfloat-3"
> + "Library/ArmSoftFloatLib/berkeley-softfloat-3",
> + "Library/ArmSoftFloatLib/ArmSoftFloatLib.c",
> + "Library/CompilerIntrinsicsLib",
> + "Universal/Smbios/SmbiosMiscDxe"
> ]
> },
>
> --
> 2.32.0.windows.1
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [edk2-devel] [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 02/12] ArmPlatformPkg: " Michael D Kinney
2021-11-24 10:36 ` [edk2-devel] " Sami Mujawar
@ 2021-11-24 11:58 ` Leif Lindholm
2021-12-01 14:33 ` PierreGondois
2 siblings, 0 replies; 33+ messages in thread
From: Leif Lindholm @ 2021-11-24 11:58 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: Ard Biesheuvel, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
On Tue, Nov 23, 2021 at 13:21:12 -0800, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> index 3dbbcc673bf0..03632e74df73 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> +++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> @@ -19,7 +19,8 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> - "Scripts/Ds5/"
> + "Scripts/Ds5/",
> + "Drivers/PL061GpioDxe/PL061Gpio.c"
> ]
> },
>
> --
> 2.32.0.windows.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 03/12] ArmVirtPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 03/12] ArmVirtPkg: " Michael D Kinney
2021-11-24 10:40 ` Sami Mujawar
@ 2021-11-24 11:58 ` Leif Lindholm
1 sibling, 0 replies; 33+ messages in thread
From: Leif Lindholm @ 2021-11-24 11:58 UTC (permalink / raw)
To: Michael D Kinney
Cc: devel, Ard Biesheuvel, Sami Mujawar, Gerd Hoffmann, Sean Brogan,
Bret Barkelew, Liming Gao, Michael Kubacki
On Tue, Nov 23, 2021 at 13:21:13 -0800, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> ArmVirtPkg/ArmVirtPkg.ci.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index f80500ab53b0..67b0e9594f3e 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -24,6 +24,7 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> + "Library/PlatformBootManagerLib/PlatformBm.c"
> ]
> },
> ## options defined .pytool/Plugin/CompilerPlugin
> --
> 2.32.0.windows.1
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [edk2-devel] [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors
2021-11-24 10:55 ` Sami Mujawar
@ 2021-11-24 23:27 ` Michael D Kinney
0 siblings, 0 replies; 33+ messages in thread
From: Michael D Kinney @ 2021-11-24 23:27 UTC (permalink / raw)
To: devel@edk2.groups.io, sami.mujawar@arm.com, Kinney, Michael D
Cc: Ard Biesheuvel, Yao, Jiewen, Supreeth Venkatesh, Sean Brogan,
Bret Barkelew, Liming Gao, Michael Kubacki, nd
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami Mujawar
> Sent: Wednesday, November 24, 2021 2:55 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Michael Kubacki <michael.kubacki@microsoft.com>; nd <nd@arm.com>
> Subject: Re: [edk2-devel] [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors
>
> Hi Mike,
>
>
> On 23/11/2021 09:21 PM, Michael D Kinney wrote:
> > + "EccCheck": {
> > + ## Exception sample looks like below:
> > + ## "ExceptionList": [
> > + ## "<ErrorID>", "<KeyWord>"
> > + ## ]
> > + "ExceptionList": [
> > + "4002", "HobConstructor"
> > + ],
>
> I noticed there are other ECC errors with ID 4002 in StandaloneMmPkg.
>
> e.g.
>
> edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLib.c(24):
> [4002]Function header doesn't exist Function [CreateHob] has NO comment
> immediately preceding it.
> edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLibInternal.c(24):
> [4002]Function header doesn't exist Function [HobConstructor] has NO
> comment immediately preceding it.
> edk2\StandaloneMmPkg\Library\StandaloneMmHobLib\StandaloneMmHobLib.c(247):
> [4002]Function header doesn't exist Function [CreateHob] has NO comment
> immediately preceding it.
> edk2\StandaloneMmPkg\Library\StandaloneMmPeCoffExtraActionLib\AArch64\StandaloneMmPeCoffExtraActionLib.c(26):
> [4002]Function header doesn't exist Function [UpdatePeCoffPermissions]
> has NO comment immediately preceding it.
>
> I am trying to undestand how the ExceptionList works. Would Keyword =
> HobConstructor ignore the other errors too?
Good question. EccCheck in EDK II CI only checks lines of files that have been
added or changed. So if these lines were not modified by uncrustify, then they
would not block the commit, even if they have ECC issues.
>
> We will look into getting these issues fixed. However, to unblock this
> patch can proceed.
Thank you. Yes. That is the intention here. Temporarily use YAML file
to get EccCheck to pass, then the work with package owners to update code
so these exceptions can be removed.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
>
>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors
[not found] ` <CO1PR11MB4929B441ED557EE00D2596BCD2639@CO1PR11MB4929.namprd11.prod.outlook.com>
@ 2021-11-27 1:31 ` Yao, Jiewen
0 siblings, 0 replies; 33+ messages in thread
From: Yao, Jiewen @ 2021-11-27 1:31 UTC (permalink / raw)
To: devel@edk2.groups.io, Kinney, Michael D, Wang, Jian J,
Lu, XiaoyuX, Jiang, Guomin, Sean Brogan, Bret Barkelew,
Liming Gao, Michael Kubacki
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D
> Kinney
> Sent: Tuesday, November 23, 2021 1:21 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>;
> Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Michael Kubacki <michael.kubacki@microsoft.com>
> Subject: [edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific
> ECC files/errors
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index 1448299073de..eeb388ae71c5 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -19,6 +19,9 @@
> ## "<ErrorID>", "<KeyWord>"
> ## ]
> "ExceptionList": [
> + "8001", "IsLeap",
> + "8001", "OBJ_get0_data",
> + "8001", "OBJ_length"
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> @@ -26,14 +29,15 @@
> # The unit testing folder is not to be checked
> "Test/UnitTest",
> # This has OpenSSL interfaces that aren't UEFI spec compliant
> - "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
> + "Library/BaseCryptLib/SysCall",
> # This has OpenSSL interfaces that aren't UEFI spec compliant
> "Library/OpensslLib/rand_pool.c",
> # This has OpenSSL interfaces that aren't UEFI spec compliant
> "Library/Include/CrtLibSupport.h",
> # These directories contain auto-generated OpenSSL content
> - "Library/OpensslLib/X64",
> - "Library/OpensslLib/X64Gcc"
> + "Library/OpensslLib",
> + "Library/IntrinsicLib",
> + "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
> ]
> },
> "CompilerPlugin": {
> --
> 2.32.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* 回复: [edk2-devel] [Patch 06/12] MdeModulePkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 06/12] MdeModulePkg: " Michael D Kinney
@ 2021-11-27 1:40 ` gaoliming
0 siblings, 0 replies; 33+ messages in thread
From: gaoliming @ 2021-11-27 1:40 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: 'Jian J Wang', 'Sean Brogan',
'Bret Barkelew', 'Michael Kubacki'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2021年11月24日 5:21
> 收件人: devel@edk2.groups.io
> 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Sean Brogan <sean.brogan@microsoft.com>;
> Bret Barkelew <Bret.Barkelew@microsoft.com>; Michael Kubacki
> <michael.kubacki@microsoft.com>
> 主题: [edk2-devel] [Patch 06/12] MdeModulePkg: Update YAML to ignore
> specific ECC files/errors
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.ci.yaml | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
> b/MdeModulePkg/MdeModulePkg.ci.yaml
> index b8d15a3e952e..f69989087b4c 100644
> --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> @@ -23,12 +23,9 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> - "Library/BrotliCustomDecompressLib/brotli",
> - "Universal/RegularExpressionDxe/oniguruma",
> - "Library/LzmaCustomDecompressLib/Sdk/DOC",
> - "Library/LzmaCustomDecompressLib/Sdk/C",
> - "Universal/RegularExpressionDxe/OnigurumaUefiPort.h",
> - "Universal/RegularExpressionDxe/OnigurumaUefiPort.c"
> + "Library/LzmaCustomDecompressLib",
> + "Library/BrotliCustomDecompressLib",
> + "Universal/RegularExpressionDxe"
> ]
> },
> ## options defined ci/Plugin/CompilerPlugin
> --
> 2.32.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* 回复: [edk2-devel] [Patch 07/12] MdePkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 07/12] MdePkg: " Michael D Kinney
@ 2021-11-27 1:42 ` gaoliming
0 siblings, 0 replies; 33+ messages in thread
From: gaoliming @ 2021-11-27 1:42 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: 'Zhiguang Liu', 'Sean Brogan',
'Bret Barkelew', 'Michael Kubacki'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2021年11月24日 5:21
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Michael Kubacki
> <michael.kubacki@microsoft.com>
> 主题: [edk2-devel] [Patch 07/12] MdePkg: Update YAML to ignore specific
> ECC files/errors
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> MdePkg/MdePkg.ci.yaml | 34 +++++++++++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
> index 3ea8eec33152..054233ebc7bd 100644
> --- a/MdePkg/MdePkg.ci.yaml
> +++ b/MdePkg/MdePkg.ci.yaml
> @@ -17,10 +17,42 @@
> ## "<ErrorID>", "<KeyWord>"
> ## ]
> "ExceptionList": [
> + "9005", "@VDD",
> + "8005", "gST",
> + "8005", "gBS",
> + "8005", "gDS",
> + "8005", "gDS",
> + "8002", "va_list",
> + "8005",
> "EFI_BLUETOOTH_LE_SCAN_CALLBACK_INFORMATION.RSSI",
> + "8005", "void",
> + "8005", "va_list.__ap",
> + "8005", "__stack_chk_guard",
> + "8001", "MSG_IPv6_DP",
> + "8001", "MSG_IPv4_DP",
> + "8001", "DEFAULT_ToS",
> + "8001", "EFI_SERIAL_IO_PROTOCOL_REVISION1p1",
> + "8001", "EFI_ABS_AltActive",
> + "8001", "EFI_ABSP_SupportsAltActive",
> + "8001", "_ReadWriteBarrier",
> + "8001", "__va_copy",
> + "8003", "__va_copy",
> + "7007", "_EFI_LEGACY_SPI_CONTROLLER_PROTOCOL",
> + "7007", "_EFI_LEGACY_SPI_FLASH_PROTOCOL",
> + "7007", "_EFI_SPI_NOR_FLASH_PROTOCOL",
> + "7007", "_EFI_SPI_HC_PROTOCOL",
> + "8002", "aligned (",
> + "4002", "_ReturnAddress"
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> - "Include/IndustryStandard/Acpi64.h"
> + "Include/IndustryStandard/Acpi64.h",
> + "Include/IndustryStandard/Tpm12.h",
> + "Include/IndustryStandard/Tpm20.h",
> + "Include/IndustryStandard/IoRemappingTable.h",
> + "Include/IndustryStandard/UefiTcgPlatform.h",
> + "Include/Library/PcdLib.h",
> + "Include/Library/SafeIntLib.h",
> + "Test/UnitTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.c"
> ]
> },
> ## options defined ci/Plugin/CompilerPlugin
> --
> 2.32.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [EXTERNAL] [Patch 12/12] UnitTestFrameworkPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 12/12] UnitTestFrameworkPkg: " Michael D Kinney
@ 2021-11-27 2:19 ` Bret Barkelew
0 siblings, 0 replies; 33+ messages in thread
From: Bret Barkelew @ 2021-11-27 2:19 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Sean Brogan, Liming Gao, Michael Kubacki
[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Michael D Kinney<mailto:michael.d.kinney@intel.com>
Sent: Tuesday, November 23, 2021 1:21 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Michael Kubacki<mailto:Michael.Kubacki@microsoft.com>
Subject: [EXTERNAL] [Patch 12/12] UnitTestFrameworkPkg: Update YAML to ignore specific ECC files/errors
REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3749&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C7f8dbf0e635b435fe38a08d9aec73d99%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637732993028966105%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=z5uy6%2BorMDeC%2BhrPZe%2Bi4WBAdWWkBqQSbdwJZqe9jCo%3D&reserved=0
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
index 9e9ffc1af113..1b247a831593 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
@@ -15,10 +15,13 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "9005", "@MRT",
+ "7007", "_UNIT_TEST_FAILURE_TYPE_STRING"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
- "Library/CmockaLib/cmocka"
+ "Library/CmockaLib/cmocka",
+ "Library/UnitTestLib/RunTestsCmocka.c"
]
},
## options defined .pytool/Plugin/CompilerPlugin
--
2.32.0.windows.1
[-- Attachment #2: Type: text/html, Size: 5596 bytes --]
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 04/12] CryptoPkg: " Michael D Kinney
[not found] ` <CO1PR11MB4929B441ED557EE00D2596BCD2639@CO1PR11MB4929.namprd11.prod.outlook.com>
@ 2021-11-28 7:33 ` Wang, Jian J
1 sibling, 0 replies; 33+ messages in thread
From: Wang, Jian J @ 2021-11-28 7:33 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Yao, Jiewen, Lu, XiaoyuX, Jiang, Guomin, Sean Brogan,
Bret Barkelew, Liming Gao, Michael Kubacki
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Regards,
Jian
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, November 24, 2021 5:21 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>;
> Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Michael Kubacki <michael.kubacki@microsoft.com>
> Subject: [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC
> files/errors
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index 1448299073de..eeb388ae71c5 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -19,6 +19,9 @@
> ## "<ErrorID>", "<KeyWord>"
> ## ]
> "ExceptionList": [
> + "8001", "IsLeap",
> + "8001", "OBJ_get0_data",
> + "8001", "OBJ_length"
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> @@ -26,14 +29,15 @@
> # The unit testing folder is not to be checked
> "Test/UnitTest",
> # This has OpenSSL interfaces that aren't UEFI spec compliant
> - "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
> + "Library/BaseCryptLib/SysCall",
> # This has OpenSSL interfaces that aren't UEFI spec compliant
> "Library/OpensslLib/rand_pool.c",
> # This has OpenSSL interfaces that aren't UEFI spec compliant
> "Library/Include/CrtLibSupport.h",
> # These directories contain auto-generated OpenSSL content
> - "Library/OpensslLib/X64",
> - "Library/OpensslLib/X64Gcc"
> + "Library/OpensslLib",
> + "Library/IntrinsicLib",
> + "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
> ]
> },
> "CompilerPlugin": {
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 11/12] UefiPayloadPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 11/12] UefiPayloadPkg: " Michael D Kinney
@ 2021-11-29 16:30 ` Guo Dong
0 siblings, 0 replies; 33+ messages in thread
From: Guo Dong @ 2021-11-29 16:30 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Ni, Ray, Ma, Maurice, You, Benjamin, Sean Brogan, Bret Barkelew,
Liming Gao, Michael Kubacki
It looks good to me.
Reviewed-by: Guo Dong <guo.dong@intel.com>
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Tuesday, November 23, 2021 2:21 PM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael Kubacki <michael.kubacki@microsoft.com>
Subject: [Patch 11/12] UefiPayloadPkg: Update YAML to ignore specific ECC files/errors
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
index 35e6fb3540d1..93f4d3603db9 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
+++ b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
@@ -18,6 +18,12 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
+ "Include/Coreboot.h",
+ "Library/CbParseLib/CbParseLib.c",
+ "Library/CbParseLib/CbParseLib.c",
+ "PayloadLoaderPeim/ElfLib/ElfCommon.h",
+ "PayloadLoaderPeim/ElfLib/Elf32.h",
+ "PayloadLoaderPeim/ElfLib/Elf64.h"
]
},
## options defined .pytool/Plugin/CompilerPlugin
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [Patch 05/12] EmulatorPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 05/12] EmulatorPkg: " Michael D Kinney
@ 2021-11-30 5:05 ` Ni, Ray
0 siblings, 0 replies; 33+ messages in thread
From: Ni, Ray @ 2021-11-30 5:05 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Andrew Fish, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, November 24, 2021 5:21 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael Kubacki
> <michael.kubacki@microsoft.com>
> Subject: [Patch 05/12] EmulatorPkg: Update YAML to ignore specific ECC files/errors
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> EmulatorPkg/EmulatorPkg.ci.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml b/EmulatorPkg/EmulatorPkg.ci.yaml
> index 97fdef17abf4..338d5fc2d381 100644
> --- a/EmulatorPkg/EmulatorPkg.ci.yaml
> +++ b/EmulatorPkg/EmulatorPkg.ci.yaml
> @@ -22,6 +22,13 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> + "EmuBlockIoDxe/EmuBlockIo.c",
> + "EmuGopDxe/GopInput.c",
> + "EmuSnpDxe/EmuSnpDxe.c",
> + "EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c",
> + "FvbServicesRuntimeDxe/FWBlockService.c",
> + "Win/Host/WinFileSystem.c",
> + "Win/Host/WinInclude.h"
> ]
> },
> ## options defined .pytool/Plugin/CompilerPlugin
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 09/12] ShellPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 09/12] ShellPkg: " Michael D Kinney
2021-11-24 5:41 ` Gao, Zhichao
@ 2021-11-30 5:05 ` Ni, Ray
1 sibling, 0 replies; 33+ messages in thread
From: Ni, Ray @ 2021-11-30 5:05 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Gao, Zhichao, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, November 24, 2021 5:21 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael Kubacki
> <michael.kubacki@microsoft.com>
> Subject: [Patch 09/12] ShellPkg: Update YAML to ignore specific ECC files/errors
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> ShellPkg/ShellPkg.ci.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
> index 30894d44bc3a..e741402459e5 100644
> --- a/ShellPkg/ShellPkg.ci.yaml
> +++ b/ShellPkg/ShellPkg.ci.yaml
> @@ -15,6 +15,7 @@
> ## "<ErrorID>", "<KeyWord>"
> ## ]
> "ExceptionList": [
> + "8001", "ShellCommandLineParse"
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Patch 08/12] SecurityPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 08/12] SecurityPkg: " Michael D Kinney
@ 2021-11-30 6:03 ` Qi Zhang
0 siblings, 0 replies; 33+ messages in thread
From: Qi Zhang @ 2021-11-30 6:03 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Kumar, Rahul1, Sean Brogan, Bret Barkelew, Liming Gao,
Michael Kubacki
Reviewed-by: Qi Zhang <qi1.zhang@intel.com>
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Wednesday, November 24, 2021 5:21 AM
To: devel@edk2.groups.io
Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael Kubacki <michael.kubacki@microsoft.com>
Subject: [Patch 08/12] SecurityPkg: Update YAML to ignore specific ECC files/errors
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues.
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
SecurityPkg/SecurityPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.ci.yaml b/SecurityPkg/SecurityPkg.ci.yaml index d7b9e1f4e239..791214239899 100644
--- a/SecurityPkg/SecurityPkg.ci.yaml
+++ b/SecurityPkg/SecurityPkg.ci.yaml
@@ -18,6 +18,9 @@
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
+ "Library/TcgStorageCoreLib/TcgStorageUtil.c",
+ "Library/TcgStorageCoreLib/TcgStorageCore.c",
+ "Library/Tpm2CommandLib/Tpm2NVStorage.c"
]
},
"CompilerPlugin": {
--
2.32.0.windows.1
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [edk2-devel] [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors
2021-11-23 21:21 ` [Patch 02/12] ArmPlatformPkg: " Michael D Kinney
2021-11-24 10:36 ` [edk2-devel] " Sami Mujawar
2021-11-24 11:58 ` Leif Lindholm
@ 2021-12-01 14:33 ` PierreGondois
2 siblings, 0 replies; 33+ messages in thread
From: PierreGondois @ 2021-12-01 14:33 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: Leif Lindholm, Ard Biesheuvel, Sean Brogan, Bret Barkelew,
Liming Gao, Michael Kubacki, Sami.mujawar
Hi,
If the exceptions to the yaml files are added to allow the unscrustify patches to pass the CI tests, shouldn't the same exceptions be removed once the patches are merged ?
Regards,
Pierre
On 11/23/21 10:21 PM, Michael D Kinney via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present. These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> index 3dbbcc673bf0..03632e74df73 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> +++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> @@ -19,7 +19,8 @@
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> - "Scripts/Ds5/"
> + "Scripts/Ds5/",
> + "Drivers/PL061GpioDxe/PL061Gpio.c"
> ]
> },
>
^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2021-12-01 14:33 UTC | newest]
Thread overview: 33+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-23 21:21 [Patch 00/12] Update Package YAML to ignore specific ECC files/errors Michael D Kinney
2021-11-23 21:21 ` [Patch 01/12] ArmPkg: Update " Michael D Kinney
2021-11-24 10:35 ` [edk2-devel] " Sami Mujawar
2021-11-24 11:57 ` Leif Lindholm
2021-11-23 21:21 ` [Patch 02/12] ArmPlatformPkg: " Michael D Kinney
2021-11-24 10:36 ` [edk2-devel] " Sami Mujawar
2021-11-24 11:58 ` Leif Lindholm
2021-12-01 14:33 ` PierreGondois
2021-11-23 21:21 ` [Patch 03/12] ArmVirtPkg: " Michael D Kinney
2021-11-24 10:40 ` Sami Mujawar
2021-11-24 11:58 ` Leif Lindholm
2021-11-23 21:21 ` [Patch 04/12] CryptoPkg: " Michael D Kinney
[not found] ` <CO1PR11MB4929B441ED557EE00D2596BCD2639@CO1PR11MB4929.namprd11.prod.outlook.com>
2021-11-27 1:31 ` [edk2-devel] " Yao, Jiewen
2021-11-28 7:33 ` Wang, Jian J
2021-11-23 21:21 ` [Patch 05/12] EmulatorPkg: " Michael D Kinney
2021-11-30 5:05 ` Ni, Ray
2021-11-23 21:21 ` [Patch 06/12] MdeModulePkg: " Michael D Kinney
2021-11-27 1:40 ` 回复: [edk2-devel] " gaoliming
2021-11-23 21:21 ` [Patch 07/12] MdePkg: " Michael D Kinney
2021-11-27 1:42 ` 回复: [edk2-devel] " gaoliming
2021-11-23 21:21 ` [Patch 08/12] SecurityPkg: " Michael D Kinney
2021-11-30 6:03 ` Qi Zhang
2021-11-23 21:21 ` [Patch 09/12] ShellPkg: " Michael D Kinney
2021-11-24 5:41 ` Gao, Zhichao
2021-11-30 5:05 ` Ni, Ray
2021-11-23 21:21 ` [Patch 10/12] StandaloneMmPkg: " Michael D Kinney
2021-11-24 10:55 ` Sami Mujawar
2021-11-24 23:27 ` [edk2-devel] " Michael D Kinney
2021-11-23 21:21 ` [Patch 11/12] UefiPayloadPkg: " Michael D Kinney
2021-11-29 16:30 ` Guo Dong
2021-11-23 21:21 ` [Patch 12/12] UnitTestFrameworkPkg: " Michael D Kinney
2021-11-27 2:19 ` [EXTERNAL] " Bret Barkelew
2021-11-23 23:28 ` [Patch 00/12] Update Package " Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox