From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.193.1637771025294646572 for ; Wed, 24 Nov 2021 08:23:45 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DEC5A1042; Wed, 24 Nov 2021 08:23:44 -0800 (PST) Received: from e126645.nice.arm.com (e126645.nice.arm.com [10.34.125.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 371C53F66F; Wed, 24 Nov 2021 08:23:44 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar Subject: [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001 Date: Wed, 24 Nov 2021 17:23:25 +0100 Message-Id: <20211124162330.236813-6-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com> References: <20211124162330.236813-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Pierre Gondois This patch fixes the following Ecc reported error: 'TAB' character is not allowed in source code, please replace each 'TAB' with two spaces. The patch also format and document the InstallStructures function to comply to edk2 coding style. Signed-off-by: Pierre Gondois --- .../SmbiosPlatformDxe/SmbiosPlatformDxe.c | 38 ++++++++++--------- .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 4 +- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b= /Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c index ac18b16ca676..a5a675b2a613 100644 --- a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -743,36 +743,40 @@ InstallMemoryStructure ( } /** - Install a whole table worth of structructures + Install a whole table worth of structures. - @parm + @param [in] Smbios Smbios protocol. + @param [in] DefaultTables Default Smbios tables. + + @retval EFI_SUCCESS Record was added. + @retval EFI_OUT_OF_RESOURCES Record was not added. + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in was already i= n use. **/ EFI_STATUS InstallStructures ( - IN EFI_SMBIOS_PROTOCOL *Smbios, - IN CONST VOID *DefaultTables[] + IN EFI_SMBIOS_PROTOCOL *Smbios, + IN CONST VOID *DefaultTables[] ) { EFI_STATUS Status =3D EFI_SUCCESS; EFI_SMBIOS_HANDLE SmbiosHandle; + UINTN TableEntry; - int TableEntry; - for ( TableEntry=3D0; DefaultTables[TableEntry] !=3D NULL; TableEntr= y++) - { - SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry])-= >Handle; - Status =3D Smbios->Add ( - Smbios, - NULL, - &SmbiosHandle, - (EFI_SMBIOS_TABLE_HEADER*) DefaultTables[TableEntry] - ); - if (EFI_ERROR(Status)) - break; + for (TableEntry =3D 0; DefaultTables[TableEntry] !=3D NULL; TableEnt= ry++) { + SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEnt= ry])->Handle; + Status =3D Smbios->Add ( + Smbios, + NULL, + &SmbiosHandle, + (EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEn= try] + ); + if (EFI_ERROR(Status)) { + break; + } } return Status; } - /** Install all structures from the DefaultTables structure diff --git a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h= b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h index 601714c94387..e50c458f8c3a 100644 --- a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h +++ b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h @@ -45,7 +45,7 @@ Lan9118RawMmioRead32( UINTN Delay ); #define Lan9118MmioRead32(a) \ - Lan9118RawMmioRead32(a, a ## _RD_DELAY) + Lan9118RawMmioRead32(a, a ## _RD_DELAY) UINT32 Lan9118RawMmioWrite32( @@ -54,7 +54,7 @@ Lan9118RawMmioWrite32( UINTN Delay ); #define Lan9118MmioWrite32(a, v) \ - Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) + Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) /* ------------------ MAC CSR Access ------------------- */ -- 2.25.1