From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io
Cc: Sami Mujawar <sami.mujawar@arm.com>
Subject: [PATCH edk2-platforms v1 06/10] Platform/ARM: Fix Ecc error 1008
Date: Wed, 24 Nov 2021 17:23:26 +0100 [thread overview]
Message-ID: <20211124162330.236813-7-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20211124162330.236813-1-Pierre.Gondois@arm.com>
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
File has invalid Non-ACSII char.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.../Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
index b51e2b3fa1a6..90907bc19a8f 100644
--- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
+++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
@@ -259,7 +259,7 @@ UpdateMemorySize (
}
/* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134,
- Table 75 – Memory Device (Type 17) structure, description for Size field.
+ Table 75 - Memory Device (Type 17) structure, description for Size field.
If the value is 0, no memory device is installed in the socket; if
the size is unknown, the field value is FFFFh.
*/
@@ -276,13 +276,13 @@ UpdateMemorySize (
}
/* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134,
- Table 75 – Memory Device (Type 17) structure, description for Size field.
+ Table 75 - Memory Device (Type 17) structure, description for Size field.
If the size is 32 GB-1 MB or greater, the field value is 7FFFh and the
actual size is stored in the Extended Size field.
*/
if (MemorySize < (SIZE_32GB - SIZE_1MB)) {
/* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134,
- section 7.18.5 Memory Device — Extended Size
+ section 7.18.5 Memory Device - Extended Size
For compatibility with older SMBIOS parsers, memory devices
smaller than (32 GB - 1 MB) should be represented using their
size in the Size field, leaving the Extended Size field set to 0.
@@ -290,7 +290,7 @@ UpdateMemorySize (
Type17Table->ExtendedSize = 0;
/* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134,
- Table 75 – Memory Device (Type 17) structure, description for Size field.
+ Table 75 - Memory Device (Type 17) structure, description for Size field.
The granularity in which the value is specified depends on the setting
of the most-significant bit (bit 15). If the bit is 0, the value is
specified in megabyte units; if the bit is 1, the value is specified
@@ -308,7 +308,7 @@ UpdateMemorySize (
}
/* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134,
- section 7.18.5 Memory Device — Extended Size
+ section 7.18.5 Memory Device - Extended Size
The Extended Size field is intended to represent memory devices
larger than 32,767 MB (32 GB - 1 MB), which cannot be described
using the Size field. This field is only meaningful if the value
@@ -317,12 +317,12 @@ UpdateMemorySize (
Type17Table->Size = 0x7FFF;
/* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0134,
- section 7.18.5 Memory Device — Extended Size
+ section 7.18.5 Memory Device - Extended Size
Bit 31 is reserved for future use and must be set to 0.
Bits 30:0 represent the size of the memory device in megabytes.
EXAMPLE: 0000_8000h indicates a 32 GB memory device (32,768 MB),
0002_0000h represents a 128 GB memory device (131,072 MB), and
- 0000_7FFFh represents a 32,767 MB (32 GB – 1 MB) device.
+ 0000_7FFFh represents a 32,767 MB (32 GB - 1 MB) device.
*/
Type17Table->ExtendedSize = (MemorySize >> 20) & (~BIT31);
return EFI_SUCCESS;
--
2.25.1
next prev parent reply other threads:[~2021-11-24 16:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 16:23 [PATCH edk2-platforms v1 00/10] Fix Arm platforms CI errors PierreGondois
2021-11-24 16:23 ` [PATCH edk2-platforms v1 01/10] Platform/ARM: Modify duplicated GUID in PciHostBridgeLib PierreGondois
2021-12-17 14:14 ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 02/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLib PierreGondois
2021-12-17 14:14 ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec PierreGondois
2021-12-17 13:59 ` Sami Mujawar
2021-12-17 14:15 ` PierreGondois
2021-12-17 16:30 ` Sami Mujawar
2021-12-17 16:33 ` [edk2-devel] " Ard Biesheuvel
2021-12-17 16:39 ` Sami Mujawar
2021-12-20 9:29 ` wenyi,xie
2021-11-24 16:23 ` [PATCH edk2-platforms v1 04/10] Platform/ARM: Modify duplicated GUID in ArmVExpressPkg.dec PierreGondois
2021-12-17 14:14 ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001 PierreGondois
2021-12-17 14:15 ` Sami Mujawar
2021-11-24 16:23 ` PierreGondois [this message]
2021-12-17 14:15 ` [PATCH edk2-platforms v1 06/10] Platform/ARM: Fix Ecc error 1008 Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 07/10] Platform/ARM: Fix Ecc error 1012 PierreGondois
2021-12-17 14:15 ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 08/10] Platform/ARM: Fix Ecc error 3003 PierreGondois
2021-12-17 14:15 ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 09/10] Platform/ARM: Fix Ecc error 9005 PierreGondois
2021-12-17 14:15 ` Sami Mujawar
2021-11-24 16:23 ` [PATCH edk2-platforms v1 10/10] Platform/ARM: Fix Ecc error 5005 PierreGondois
2021-12-17 14:16 ` Sami Mujawar
2021-11-24 18:34 ` [edk2-devel] [PATCH edk2-platforms v1 00/10] Fix Arm platforms CI errors Chris Jones
2022-01-24 14:31 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124162330.236813-7-Pierre.Gondois@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox