From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.77885.1638287489941159926
 for <devel@edk2.groups.io>;
 Tue, 30 Nov 2021 07:51:30 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F8X7A9op;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638287488;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Gc1c37D4Q1GqnTeaNctWB3PUfzQ8FUaKlnOmDbPpFEI=;
	b=F8X7A9opYMd4RPHIn6FNMix1aTdzmKtYHVMY7fKx5bAiKly1eFEzpQTgA/ziD9dbVSEw/Q
	co58DGaBFevKZeTE80lzZMIKgSNaaaOwZ+vldq+i0eODkC/VbgnWFU37L+QRxQA5yZy1WN
	qkeAjgwwQqSzYCtshfIe1R+Uz3Fhx/Q=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-477-__SZVOurO4KMt0woX39znQ-1; Tue, 30 Nov 2021 10:51:24 -0500
X-MC-Unique: __SZVOurO4KMt0woX39znQ-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D8791006AA6;
	Tue, 30 Nov 2021 15:51:19 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.79])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 13E3D5D9D5;
	Tue, 30 Nov 2021 15:51:19 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 0171B18000B2; Tue, 30 Nov 2021 16:51:16 +0100 (CET)
Date: Tue, 30 Nov 2021 16:51:16 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, brijesh.singh@amd.com
Cc: Tom Lendacky <thomas.lendacky@amd.com>, qi zhou <atmgnd@outlook.com>,
	"erdemaktas@google.com" <erdemaktas@google.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"jiewen.yao@intel.com" <jiewen.yao@intel.com>,
	"min.m.xu@intel.com" <min.m.xu@intel.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/MemEncryptSevLib: check CPUID when read msr during PEI phase
Message-ID: <20211130155116.a5weqz7o6knepxio@sirius.home.kraxel.org>
References: <SYZP282MB32522731273150B71736A880C9629@SYZP282MB3252.AUSP282.PROD.OUTLOOK.COM>
 <daa9613e-c4d9-42d6-65c9-9a6b35aee91f@amd.com>
 <37990bf4-d440-ce19-367b-8498c153ca76@amd.com>
MIME-Version: 1.0
In-Reply-To: <37990bf4-d440-ce19-367b-8498c153ca76@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> What is missing in the original patch set is that now with the common work
> area we need to check the Guest Type before accessing the SevEs workarea
> type. I have a patch in my wip to cleanup the SEV feature detection check
> and patiently waiting for the SEV-SNP series to land so that I can submit
> other patches.

Can you prepare a version of the fix which does not depend on the snp
series and can be applied to edk2-stable202111?

thanks,
  Gerd