From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.92799.1638368837858716921
 for <devel@edk2.groups.io>;
 Wed, 01 Dec 2021 06:27:18 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eI1Rrc7m;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638368837;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=2O2yrehv+np1opM9TbgwI7zwaoQIDbLShm7JiIAwmC0=;
	b=eI1Rrc7mz25qJbluiFjnlxaMTZ/h9SISXBq6VdGHux4OJyysaIpbECWUj07O1D/sii959z
	V27Xv0lE2eEDZqixwu1gNDJiqpNLj9sVzuxTIiCg+u0WWb2spL0M6H9guRbjfPs2D8sfPT
	2C8PCMqf1J2Q5pW5JNy3xJVWGRKkYyo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-449-W6HTylSFO9qzabnRkuhXhQ-1; Wed, 01 Dec 2021 09:27:14 -0500
X-MC-Unique: W6HTylSFO9qzabnRkuhXhQ-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94FE9107B0E0;
	Wed,  1 Dec 2021 14:27:13 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.79])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 42E1D18A60;
	Wed,  1 Dec 2021 14:27:13 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 698DD1800922; Wed,  1 Dec 2021 15:27:11 +0100 (CET)
Date: Wed, 1 Dec 2021 15:27:11 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: sebastien.boeuf@intel.com
Cc: devel@edk2.groups.io, jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [PATCH 3/5] OvmfPkg: Retrieve SMBIOS from Cloud Hypervisor
Message-ID: <20211201142711.lwchupkvcsx3njwt@sirius.home.kraxel.org>
References: <cover.1638351613.git.sebastien.boeuf@intel.com>
 <5b0c68b9298a088d283b7ebf78b5b542517c946d.1638351613.git.sebastien.boeuf@intel.com>
MIME-Version: 1.0
In-Reply-To: <5b0c68b9298a088d283b7ebf78b5b542517c946d.1638351613.git.sebastien.boeuf@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

>    Status = EFI_NOT_FOUND;
>    //
>    // Add QEMU SMBIOS data if found
>    //
>    SmbiosTables = GetQemuSmbiosTables ();
> -  if (SmbiosTables != NULL) {
> -    Status = InstallAllStructures (SmbiosTables);
> +  if (SmbiosTables == NULL) {
> +    SmbiosTables = GetCloudHvSmbiosTables ();

Check PcdOvmfHostBridgePciDevId here to figure whenever
GetQemuSmbiosTables or GetCloudHvSmbiosTables should be called?

Should be more robust and give us a slightly less messy code flow,
specifically when it comes to flip FreeTables to true for the qemu
case.

take care,
  Gerd