From: "Gerd Hoffmann" <kraxel@redhat.com>
To: sebastien.boeuf@intel.com
Cc: devel@edk2.groups.io, jiewen.yao@intel.com, jordan.l.justen@intel.com
Subject: Re: [PATCH 5/5] OvmfPkg: Install ACPI tables for Cloud Hypervisor
Date: Wed, 1 Dec 2021 15:30:33 +0100 [thread overview]
Message-ID: <20211201143033.mxxgxg76vnzrey6o@sirius.home.kraxel.org> (raw)
In-Reply-To: <83041af43c916d2d89caabd6d7b002d1e30456d3.1638351613.git.sebastien.boeuf@intel.com>
On Wed, Dec 01, 2021 at 12:04:36PM +0100, sebastien.boeuf@intel.com wrote:
> From: Sebastien Boeuf <sebastien.boeuf@intel.com>
>
> Adding support for retrieving the Cloud Hypervisor ACPI tables as a
> fallback mechanism if tables are not found through fw_cfg.
>
> Signed-off-by: Rob Bradford <robert.bradford@intel.com>
> Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
> ---
> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 +
> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 6 +
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 +
> OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 117 ++++++++++++++++++++
> OvmfPkg/Include/IndustryStandard/CloudHv.h | 5 +
> 5 files changed, 133 insertions(+)
> create mode 100644 OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c
>
> diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c
> index 613a8ac97f..abd1f550d4 100644
> --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c
> +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c
> @@ -29,5 +29,9 @@ InstallAcpiTables (
> EFI_STATUS Status;
>
> Status = InstallQemuFwCfgTables (AcpiTable);
> + if (EFI_ERROR (Status)) {
> + Status = InstallCloudHvTables (AcpiTable);
> + }
Same here, I think you should use the host bridge pcd.
take care,
Gerd
prev parent reply other threads:[~2021-12-01 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 12:01 [PATCH 0/5] Add Cloud Hypervisor support for x86 sebastien.boeuf
2021-12-01 12:01 ` [PATCH 1/5] OvmfPkg: Handle Cloud Hypervisor host bridge sebastien.boeuf
2021-12-01 14:16 ` Gerd Hoffmann
2021-12-01 12:01 ` [PATCH 2/5] OvmfPkg: Create global entry point for SMBIOS parsing sebastien.boeuf
2021-12-01 14:21 ` Gerd Hoffmann
2021-12-01 12:01 ` [PATCH 3/5] OvmfPkg: Retrieve SMBIOS from Cloud Hypervisor sebastien.boeuf
2021-12-01 14:27 ` Gerd Hoffmann
2021-12-01 12:01 ` [PATCH 4/5] OvmfPkg: Generalize AcpiPlatformDxe sebastien.boeuf
2021-12-01 14:28 ` Gerd Hoffmann
2021-12-01 12:01 ` [PATCH 5/5] OvmfPkg: Install ACPI tables for Cloud Hypervisor sebastien.boeuf
2021-12-01 14:30 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201143033.mxxgxg76vnzrey6o@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox