From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.92839.1638369039680230334 for ; Wed, 01 Dec 2021 06:30:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SUyT9etk; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638369038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nAB08ZsQIejyu49f69oQUb/5ycViSYfsioXA+mmFHT8=; b=SUyT9etkD38Pn+K4dN2hAf3A8S/DWxROiJhxNc05WZ5ONxaApXi2TBPumk/SQXwjUPCuhQ IdEVV8tJz/ot95Im18syn/wmiPhd0qxCoxJ+kpcqetIPUjQrFBoqhZYO4xiiL5wl/8/31S LT/XgGJXiavJ1USlmAN+bujk8R4aq5c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-560-NABfS5FtOsyDZ1GuEWVFpw-1; Wed, 01 Dec 2021 09:30:37 -0500 X-MC-Unique: NABfS5FtOsyDZ1GuEWVFpw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC8E0344AF; Wed, 1 Dec 2021 14:30:35 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6FFFF60C05; Wed, 1 Dec 2021 14:30:35 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6B0C11800922; Wed, 1 Dec 2021 15:30:33 +0100 (CET) Date: Wed, 1 Dec 2021 15:30:33 +0100 From: "Gerd Hoffmann" To: sebastien.boeuf@intel.com Cc: devel@edk2.groups.io, jiewen.yao@intel.com, jordan.l.justen@intel.com Subject: Re: [PATCH 5/5] OvmfPkg: Install ACPI tables for Cloud Hypervisor Message-ID: <20211201143033.mxxgxg76vnzrey6o@sirius.home.kraxel.org> References: <83041af43c916d2d89caabd6d7b002d1e30456d3.1638351613.git.sebastien.boeuf@intel.com> MIME-Version: 1.0 In-Reply-To: <83041af43c916d2d89caabd6d7b002d1e30456d3.1638351613.git.sebastien.boeuf@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 01, 2021 at 12:04:36PM +0100, sebastien.boeuf@intel.com wrote: > From: Sebastien Boeuf > > Adding support for retrieving the Cloud Hypervisor ACPI tables as a > fallback mechanism if tables are not found through fw_cfg. > > Signed-off-by: Rob Bradford > Signed-off-by: Sebastien Boeuf > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 + > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 6 + > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 + > OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 117 ++++++++++++++++++++ > OvmfPkg/Include/IndustryStandard/CloudHv.h | 5 + > 5 files changed, 133 insertions(+) > create mode 100644 OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c > > diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c > index 613a8ac97f..abd1f550d4 100644 > --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c > +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c > @@ -29,5 +29,9 @@ InstallAcpiTables ( > EFI_STATUS Status; > > Status = InstallQemuFwCfgTables (AcpiTable); > + if (EFI_ERROR (Status)) { > + Status = InstallCloudHvTables (AcpiTable); > + } Same here, I think you should use the host bridge pcd. take care, Gerd