From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.48570.1638775439797661672 for ; Sun, 05 Dec 2021 23:24:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=biWAncOy; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638775438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2xiN/fSxQrquT6hekxgoUBt6Mnzl/ck8rp0HNyG4/qg=; b=biWAncOyIvk0FlPiA2N4HW5FmyBgm9pTinScLZ5MyV/oD+WBlt6aqSUF0bUMMjZitlGaId +zhh5qNadp5leG8HYDAxUdCIhrjLVVtveWn50Ob9UhZw3sxuNO3aDuIH1IyOJCRuL602U3 9wjTTlxd7UJBF13nlRja6xoq/w81YU8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-kzEIklJ4OGW8m_CntfgUYA-1; Mon, 06 Dec 2021 02:23:57 -0500 X-MC-Unique: kzEIklJ4OGW8m_CntfgUYA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 174A91006AA0; Mon, 6 Dec 2021 07:23:56 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C697322DF6; Mon, 6 Dec 2021 07:23:55 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0B59D18003A7; Mon, 6 Dec 2021 08:23:54 +0100 (CET) Date: Mon, 6 Dec 2021 08:23:54 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Yao, Jiewen" , "Wang, Jian J" , "Jiang, Guomin" , Pawel Polawski , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror Message-ID: <20211206072354.tr6uhkk5nnsi7m3r@sirius.home.kraxel.org> References: <20211203160748.866150-1-kraxel@redhat.com> <20211203160748.866150-25-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 03, 2021 at 04:27:02PM +0000, Michael D Kinney wrote: > You should be able to undefine MIN at the right place instead of turning off all warnings as errors. Not so easy unfortunately. Tried that in CryptoPkg/Library/Include/CrtLibSupport.h (which is the place where all the other #defines to make openssl build for edk2 are). Result was I got errors elsewhere (BaseCryptLib IIRC) that MIN is undeclared ... take care, Gerd