From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.48492.1638776329721660203 for ; Sun, 05 Dec 2021 23:38:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DNhBVooQ; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638776328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKjKocq5jmUZmWe0fxs/eb1QNwDElOuaesomrhSGqHI=; b=DNhBVooQ0UhMxSC7pM85vMEM+iqSz1Yu4yVQW7TH/9uFZocPdGlpqUfrUt8LhTSDmjkgTA JkwbUS5yCbkr9N3zRzq4+5Li90uPdLSQs8mRk82DS1e8j/vRBD8Ezr8NqmXDIfz2X8mva0 eSP0KcxQod5tEp3ZfcCYo6ALY7DpvcA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-200-twk4jihoNdi_3ykqzyNS1A-1; Mon, 06 Dec 2021 02:38:46 -0500 X-MC-Unique: twk4jihoNdi_3ykqzyNS1A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C35BB344AF; Mon, 6 Dec 2021 07:38:44 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE88B5DF4F; Mon, 6 Dec 2021 07:38:35 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2F43A18003A7; Mon, 6 Dec 2021 08:38:34 +0100 (CET) Date: Mon, 6 Dec 2021 08:38:34 +0100 From: "Gerd Hoffmann" To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "pedro.falcato@gmail.com" , "Yao, Jiewen" , "Wang, Jian J" , "Jiang, Guomin" , Pawel Polawski , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror Message-ID: <20211206073834.aou2xgmqc6w6hg62@sirius.home.kraxel.org> References: <20211203160748.866150-1-kraxel@redhat.com> <20211203160748.866150-25-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Dec 03, 2021 at 06:38:52PM +0000, Kinney, Michael D wrote: > Hi Pedro, > > If there are specific issues with specific submodules, I would prefer > that we disable only the specific subset of warnings that are > triggered by that one project. Disabling all warnings as errors may > hide way too much. > > The INF file for building a lib that uses submodule content can append > CC_FLAGS with specific warning disable. We did this approach for the > Python3 work in edk2-libc. I think we ran into issue around MIN() > macro as well, but I can’t recall exactly how we fixed it. There are a bunch of these -Wno-error= in CryptoPkg/Library/OpensslLib/OpensslLib*.inf already. > > workaround for this: > > CryptoPkg/Library/OpensslLib/openssl/providers/implementations/kdfs/kbkdf.c:49: warning: "MIN" redefined Couldn't figure whenever there is a switch to turn off this one specifically. Newer gcc typically prints which -W enables the warning printed. Not sure why this didn't happen here, maybe because it is cpp throwing the warning here. The cpp man-page likewise doesn't help much :( take care, Gerd