From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web09.50484.1638793148018808859 for ; Mon, 06 Dec 2021 04:19:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WXaXaYnh; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638793147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vG6QH/uKHCvE67mPWyiOLDG7Pd4eoeZ8RMGayaVCvpY=; b=WXaXaYnhnP2avc70uRYtklpJ+++M1+8m9NWaX06wKBtdauMnxa3fjsTMhXzFUqh+NLdkpO e8E17RkMLF5QaweXCbqyuNuKImnzPrzjo5MJgAKF3oWnFzW0AFNdGeUR12yumRwNlYgt+d ruGArzqbPMYoz7koTy1ooRkoJKmor0U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-PJr1hsO-PFq3z0d3K4nPEg-1; Mon, 06 Dec 2021 07:19:03 -0500 X-MC-Unique: PJr1hsO-PFq3z0d3K4nPEg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4DF41927800; Mon, 6 Dec 2021 12:19:02 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1791D1B480; Mon, 6 Dec 2021 12:19:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 559F318003B3; Mon, 6 Dec 2021 13:18:59 +0100 (CET) Date: Mon, 6 Dec 2021 13:18:59 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, lixianglai@loongson.cn Subject: Re: [edk2-devel] [PATCH] OvmfPkg-EmuVariableFvbRuntimeDxe: Support Access To Memory Above 4G Message-ID: <20211206121859.vqw2jfpxdagi5hvw@sirius.home.kraxel.org> References: <13a7bcbac5bbc7f9cd6a26d6d8ac4eb30f059ec2.1638759596.git.lixianglai@loongson.cn> MIME-Version: 1.0 In-Reply-To: <13a7bcbac5bbc7f9cd6a26d6d8ac4eb30f059ec2.1638759596.git.lixianglai@loongson.cn> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 06, 2021 at 12:00:33PM +0800, xianglai wrote: > In FvbInitialize Function, > PcdFlashNvStorageVariableBase64 PcdFlashNvStorageFtwWorkingBase > PcdFlashNvStorageFtwSpareBase will not exceed 0x100000000, > Due to truncation and variable type limitations. > That leads to the NV variable cannot be saved to the memory above 4G. > > Modify as follows: > 1.Remove the forced type conversion of UINT32. > 2.Use UINT64 type variables. > > Signed-off-by: xianglai li Reviewed-by: Gerd Hoffmann