public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Jiewen Yao" <jiewen.yao@intel.com>,
	"Pawel Polawski" <ppolawsk@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH v3 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg
Date: Mon, 13 Dec 2021 12:26:46 +0100	[thread overview]
Message-ID: <20211213112646.kfhq4b44m2ugcupg@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAMj1kXHfCowoUZwEpRhb2Fb9cQ=bQNA8JBtCtEFKhAkz_ZGLNg@mail.gmail.com>

  Hi,

> > @@ -368,6 +412,7 @@ MiscInitialization (
> >        break;
> >      case 0xffff: /* microvm */
> >        DEBUG ((DEBUG_INFO, "%a: microvm\n", __FUNCTION__));
> > +      MicrovmInitialization ();
> 
> Is this the best spot for calling Microvm related init code that is
> entirely unrelated to PCIe?

Looked like the best place to me.  Various platform-specific
initialization happens there.  And, yes, for 'pc' and 'q35'
qemu machines this includes pci host bridge setup.

Do you have a better suggestion?

take care,
  Gerd


  reply	other threads:[~2021-12-13 11:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  8:16 [PATCH v3 0/5] OvmfPkg/Microvm: second batch of microvm patches Gerd Hoffmann
2021-12-13  8:16 ` [PATCH v3 1/5] OvmfPkg/Microvm/fdt: add device tree support Gerd Hoffmann
2021-12-13  9:38   ` Philippe Mathieu-Daudé
2021-12-13  8:16 ` [PATCH v3 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg Gerd Hoffmann
2021-12-13  9:33   ` Philippe Mathieu-Daudé
2021-12-13 11:21     ` Gerd Hoffmann
2021-12-13  9:43   ` [edk2-devel] " Ard Biesheuvel
2021-12-13 11:26     ` Gerd Hoffmann [this message]
2021-12-13 11:30       ` Ard Biesheuvel
2021-12-13  8:16 ` [PATCH v3 3/5] OvmfPkg/Microvm/fdt: add empty fdt Gerd Hoffmann
2021-12-13  9:35   ` Philippe Mathieu-Daudé
2021-12-13  8:16 ` [PATCH v3 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support Gerd Hoffmann
2021-12-13  9:38   ` Philippe Mathieu-Daudé
2021-12-13  8:16 ` [PATCH v3 5/5] OvmfPkg/Microvm: add README Gerd Hoffmann
2021-12-13  9:37   ` Philippe Mathieu-Daudé
2021-12-13 12:18 ` [PATCH v3 0/5] OvmfPkg/Microvm: second batch of microvm patches Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213112646.kfhq4b44m2ugcupg@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox