From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web08.9818.1639394813977039443
 for <devel@edk2.groups.io>;
 Mon, 13 Dec 2021 03:26:54 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VUIIlYB6;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639394813;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Ciz4bRhMGvkgY+uoLRvIIXTd+zY5hhnghNBekYAY/v0=;
	b=VUIIlYB64+1Wnd9TYnChPeEESfeAkFGnUVVarrBxavgooSCNxfU+STNvSl+V2xf9DRtjVw
	00epMm9X27HktnHMAmDUYE10UV8FhoQ94bXMhF4NELG5KVhLeS4yc7/jUO8auY0+qEtFjB
	lJOPA8YMi//DQi69ICTJcXWYzYZNsaU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-503-Ao4mbZcQMs2ebP06im663Q-1; Mon, 13 Dec 2021 06:26:50 -0500
X-MC-Unique: Ao4mbZcQMs2ebP06im663Q-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C7660801962;
	Mon, 13 Dec 2021 11:26:48 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 35EE45C23A;
	Mon, 13 Dec 2021 11:26:48 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 6BB9B180009C; Mon, 13 Dec 2021 12:26:46 +0100 (CET)
Date: Mon, 13 Dec 2021 12:26:46 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH v3 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg
Message-ID: <20211213112646.kfhq4b44m2ugcupg@sirius.home.kraxel.org>
References: <20211213081658.3535809-1-kraxel@redhat.com>
 <20211213081658.3535809-3-kraxel@redhat.com>
 <CAMj1kXHfCowoUZwEpRhb2Fb9cQ=bQNA8JBtCtEFKhAkz_ZGLNg@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAMj1kXHfCowoUZwEpRhb2Fb9cQ=bQNA8JBtCtEFKhAkz_ZGLNg@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > @@ -368,6 +412,7 @@ MiscInitialization (
> >        break;
> >      case 0xffff: /* microvm */
> >        DEBUG ((DEBUG_INFO, "%a: microvm\n", __FUNCTION__));
> > +      MicrovmInitialization ();
> 
> Is this the best spot for calling Microvm related init code that is
> entirely unrelated to PCIe?

Looked like the best place to me.  Various platform-specific
initialization happens there.  And, yes, for 'pc' and 'q35'
qemu machines this includes pci host bridge setup.

Do you have a better suggestion?

take care,
  Gerd