From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (EUR03-AM5-obe.outbound.protection.outlook.com [40.107.3.44]) by mx.groups.io with SMTP id smtpd.web08.25050.1639485480430701929 for ; Tue, 14 Dec 2021 04:38:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=QtI1yHNb; spf=pass (domain: arm.com, ip: 40.107.3.44, mailfrom: christopher.jones@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMEo3JahRyrfJWrCjSYXF597cglif6beEcuV3ksuRhU=; b=QtI1yHNb7sbW5rZchLibwzKdZZSFn25bX2gG7JXOpOu2srR8lx9EoOZQU60dRCNN+d4BnwE0t+SOZ4lmAlV3p66a5ZdOEIEYNpxtO/YnoVj+POGLmp9ZyN9P08uhY2KEflwTOMvm0+86hG3liMwfOPMVsEbK10B9KmO2h/S4BBY= Received: from DU2PR04CA0186.eurprd04.prod.outlook.com (2603:10a6:10:28d::11) by DB7PR08MB2971.eurprd08.prod.outlook.com (2603:10a6:5:1c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Tue, 14 Dec 2021 12:37:57 +0000 Received: from DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::a2) by DU2PR04CA0186.outlook.office365.com (2603:10a6:10:28d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13 via Frontend Transport; Tue, 14 Dec 2021 12:37:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT053.mail.protection.outlook.com (10.152.21.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Tue, 14 Dec 2021 12:37:57 +0000 Received: ("Tessian outbound dbb52aec1fa6:v110"); Tue, 14 Dec 2021 12:37:57 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fd114836839ee9cf X-CR-MTA-TID: 64aa7808 Received: from 0d7ee32b26e6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9771D98C-3692-44F9-87FE-BEADF90FD881.1; Tue, 14 Dec 2021 12:37:49 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0d7ee32b26e6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 14 Dec 2021 12:37:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOeKzdlJhZvqut4KJHSsl4LtK1/6zZAYNwSBj3F4crZbxSrlECxFtKLUjILabnIgf+kEn01hiY+gI66pHwvv3fIj74bQ+oRgP8IFCIq0gh4su1w6jn4BRfHYcPkhreu4g/WycjuTPTLyis1Ycv6t3o8kafns3m5TfPplfuLGVgojtqKyb2f6LIZvdDZBqWfTvwociIXFX8lLKu8fG25yIt9rGYR0dMeiTkEyBlJHjT9K6jfaDzrAV2luT5p5NNcJTxSokCEMUP3BjrVOSJubUBSKs7ANUiUNVqv0gzv94geohRr7zK8as889uOl0P2p4FVeqFPkuAsTwb1YJtyqgNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMEo3JahRyrfJWrCjSYXF597cglif6beEcuV3ksuRhU=; b=gFkeo8/7IUhYlePy4ntGn1R2ib5cDLs3tZW3iO9kMz0wuROVLgHtajBxQtj90I3RIkUXxJ1WQwRx9xKSSqvAkmuAIJMHJsa0+7SLh+UstWgE4JiDrjJ9U76sRL8Ei9feCswBjIg+NlCBmc7eRjciRdK6T+XVGPzEmzOvLVXuAAB0hbED+c/ZylY3QMg9fRIvGsatnbmVszx8VW4pCbtKOVI7BPFe/QEWWYor/EUhjd0Xj9yVH6OniS21dgboy7mXvQuzEosbw5SMvMZ5bqGDKcL7l7cshmV/jI3cZK4GtPKkdxhuEwOtyvW6+OMNjQAVeJPaOqHfBbRZeQFgMQuBqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMEo3JahRyrfJWrCjSYXF597cglif6beEcuV3ksuRhU=; b=QtI1yHNb7sbW5rZchLibwzKdZZSFn25bX2gG7JXOpOu2srR8lx9EoOZQU60dRCNN+d4BnwE0t+SOZ4lmAlV3p66a5ZdOEIEYNpxtO/YnoVj+POGLmp9ZyN9P08uhY2KEflwTOMvm0+86hG3liMwfOPMVsEbK10B9KmO2h/S4BBY= Received: from AS8PR04CA0099.eurprd04.prod.outlook.com (2603:10a6:20b:31e::14) by AS8PR08MB7322.eurprd08.prod.outlook.com (2603:10a6:20b:441::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 14 Dec 2021 12:37:43 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::47) by AS8PR04CA0099.outlook.office365.com (2603:10a6:20b:31e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16 via Frontend Transport; Tue, 14 Dec 2021 12:37:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4778.12 via Frontend Transport; Tue, 14 Dec 2021 12:37:43 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 12:37:41 +0000 Received: from e125153.arm.com (10.57.6.75) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Tue, 14 Dec 2021 12:37:37 +0000 From: "Chris Jones" To: CC: , , , , Subject: [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference Date: Tue, 14 Dec 2021 12:37:36 +0000 Message-ID: <20211214123736.10854-1-christopher.jones@arm.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: f1ddf3b3-a448-44fa-2468-08d9befe8ebd X-MS-TrafficTypeDiagnostic: AS8PR08MB7322:EE_|DB5EUR03FT053:EE_|DB7PR08MB2971:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:935;OLM:935; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: e12ugyiye+MnRUlQZdlQwyIkndtheixJ9WYcRlByxzVXJCUtIkLcIgh+dy4Lfew/x2D5JCNWgVSkg3aJY+vDVtWhf9NaiRUqauDHVJeqa0kyfSC9wOGGEy3l1vyRsfA/gb6sOqAbeWnXCuVAO8Rs43QiQobbpcHHG3J+d7NabeROEKGuXh/DcnfcRsWeWElx0FLlkU+bV0najd92tvQ85NkMGpY7txaCfa7VH+O/g3Pu3OPSn4nU8H1Rbc9QZpdT2HWQUMd/MbytnchDxx7XNL0yI+2Pv0UCAcH2OQPJmDN9HS9Sb0DUwgO/NU9EroHL7+6mtIm5B7HF4whPFNSaFklWDRvaqVSzdclSfuHXPBPoLUwa0uiQRGIa8WIJe24ko9YcdVDEOM1rCdeSf/vZbzW5ALX/wXlJhGlw5V9W9DZcfJrwAR0npm+08gBcbVF04WUPT/OgHksKL++TuD6b+QK9y0Ed/EXFPiWKDBpyPb+Dx57I6elSGP8Hr7zysacvmGnIIeY0wkQ02FzMGoZC1PqoD/ZBmQr5D/g+TJpxIo1dn9wq3JzbVCd9UNhXXrtlToZfxUNie+UigAph4OEJwwgHmHE1v8yucXXTqIl/g5WsYvguJuO7Y7imB1fsGn+PD5XJmFtRt1iWZ6u5HW1ZNCOFPDn2r3Us563PvFexmC0ecPHB5aWYmUU+r16tDLyEV1rWghpeGH0I+Q76gLjiSRjxkdo6fP0miUf4uejAlIPvskbLb4xP08+bYFSfud6Vcq2n9HkB7vOPGzSdF2D6Z5Uc3TwTJ6PVpxJVPXS5VZbbqk+G0PhCpsipXU2JsbW7MAZC5P5dWBrIztR7INELxpzEv164D49/mUe3OTxPBV7yE8/yXlvLhHUViZtgyKSI X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(40460700001)(4326008)(8676002)(6916009)(316002)(26005)(86362001)(54906003)(186003)(36860700001)(82310400004)(508600001)(36756003)(5660300002)(81166007)(336012)(426003)(70586007)(356005)(2616005)(7696005)(8936002)(2906002)(47076005)(83380400001)(70206006)(1076003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7322 Return-Path: Christopher.Jones@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03f6777b-851a-4437-430b-08d9befe8635 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NOsqmk4hMui/w0Jjf72hAc25Q9AU3u0b2x/t65I2zLNgleJjT9NxREnSQf6g7E02+ZEmR25N5/DGL4hsn3rIj2G9Qdhboafiy/yHt0wOwWrZVWncLZcsCMsVgMLrP4DSENpjL0tV+KzVWPVhd3BgZgaX5It4PvKKrH/XnHfqyVf3jPpMh2bjuSuuSkcnW0hADKnT7c0F1Bob58wEYNx0r81KQQy80Rdu58ubXvcJqOSEfJsLWA3zXefI6hOy4VXtWtv207/0SLy4ItKqrDym3UtsXiXcsJ7AuJz6/zQRPQ4HOfH/OsrpDnCec1mNbQjprJmHaZheq85a/WhSkRnWt8xT1clpqM2jQe4Xcg8yxmRmDG1+ROyKAMfocjgoXo9HMTNN2ogztx4aXLiZrCsoehfwQCDRYiqDJobpw8w2VH1Q+IKsjuq2/mJ76fniF1n9NYlYeUHR+0H+0FU+TMeMP5FNshYAq4w+1DaoE48mhek5V9EvErZwm5Zs8mSd098g0+f7G8Gb6ydgefZ9LdivR7ZLGoFT1MjOZmHQRRpEE61XKIWMkN9pYco3FEnsK1hJ0qwj5DoUXWXrqYXXm8iGgL2zwB24nm97g8PeUmMN4tyLnARQzbmBp9hFkjq88wU8HrJ8hCMV0DkvAKicJ2PxP16NgaTxq1VyMW8jT2nD3cszMEi514kStERHYo19ahhBRzOsgpyW7Ni9bK/ff4ag2E+Wp4ql9Z01QKRCQ/AShD4vZWiajTWt4X7p1e5ENnxnEZUqIgjswYy0cT+L5pHyA+d75bBkVaCANUl6ZV1kTzdHZHQvw6KQT6YwVmQF3bmU5+lKNKSOlIhe1UwFx2HK+kNRf6HTXpEi7SSdaNDfrfI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(26005)(86362001)(336012)(2616005)(8676002)(47076005)(82310400004)(54906003)(2906002)(5660300002)(1076003)(70586007)(4326008)(7696005)(70206006)(426003)(36756003)(40460700001)(83380400001)(186003)(36860700001)(316002)(81166007)(508600001)(6916009)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 12:37:57.5366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1ddf3b3-a448-44fa-2468-08d9befe8ebd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2971 Content-Type: text/plain Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770) The PPTT parser in AcpiView incorrectly dereferences a pointer to FlagName when trying to log an error with the PPTT cache flags, which can lead to random crashes and other errors. Also fix some spacing in the error message to ensure the message is printed cleanly. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c index 8d52bb5e4811298ddc45cdaef41150f6ee7819af..53777644580e779adab4e8047ea279e1c0de14a3 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c @@ -40,9 +40,9 @@ LogCacheFlagError ( IncrementErrorCount (); Print ( L"\nERROR: On Arm based systems, all cache properties must be" - L"provided in the cache type structure." - L"Missing '%s' flag.", - *FlagName + L" provided in the cache type structure." + L" Missing '%s' flag.", + FlagName ); } -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")