From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web09.37384.1639551396764947405
 for <devel@edk2.groups.io>;
 Tue, 14 Dec 2021 22:56:37 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZPSagON2;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639551395;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wydCQ5MhmVjy8YTqrQp9OqDVuossLtm1YIUnRBkZqlA=;
	b=ZPSagON2d/Zg+bIqBLvYikkO1Yd0vPIMu1gnVUkiFGXhhP8lyvy9j2KyLDWpVr5ZXHo9OT
	3eqQ27nsJ0BJ7BXlrONjluQn6Ma5TKh7/7CTbPQCNtUint1HniptH7WbuNbK7XjwCf2lKV
	GZlquuQKwcHyWVfVruM+5ZjxNNzh5Mg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-127-_rCPsTsnOvqpaxiVLEVywQ-1; Wed, 15 Dec 2021 01:56:32 -0500
X-MC-Unique: _rCPsTsnOvqpaxiVLEVywQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF26564092;
	Wed, 15 Dec 2021 06:56:30 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 51638105B1E2;
	Wed, 15 Dec 2021 06:56:30 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 9BA87180039F; Wed, 15 Dec 2021 07:56:28 +0100 (CET)
Date: Wed, 15 Dec 2021 07:56:28 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V4 05/31] OvmfPkg: Extend VmgExitLib to handle #VE exception
Message-ID: <20211215065628.wq6ypjqztsmrnez3@sirius.home.kraxel.org>
References: <cover.1639399598.git.min.m.xu@intel.com>
 <3c7ec5880fd20cee067c52d838b348fb335dfc62.1639399598.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <3c7ec5880fd20cee067c52d838b348fb335dfc62.1639399598.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Mon, Dec 13, 2021 at 08:56:36PM +0800, Min Xu wrote:
> RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> 
> The base VmgExitLib library provides a default limited interface to
> handle #VE exception. To provide full support, the OVMF version of
> VmgExitLib is extended to provide full support of #VE handler.
> 
> PcdIgnoreVeHalt is created in OvmfPkg.dec to ignore the VE halt.

Why this is useful?

> +  X64/TdVmcallCpuid.nasm

Hmm, why not simply call the functions added by patch #2?

take care,
  Gerd