From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.37243.1639551733320190344
 for <devel@edk2.groups.io>;
 Tue, 14 Dec 2021 23:02:13 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X7ymXQ9q;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639551732;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=VZrHhKdewrYLe+ElLAWyaRwKAmfYQD71Wx7bSVzvCm0=;
	b=X7ymXQ9qO8IfQF8G3LmWulbE63ZHHpoGGFT7Ud2bizG3cgR4rRJAInks1gIJS/VgVKZnwZ
	fRnSJqhNzOBiKLfG64nK5+aJzGUvnu0EMWleLlYfn7x+LYmIlwp5k/HJknkjP5QN0DbeMW
	KgxewN6+MAoXTntUREJMrKxPdRxWzSA=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-250-UpkDR0stPBOP3cByKeYoGw-1; Wed, 15 Dec 2021 02:02:08 -0500
X-MC-Unique: UpkDR0stPBOP3cByKeYoGw-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D3F41808324;
	Wed, 15 Dec 2021 07:02:06 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FA9A70D32;
	Wed, 15 Dec 2021 07:02:06 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7F653180039F; Wed, 15 Dec 2021 08:02:04 +0100 (CET)
Date: Wed, 15 Dec 2021 08:02:04 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V4 08/31] MdePkg: Support mmio for Tdx guest in BaseIoLibIntrinsic
Message-ID: <20211215070204.earcqeprrmddmydy@sirius.home.kraxel.org>
References: <cover.1639399598.git.min.m.xu@intel.com>
 <aa4e7b10003419723f0a8f9ed3af03873605bf3e.1639399598.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <aa4e7b10003419723f0a8f9ed3af03873605bf3e.1639399598.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 13, 2021 at 08:56:39PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> 
> TDVF access MMIO with TDG.VP.VMCALL to invoke VMM provided emulation
> functions. If the access to MMIO fails, it fall backs to the direct
> access.
> 
> BaseIoLibIntrinsic.inf is the IoLib used by other packages. It will
> not support I/O in Td guest. But some files are shared between
> BaseIoLibIntrinsic and BaseIoLibIntrinsicSev (IoLib.c is the example). So
> IoLibInternalTdxNull.c (which holds the null stub of the Td I/O routines)
> is included in BaseIoLibIntrinsic.inf. BaseIoLibIntrinsic.inf doesn't
> import TdxLib so that the Pkgs which include BaseIoLibIntrinsic.inf
> need not include TdxLib.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd