From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web08.38256.1639559767950207456
 for <devel@edk2.groups.io>;
 Wed, 15 Dec 2021 01:16:08 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dP2TgDzx;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639559767;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BQxql2VZ1MfRru68hatTJQuGM3danSvtqfDZNr5e2FQ=;
	b=dP2TgDzx4ePnIFilG1we2yBtYqNsusjKq20ybpp52oSL7d45CeZnHHrryGTO4mNI7PjRtn
	Thlu3mTdzEhQLq/+7Nw364nlVJLN3xhMGkrokoE3V8LJUXfH48OAL80z5f5R5ML+r3l1Y7
	9dSzrn4HXKiUWX2KyRFJ9EytAFMmKt4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-434-eG-rehu2PRyjwv9ObRDEUg-1; Wed, 15 Dec 2021 04:16:03 -0500
X-MC-Unique: eG-rehu2PRyjwv9ObRDEUg-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C542760C0;
	Wed, 15 Dec 2021 09:16:02 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id CE5916E96B;
	Wed, 15 Dec 2021 09:16:01 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 1104C180039F; Wed, 15 Dec 2021 10:16:00 +0100 (CET)
Date: Wed, 15 Dec 2021 10:16:00 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library
Message-ID: <20211215091600.q63ltwlbliwjbm4q@sirius.home.kraxel.org>
References: <cover.1639399598.git.min.m.xu@intel.com>
 <fda3d7ba592915a48ba4dadf808709c4e408bef6.1639399598.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <fda3d7ba592915a48ba4dadf808709c4e408bef6.1639399598.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +++ b/OvmfPkg/Library/BaseMemEncryptTdxLib/BaseMemoryEncryptionNull.c
> @@ -0,0 +1,90 @@
> +/** @file
> +
> +  Virtual Memory Management Services to set or clear the memory encryption
> +
> +  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
> +
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +  Code is derived from MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c

Can we move most of the code to a (x64) page table library instead of
cut+pasting like this, please?

Brijesh: BaseMemEncryptSevLib is in the same boat.

take care,
  Gerd