From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.38125.1639560393343495947
 for <devel@edk2.groups.io>;
 Wed, 15 Dec 2021 01:26:33 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PtILnLFg;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639560392;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CxA22SqdnuGDYDNLSsFJQ6pJMd2dNFmrYc90mmfEmhA=;
	b=PtILnLFghjEHuc0YEmsvfAsKJbk+HQJ+dwGEUriYI4dbr1gXKCmKNvXWJaoDsnUj3WnUAc
	llTuFe/tEWAb0v3I3VbnkyE+CR8QMmL8BTiSFauI65m/7HYw5vbU+z3mySkpPJ/9huAnMo
	COzLjOnqtZXevHhcb3DzIrZlrXcPh+I=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-83-hLSv7t8uO8iGaG8CTER-2g-1; Wed, 15 Dec 2021 04:26:29 -0500
X-MC-Unique: hLSv7t8uO8iGaG8CTER-2g-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDB1E1023F59;
	Wed, 15 Dec 2021 09:26:26 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 8086574EB5;
	Wed, 15 Dec 2021 09:26:26 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id EC600180039F; Wed, 15 Dec 2021 10:26:24 +0100 (CET)
Date: Wed, 15 Dec 2021 10:26:24 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Julien Grall <julien@xen.org>, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>
Subject: Re: [PATCH V4 31/31] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg
Message-ID: <20211215092624.ezdeswmn2gmn5fcc@sirius.home.kraxel.org>
References: <cover.1639399598.git.min.m.xu@intel.com>
 <ebc61f98a2b7104524e0acbd9c46ba882065c41b.1639399598.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <ebc61f98a2b7104524e0acbd9c46ba882065c41b.1639399598.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 13, 2021 at 08:57:02PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
> 
> OvmfPkg.dec is removed from [Packages] because it doesn't depend
> on OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg.

>    if (mTimerNotifyFunction != NULL) {
> -    //
> -    // @bug : This does not handle missed timer interrupts
> -    //
>      mTimerNotifyFunction (mTimerPeriod);
>    }

>    if (TimerPeriod == 0) {
> +    //
> +    // Stop the timer
> +    //
> +    InitializeApicTimer (0, 0, FALSE, LOCAL_APIC_TIMER_VECTOR);
> +

This is more than a pure move.
Functional changes should be a separate patch.

>  TimerDriverGetTimerPeriod (
> -  IN EFI_TIMER_ARCH_PROTOCOL *This,
> -  OUT UINT64                 *TimerPeriod
> +  IN EFI_TIMER_ARCH_PROTOCOL  *This,
> +  OUT UINT64                  *TimerPeriod

What's this?  uncrustify?
Reformating should be a separate patch too.

take care,
  Gerd