From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.38510.1639561743683579065
 for <devel@edk2.groups.io>;
 Wed, 15 Dec 2021 01:49:03 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Fa6quIOf;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639561742;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7OCDsxr+sBniazddIGRwyQnaz8hJdJFFZxAXzMYPIZ0=;
	b=Fa6quIOfNDZuWkAMvqzN8sq39sWjQUkVRCb80tabJPUwKkPd8C79BMpYMlrpEYMLUwRSo2
	by9x3lz1O7WR4XUJIF5/wGN0SO09RgAgGGl88A35wXPDnAM80Om20doFPlxaTqZfB699uT
	Omoc4joRWan0/TRquCNvTQoBFbtLmHo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-428-r6-WJpbeN7OG-3P2bw2UkQ-1; Wed, 15 Dec 2021 04:48:52 -0500
X-MC-Unique: r6-WJpbeN7OG-3P2bw2UkQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 31444190B2A1;
	Wed, 15 Dec 2021 09:48:51 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id D2BC55E65C;
	Wed, 15 Dec 2021 09:48:50 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 23FFB180039F; Wed, 15 Dec 2021 10:48:49 +0100 (CET)
Date: Wed, 15 Dec 2021 10:48:49 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 05/10] OvmfPkg: Add SecPlatformLibQemuTdx
Message-ID: <20211215094849.4f4vj64akrvrqj77@sirius.home.kraxel.org>
References: <20211214134126.869-1-min.m.xu@intel.com>
 <20211214134126.869-6-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20211214134126.869-6-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +#define FW_CFG_NX_STACK_ITEM        "opt/ovmf/PcdSetNxForStack"

Why this is needed?

> +//
> +// Values we program into the PM base address registers
> +//
> +#define PIIX4_PMBA_VALUE   0xB000
> +#define ICH9_PMBASE_VALUE  0x0600

They are in OvmfPkg/Include/OvmfPlatforms.h, no need to copy them over.

> +VOID
> +PciExBarInitialization (

> +VOID
> +MiscInitialization (

Cut+Paste from PlatformPei

Please refactor the code (move the functions needed to a Library?) so we
don't have multiple copies of the setup code.

take care,
  Gerd