From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web08.38679.1639562994092176166
 for <devel@edk2.groups.io>;
 Wed, 15 Dec 2021 02:09:54 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YqXjFjko;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639562993;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0N4bESvlE8pEQBnmR4/xvZRoU8/wG8HCv7GQvgU0VkY=;
	b=YqXjFjkocghiZ9zGhbpgKpU7YURW1aETA5660zAbjz0hdLXrlIIyziTHvt3k1gNy+ZqTtj
	o6ksE85G3ltnanHwTX4bCXoredlC+v0aL93qqaeWd6oVL8AvDOtYkBvR0j2/FT4vCHiAgE
	Cws2lfIB2qV5tzapHwfYTZ58PCZvKW4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-511-YkmKJvmIOGKd6RgQ_gp8Rw-1; Wed, 15 Dec 2021 05:09:47 -0500
X-MC-Unique: YkmKJvmIOGKd6RgQ_gp8Rw-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 757E78CC6DF;
	Wed, 15 Dec 2021 10:09:17 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C1FB9651E;
	Wed, 15 Dec 2021 10:09:16 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 40C69180039F; Wed, 15 Dec 2021 11:09:14 +0100 (CET)
Date: Wed, 15 Dec 2021 11:09:14 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 06/10] OvmfPkg: Add TdxStartupLib
Message-ID: <20211215100914.4vq24pkjrhmqjdg4@sirius.home.kraxel.org>
References: <20211214134126.869-1-min.m.xu@intel.com>
 <20211214134126.869-7-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20211214134126.869-7-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +  PageTables = 0;
> +  if (FeaturePcdGet (PcdDxeIplBuildPageTables)) {

Can this ever be false in a x64 build?

> +EFI_STATUS
> +FindDxeCore (
> +  IN INTN                         FvInstance,
> +  IN OUT     EFI_PEI_FILE_HANDLE  *FileHandle
> +  )
> +{

> +  if (FvInstance != -1) {
> +    //
> +    // Caller passed in a specific FV to try, so only try that one
> +    //
[ ... ]
> +  } else {
> +    // Assume the FV that contains the SEC (our code) also contains a compressed FV.

This branch never runs, FvInstance is explicity set to 1 by the caller.

> +++ b/OvmfPkg/IntelTdx/TdxStartupLib/X64/PageTables.h

There is OvmfPkg/Include/IndustryStandard/PageTable.h

> +VOID
> +Split2MPageTo4K (

Yet another copy of this.  Please don't.

take care,
  Gerd