From: "Rebecca Cran" <rebecca@nuviainc.com>
To: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>
Cc: Rebecca Cran <rebecca@nuviainc.com>
Subject: [PATCH v3 0/4] ArmPkg,ArmVirtPkg: Add support EFI_MP_SERVICES_PROTOCOL on AARCH64
Date: Wed, 15 Dec 2021 20:46:30 -0700 [thread overview]
Message-ID: <20211216034634.15468-1-rebecca@nuviainc.com> (raw)
Patch 1/4 is the start of addressing the issue that the Aff0 field of
the MPIDR is no longer guaranteed to be the core, and should be referred
to in a more generic way: for example it could be the thread, with Aff1
being the core and Aff2 the cluster. Clearly much more work is needed
to fully remove that assumption.
Patch 2/4 implements the EFI_MP_SERVICES_PROTOCOL for DXE in Library/MpInitLib.
Patch 4/4 updates CpuDxe to initialize MP support: as a result, it gains
a dependency on MpInitLib.
Patch 3/4 updates ArmVirt.dsc.inc to add the new MpInitLib library.
Cores are powered on and turned off using PSCI.
Note that minimal CPU setup is done: for example the MMU and caches are
left disabled.
--------
Changes from v2:
o Split patches up.
o Wrapped overly long lines.
o Fixed code formatting issues (Uncrustify).
o Fixed other formatting issues (ECC tool).
--------
Testing:
o Ran CI: https://github.com/tianocore/edk2/pull/2312
o Built packages in ArmVirtPkg at each revision for both ARM and AARCH64.
Rebecca Cran (4):
ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO
struct
ArmPkg: Add Library/MpInitLib to support EFI_MP_SERVICES_PROTOCOL
ArmVirtPkg: Add MpInitLib, which is dependency for CpuDxe consumers
ArmPkg: Update Drivers/CpuDxe to initialize MpInitLib
ArmPkg/ArmPkg.dec | 4 +
ArmPkg/ArmPkg.dsc | 4 +
ArmPkg/Drivers/CpuDxe/AArch64/Arch.c | 21 +
ArmPkg/Drivers/CpuDxe/Arm/Arch.c | 21 +
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +
ArmPkg/Drivers/CpuDxe/CpuDxe.h | 10 +
ArmPkg/Drivers/CpuDxe/CpuDxe.inf | 6 +
ArmPkg/Drivers/CpuDxe/CpuMpInit.c | 608 ++++++++
ArmPkg/Include/Guid/ArmMpCoreInfo.h | 3 +-
ArmPkg/Include/Library/ArmLib.h | 4 +
ArmPkg/Include/Library/MpInitLib.h | 362 +++++
ArmPkg/Library/MpInitLib/AArch64/MpFuncs.S | 65 +
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf | 52 +
ArmPkg/Library/MpInitLib/DxeMpLib.c | 1477 ++++++++++++++++++++
ArmPkg/Library/MpInitLib/InternalMpInitLib.h | 357 +++++
ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c | 8 +-
ArmPlatformPkg/PrePeiCore/MainMPCore.c | 4 +-
ArmPlatformPkg/PrePi/MainMPCore.c | 4 +-
ArmVirtPkg/ArmVirt.dsc.inc | 3 +
19 files changed, 3007 insertions(+), 8 deletions(-)
create mode 100644 ArmPkg/Drivers/CpuDxe/AArch64/Arch.c
create mode 100644 ArmPkg/Drivers/CpuDxe/Arm/Arch.c
create mode 100644 ArmPkg/Drivers/CpuDxe/CpuMpInit.c
create mode 100644 ArmPkg/Include/Library/MpInitLib.h
create mode 100644 ArmPkg/Library/MpInitLib/AArch64/MpFuncs.S
create mode 100644 ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
create mode 100644 ArmPkg/Library/MpInitLib/DxeMpLib.c
create mode 100644 ArmPkg/Library/MpInitLib/InternalMpInitLib.h
--
2.31.1
next reply other threads:[~2021-12-16 3:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 3:46 Rebecca Cran [this message]
2021-12-16 3:46 ` [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct Rebecca Cran
2022-01-30 10:44 ` Ard Biesheuvel
2022-01-30 23:22 ` Ard Biesheuvel
2022-01-31 11:42 ` Ard Biesheuvel
2022-02-04 19:13 ` Rebecca Cran
2021-12-16 3:46 ` [PATCH v3 2/4] ArmPkg: Add Library/MpInitLib to support EFI_MP_SERVICES_PROTOCOL Rebecca Cran
2021-12-16 3:46 ` [PATCH v3 3/4] ArmVirtPkg: Add MpInitLib, which is dependency for CpuDxe consumers Rebecca Cran
2021-12-16 3:46 ` [PATCH v3 4/4] ArmPkg: Update Drivers/CpuDxe to initialize MpInitLib Rebecca Cran
2021-12-17 18:08 ` [PATCH v3 0/4] ArmPkg,ArmVirtPkg: Add support EFI_MP_SERVICES_PROTOCOL on AARCH64 Ard Biesheuvel
2021-12-17 18:40 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216034634.15468-1-rebecca@nuviainc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox