public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: "Pawel Polawski" <ppolawsk@redhat.com>,
	"Liming Gao" <gaoliming@byosoft.com.cn>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Jiewen Yao" <jiewen.yao@intel.com>,
	"Abner Chang" <abner.chang@hpe.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
	"Ray Ni" <ray.ni@intel.com>, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Hao A Wu" <hao.a.wu@intel.com>,
	"Jian J Wang" <jian.j.wang@intel.com>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Leif Lindholm" <leif@nuviainc.com>
Subject: [PATCH 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak
Date: Thu, 16 Dec 2021 10:50:36 +0100	[thread overview]
Message-ID: <20211216095037.1843149-6-kraxel@redhat.com> (raw)
In-Reply-To: <20211216095037.1843149-1-kraxel@redhat.com>

microvm places the 64bit mmio space at the end of the physical address
space.  So mPhysMemAddressWidth must be correct, otherwise the pci host
bridge setup throws an error because it thinks the 64bit mmio window is
not addressable.

On microvm we can simply use standard cpuid to figure the address width
because the host-phys-bits option (-cpu ${name},host-phys-bits=on) is
forced to be enabled.  Side note: For 'pc' and 'q35' this is not the
case for backward compatibility reasons.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 OvmfPkg/PlatformPei/MemDetect.c | 21 +++++++++++++++++++++
 OvmfPkg/PlatformPei/Platform.c  |  2 +-
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
index 81378eaf9b4c..ba8f2d4b3269 100644
--- a/OvmfPkg/PlatformPei/MemDetect.c
+++ b/OvmfPkg/PlatformPei/MemDetect.c
@@ -508,6 +508,27 @@ AddressWidthInitialization (
 {
   UINT64  FirstNonAddress;
 
+  if (mHostBridgeDevId == 0xffff /* microvm */) {
+    UINT32  RegEax;
+
+    /* NOTE: microvm phys-bits are reliable. */
+    AsmCpuid (0x80000000, &RegEax, NULL, NULL, NULL);
+    if (RegEax >= 0x80000008) {
+      AsmCpuid (0x80000008, &RegEax, NULL, NULL, NULL);
+      mPhysMemAddressWidth = (UINT8)RegEax;
+    } else {
+      mPhysMemAddressWidth = 36;
+    }
+
+    DEBUG ((
+      DEBUG_INFO,
+      "%a: microvm: phys-bits is %d\n",
+      __FUNCTION__,
+      mPhysMemAddressWidth
+      ));
+    return;
+  }
+
   //
   // As guest-physical memory size grows, the permanent PEI RAM requirements
   // are dominated by the identity-mapping page tables built by the DXE IPL.
diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c
index 27ada0c17577..b8cc0c31dd64 100644
--- a/OvmfPkg/PlatformPei/Platform.c
+++ b/OvmfPkg/PlatformPei/Platform.c
@@ -821,12 +821,12 @@ InitializePlatform (
 
   S3Verification ();
   BootModeInitialization ();
-  AddressWidthInitialization ();
 
   //
   // Query Host Bridge DID
   //
   mHostBridgeDevId = PciRead16 (OVMF_HOSTBRIDGE_DID);
+  AddressWidthInitialization ();
 
   MaxCpuCountInitialization ();
 
-- 
2.33.1


  parent reply	other threads:[~2021-12-16  9:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16  9:50 [PATCH 0/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2021-12-16  9:50 ` [PATCH 1/6] PciHostBridge: io range is not mandatory Gerd Hoffmann
2021-12-16  9:53   ` [edk2-devel] " Ard Biesheuvel
2021-12-16  9:50 ` [PATCH 2/6] FdtPciHostBridgeLib: " Gerd Hoffmann
2021-12-16  9:50 ` [PATCH 3/6] OvmfPkg/PlatformPei: unfix PcdPciExpressBaseAddress Gerd Hoffmann
2021-12-16 12:50   ` [edk2-devel] " Ard Biesheuvel
2021-12-17  6:33     ` Gerd Hoffmann
2021-12-16  9:50 ` [PATCH 4/6] OvmfPkg/Microvm/pcie: no vbeshim please Gerd Hoffmann
2021-12-16  9:50 ` Gerd Hoffmann [this message]
2021-12-16  9:50 ` [PATCH 6/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211216095037.1843149-6-kraxel@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox