From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.8839.1639649112153315521 for ; Thu, 16 Dec 2021 02:05:13 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: fanjianfeng@byosoft.com.cn) Received: from DESKTOP-M5NI163 ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 16 Dec 2021 18:04:57 +0800 X-WM-Sender: fanjianfeng@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: fanjianfeng@byosoft.com.cn Date: Thu, 16 Dec 2021 18:05:02 +0800 From: "Jeff Fan" To: "devel@edk2.groups.io" , masahisa.kojima , "Ard Biesheuvel" Cc: "Ming Huang" , "Masami Hiramatsu" , "devel@edk2.groups.io" , "Sami Mujawar" , "Ard Biesheuvel" , "Jiewen Yao" , "Supreeth Venkatesh" , ming.huang- Subject: Re: [edk2-devel] [PATCH edk2 v1 1/3] StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field References: <20211015090623.52511-1-huangming@linux.alibaba.com>, <20211015090623.52511-2-huangming@linux.alibaba.com>, , X-Priority: 3 X-Has-Attach: no X-Mailer: Foxmail 7.2.20.269[cn] Mime-Version: 1.0 Message-ID: <202112161805025836072@byosoft.com.cn> Content-Type: multipart/alternative; boundary="----=_001_NextPart784364182155_=----" ------=_001_NextPart784364182155_=---- Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 WW91IG1heSB0cnkgdG8gZW5sYXJnZXIgc3RtbV9uc19jb21tX2J1Zl9zaXplIGluIE9wdGVlIHRv IGNoZWNrIGlmIGl0IGNvdWxkIHNvbHZlIEFTU0VSVCBpc3N1ZS4NCg0KDQoNCmZhbmppYW5mZW5n QGJ5b3NvZnQuY29tLmNuDQogDQpGcm9tOiBNYXNhaGlzYSBLb2ppbWENCkRhdGU6IDIwMjEtMTIt MTYgMTY6MDcNClRvOiBBcmQgQmllc2hldXZlbA0KQ0M6IE1pbmcgSHVhbmc7IE1hc2FtaSBIaXJh bWF0c3U7IGVkazItZGV2ZWwtZ3JvdXBzLWlvOyBTYW1pIE11amF3YXI7IEFyZCBCaWVzaGV1dmVs OyBKaWV3ZW4gWWFvOyBTdXByZWV0aCBWZW5rYXRlc2g7IG1pbmcuaHVhbmctDQpTdWJqZWN0OiBS ZTogW2VkazItZGV2ZWxdIFtQQVRDSCBlZGsyIHYxIDEvM10gU3RhbmRhbG9uZU1tUGtnOiBGaXgg aXNzdWUgYWJvdXQgU3BQY3B1U2hhcmVkQnVmU2l6ZSBmaWVsZA0KSGkgQXJkLA0KIA0KT24gV2Vk LCAxNSBEZWMgMjAyMSBhdCAxNzo0NSwgQXJkIEJpZXNoZXV2ZWwgPGFyZGJAa2VybmVsLm9yZz4g d3JvdGU6DQo+DQo+ICgrIE1hc2FoaXNhLCBNYXNhbWkpDQo+DQo+DQo+IE9uIEZyaSwgMTUgT2N0 IDIwMjEgYXQgMTE6MDcsIE1pbmcgSHVhbmcgPGh1YW5nbWluZ0BsaW51eC5hbGliYWJhLmNvbT4g d3JvdGU6DQo+ID4NCj4gPiBURi1BOiBUcnVzdGVkRmlybXdhcmUtQQ0KPiA+IFNQTTogU2VjdXJl IFBhcnRpdGlvbiBNYW5hZ2VyKE1NKQ0KPiA+DQo+ID4gSW4gVEYtQSwgdGhlIG5hbWUgb2YgdGhp cyBmaWVsZCBpcyBzcF9zaGFyZWRfYnVmX3NpemUuIFRoaXMgZmllbGQgaXMNCj4gPiB0aGUgc2l6 ZSBvZiByYW5nZSBmb3IgdHJhbnNtaXQgZGF0YSBmcm9tIFRGLUEgdG8gc3RhbmRhbG9uZU1NIHdo ZW4NCj4gPiBTUE0gZW5hYmxlLg0KPiA+DQo+ID4gU3BQY3B1U2hhcmVkQnVmU2l6ZSBpcyBwYXNz IGZyb20gVEYtQSB3aGlsZSBTdGFuZGFsb25lTU0gaW5pdGlhbGl6ZS4NCj4gPiBTbywgU3BQY3B1 U2hhcmVkQnVmU2l6ZSBzaG91bGQgYmUgcmVuYW1lIHRvIFNwU2hhcmVkQnVmU2l6ZSBhbmQgdGhp cyBmaWVsZA0KPiA+IHNob3VsZCBubyBtdWx0aXBseSBieSBQYXlsb2FkQm9vdEluZm8tPk51bUNw dXM7DQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBNaW5nIEh1YW5nIDxodWFuZ21pbmdAbGludXgu YWxpYmFiYS5jb20+DQo+DQo+IENvdWxkIHNvbWVvbmUgcGxlYXNlIGNoZWNrIGhvdyB0aGlzIGNo YW5nZSBvZiBpbnRlcnByZXRhdGlvbiBhZmZlY3RzDQo+IHN0YW5kYWxvbmUgTU0gcnVubmluZyBv biBTeW5RdWFjZXI/DQogDQpJbiBjb25jbHVzaW9uLCB0aGlzIHBhdGNoIGRvZXMgbm90IGFmZmVj dCB0aGUgc3RhbmRhbG9uZSBNTSBpbXBsZW1lbnRhdGlvbg0Kb24gU3luUXVhY2VyLg0KIA0KSW4g bXkgY2hlY2ssIHRoaXMgYnVmZmVyIGlzIHVzZWQgZm9yIGRhdGEgc2hhcmluZyBiZXR3ZWVuIEVM MyBhbmQgU2VjdXJlLUVMMS8wLg0KQ3VycmVudGx5IHRoaXMgYnVmZmVyIGlzIG9ubHkgdXNlZCB0 byBwYXNzIHRoZSBzdHJ1Y3Qgc3BtX21tX2Jvb3RfaW5mb190DQpmcm9tIEVMMyB0byBTdE1NIGR1 cmluZyBTdG1tIGluaXRpYWxpemF0aW9uLCBJIGNvdWxkIG5vdCBmaW5kIG90aGVyIHVzZSBjYXNl cy4NCiANClRGLUEgbWFwcyB0aGUgYnVmZmVyIG9ubHkgNjRLQiwgbm90IG11bHRpcGxpZWQgYnkg dGhlIG51bWJlciBvZiBjb3Jlcy4NCmh0dHBzOi8vZ2l0LnRydXN0ZWRmaXJtd2FyZS5vcmcvVEYt QS90cnVzdGVkLWZpcm13YXJlLWEuZ2l0L3RyZWUvcGxhdC9zb2Npb25leHQvc3lucXVhY2VyL2lu Y2x1ZGUvcGxhdGZvcm1fZGVmLmgjbjk4DQpTbyB0aGUgZm9sbG93aW5nIGRlZmluaXRpb24gaXMg c29tZXRoaW5nIHN0cmFuZ2UgYW5kIGxlYWRzIHRvDQptaXN1bmRlcnN0YW5kaW5nLCBidXQgdGhl cmUgaXMgbm8gcHJvYmxlbS4NCiAgICNkZWZpbmUgUExBVF9TUE1fQlVGX0JBU0UgKEJMMzJfTElN SVQgLSAzMiAqIFBMQVRfU1BNX0JVRl9TSVpFKQ0KQXJtIHBsYXRmb3JtIHN0YXRpY2FsbHkgYWxs b2NhdGVzIDFNQiBidWZmZXIgaW4gVEYtQSwNCnNvIEkgdGhpbmsgaXQgaXMgYmV0dGVyIHRvIGZv bGxvdyB0aGUgYXJtIHBsYXRmb3JtIGRlZmluaXRpb24uDQogDQogDQpUaGlzIGlzIGRpZmZlcmVu dCB0b3BpYywgYnV0IGFzc2VydGlvbiBvY2N1cnMgaW4gREVCVUcgYnVpbGQgaWYgU3RNTQ0KYW5k IFNFQ1VSRV9CT09UX0VOQUJMRUQ9VFJVRS4NCiANCj09PQ0KTG9hZGluZyBkcml2ZXIgYXQgMHgw MDBGQUJCMDAwMCBFbnRyeVBvaW50PTB4MDAwRkFCQzQ0N0MgQ2Fwc3VsZVJ1bnRpbWVEeGUuZWZp DQphZGQtc3ltYm9sLWZpbGUNCi9ob21lL3VidW50dS9zcmMvc2JzYS1xZW11L0J1aWxkL0RldmVs b3BlckJveC9ERUJVR19HQ0M1L0FBUkNINjQvU2VjdXJpdHlQa2cvVmFyaWFibGVBdXRoZW50aWNh dGVkL1NlY3VyZUJvb3RDb25maWdEeGUvU2VjdXJlQm9vdENvbmZpZ0R4ZS9ERUJVRy9TZWN1cmVC b290Q29uZmlnRHhlLmRsbA0KMHhGQTZCQTAwMA0KTG9hZGluZyBkcml2ZXIgYXQgMHgwMDBGQTZC OTAwMCBFbnRyeVBvaW50PTB4MDAwRkE2Qzk2MTAgU2VjdXJlQm9vdENvbmZpZ0R4ZS5lZmkNCmFk ZC1zeW1ib2wtZmlsZQ0KL2hvbWUvdWJ1bnR1L3NyYy9zYnNhLXFlbXUvQnVpbGQvRGV2ZWxvcGVy Qm94L0RFQlVHX0dDQzUvQUFSQ0g2NC9NZGVNb2R1bGVQa2cvVW5pdmVyc2FsL0Jkc0R4ZS9CZHNE eGUvREVCVUcvQmRzRHhlLmRsbA0KMHhGQTY5RDAwMA0KTG9hZGluZyBkcml2ZXIgYXQgMHgwMDBG QTY5QzAwMCBFbnRyeVBvaW50PTB4MDAwRkE2QTdFOTggQmRzRHhlLmVmaQ0KRHhlQ2Fwc3VsZUxp YkZtcDogRmFpbGVkIHRvIGxvY2sgdmFyaWFibGUNCjM5QjY4QzQ2LUY3RkItNDQxQi1CNkVDLTE2 QjBGNjk4MjFGMyBDYXBzdWxlTWF4LiAgU3RhdHVzID0gSW52YWxpZA0KUGFyYW1ldGVyDQogDQpB U1NFUlRfRUZJX0VSUk9SIChTdGF0dXMgPSBJbnZhbGlkIFBhcmFtZXRlcikNCkFTU0VSVCBbQmRz RHhlXQ0KL2hvbWUvdWJ1bnR1L3NyYy9zYnNhLXFlbXUvZWRrMi9NZGVNb2R1bGVQa2cvTGlicmFy eS9EeGVDYXBzdWxlTGliRm1wL0R4ZUNhcHN1bGVSZXBvcnRMaWIuYygxMzMpOg0KISgoKElOVE4p KFJFVFVSTl9TVEFUVVMpKFN0YXR1cykpIDwgMCkNCj09PQ0KIA0KUHJvYmFibHkgaXQgaXMgZHVl IHRvIHRoZSBtaXNzaW5nIHN1cHBvcnQgb2YgVmFyaWFibGVQb2xpY3ksIFN0TU0NCm91dHB1dHMg dGhlIGZvbGxvd2luZyBsb2cgb3V0cHV0Lg0KPT09DQpDb21tQnVmZmVyIC0gMHhGQzg1Q0M5MCwg Q29tbUJ1ZmZlclNpemUgLSAweDUyDQohISEgREVQUkVDQVRFRCBJTlRFUkZBQ0UgISEhIFZhcmlh YmxlTG9ja1JlcXVlc3RUb0xvY2soKSB3aWxsIGdvIGF3YXkgc29vbiENCiEhISBERVBSRUNBVEVE IElOVEVSRkFDRSAhISEgUGxlYXNlIG1vdmUgdG8gdXNlIFZhcmlhYmxlIFBvbGljeSENCiEhISBE RVBSRUNBVEVEIElOVEVSRkFDRSAhISEgVmFyaWFibGU6DQo4QkU0REY2MS05M0NBLTExRDItQUEw RC0wMEUwOTgwMzJCOEMgUGxhdGZvcm1SZWNvdmVyeTAwMDANCj09PQ0KIA0KVGhhdCdzIGFsbCBm b3Igbm93Lg0KIA0KVGhhbmtzLA0KTWFzYWhpc2EgS29qaW1hDQogDQo+DQo+DQo+ID4gLS0tDQo+ ID4gIFN0YW5kYWxvbmVNbVBrZy9JbmNsdWRlL0xpYnJhcnkvQXJtL1N0YW5kYWxvbmVNbUNvcmVF bnRyeVBvaW50LmggICAgICAgICAgICAgICAgICAgIHwgMiArLQ0KPiA+ICBTdGFuZGFsb25lTW1Q a2cvTGlicmFyeS9TdGFuZGFsb25lTW1Db3JlRW50cnlQb2ludC9Bcm0vQ3JlYXRlSG9iTGlzdC5j ICAgICAgICAgICAgICB8IDIgKy0NCj4gPiAgU3RhbmRhbG9uZU1tUGtnL0xpYnJhcnkvU3RhbmRh bG9uZU1tQ29yZUVudHJ5UG9pbnQvQXJtL1N0YW5kYWxvbmVNbUNvcmVFbnRyeVBvaW50LmMgfCAy ICstDQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL1N0YW5kYWxvbmVNbVBrZy9JbmNsdWRlL0xpYnJhcnkv QXJtL1N0YW5kYWxvbmVNbUNvcmVFbnRyeVBvaW50LmggYi9TdGFuZGFsb25lTW1Qa2cvSW5jbHVk ZS9MaWJyYXJ5L0FybS9TdGFuZGFsb25lTW1Db3JlRW50cnlQb2ludC5oDQo+ID4gaW5kZXggYzQ0 ZjcwNjZjNi4uZjE2ODNlY2I2MSAxMDA2NDQNCj4gPiAtLS0gYS9TdGFuZGFsb25lTW1Qa2cvSW5j bHVkZS9MaWJyYXJ5L0FybS9TdGFuZGFsb25lTW1Db3JlRW50cnlQb2ludC5oDQo+ID4gKysrIGIv U3RhbmRhbG9uZU1tUGtnL0luY2x1ZGUvTGlicmFyeS9Bcm0vU3RhbmRhbG9uZU1tQ29yZUVudHJ5 UG9pbnQuaA0KPiA+IEBAIC00MSw3ICs0MSw3IEBAIHR5cGVkZWYgc3RydWN0IHsNCj4gPiAgICBV SU5UNjQgICAgICAgICAgICAgICAgICAgICAgICBTcFBjcHVTdGFja1NpemU7DQo+ID4gICAgVUlO VDY0ICAgICAgICAgICAgICAgICAgICAgICAgU3BIZWFwU2l6ZTsNCj4gPiAgICBVSU5UNjQgICAg ICAgICAgICAgICAgICAgICAgICBTcE5zQ29tbUJ1ZlNpemU7DQo+ID4gLSAgVUlOVDY0ICAgICAg ICAgICAgICAgICAgICAgICAgU3BQY3B1U2hhcmVkQnVmU2l6ZTsNCj4gPiArICBVSU5UNjQgICAg ICAgICAgICAgICAgICAgICAgICBTcFNoYXJlZEJ1ZlNpemU7DQo+ID4gICAgVUlOVDMyICAgICAg ICAgICAgICAgICAgICAgICAgTnVtU3BNZW1SZWdpb25zOw0KPiA+ICAgIFVJTlQzMiAgICAgICAg ICAgICAgICAgICAgICAgIE51bUNwdXM7DQo+ID4gICAgRUZJX1NFQ1VSRV9QQVJUSVRJT05fQ1BV X0lORk8gKkNwdUluZm87DQo+ID4gZGlmZiAtLWdpdCBhL1N0YW5kYWxvbmVNbVBrZy9MaWJyYXJ5 L1N0YW5kYWxvbmVNbUNvcmVFbnRyeVBvaW50L0FybS9DcmVhdGVIb2JMaXN0LmMgYi9TdGFuZGFs b25lTW1Qa2cvTGlicmFyeS9TdGFuZGFsb25lTW1Db3JlRW50cnlQb2ludC9Bcm0vQ3JlYXRlSG9i TGlzdC5jDQo+ID4gaW5kZXggODVmODE5NDY4Ny4uOTM3NzNjOWZlOCAxMDA2NDQNCj4gPiAtLS0g YS9TdGFuZGFsb25lTW1Qa2cvTGlicmFyeS9TdGFuZGFsb25lTW1Db3JlRW50cnlQb2ludC9Bcm0v Q3JlYXRlSG9iTGlzdC5jDQo+ID4gKysrIGIvU3RhbmRhbG9uZU1tUGtnL0xpYnJhcnkvU3RhbmRh bG9uZU1tQ29yZUVudHJ5UG9pbnQvQXJtL0NyZWF0ZUhvYkxpc3QuYw0KPiA+IEBAIC0xNzMsNyAr MTczLDcgQEAgQ3JlYXRlSG9iTGlzdEZyb21Cb290SW5mbyAoDQo+ID4gICAgLy8gQmFzZSBhbmQg c2l6ZSBvZiBidWZmZXIgc2hhcmVkIHdpdGggcHJpdmlsZWdlZCBTZWN1cmUgd29ybGQgc29mdHdh cmUNCj4gPiAgICBNbXJhbVJhbmdlc1sxXS5QaHlzaWNhbFN0YXJ0ID0gUGF5bG9hZEJvb3RJbmZv LT5TcFNoYXJlZEJ1ZkJhc2U7DQo+ID4gICAgTW1yYW1SYW5nZXNbMV0uQ3B1U3RhcnQgICAgICA9 IFBheWxvYWRCb290SW5mby0+U3BTaGFyZWRCdWZCYXNlOw0KPiA+IC0gIE1tcmFtUmFuZ2VzWzFd LlBoeXNpY2FsU2l6ZSAgPSBQYXlsb2FkQm9vdEluZm8tPlNwUGNwdVNoYXJlZEJ1ZlNpemUgKiBQ YXlsb2FkQm9vdEluZm8tPk51bUNwdXM7DQo+ID4gKyAgTW1yYW1SYW5nZXNbMV0uUGh5c2ljYWxT aXplICA9IFBheWxvYWRCb290SW5mby0+U3BTaGFyZWRCdWZTaXplOw0KPiA+ICAgIE1tcmFtUmFu Z2VzWzFdLlJlZ2lvblN0YXRlICAgPSBFRklfQ0FDSEVBQkxFIHwgRUZJX0FMTE9DQVRFRDsNCj4g Pg0KPiA+ICAgIC8vIEJhc2UgYW5kIHNpemUgb2YgYnVmZmVyIHVzZWQgZm9yIHN5bmNocm9ub3Vz IGNvbW11bmljYXRpb24gd2l0aCBOb3JtYWwNCj4gPiBkaWZmIC0tZ2l0IGEvU3RhbmRhbG9uZU1t UGtnL0xpYnJhcnkvU3RhbmRhbG9uZU1tQ29yZUVudHJ5UG9pbnQvQXJtL1N0YW5kYWxvbmVNbUNv cmVFbnRyeVBvaW50LmMgYi9TdGFuZGFsb25lTW1Qa2cvTGlicmFyeS9TdGFuZGFsb25lTW1Db3Jl RW50cnlQb2ludC9Bcm0vU3RhbmRhbG9uZU1tQ29yZUVudHJ5UG9pbnQuYw0KPiA+IGluZGV4IDQ5 Y2Y1MWE3ODkuLjVkYjcwMTlkZGEgMTAwNjQ0DQo+ID4gLS0tIGEvU3RhbmRhbG9uZU1tUGtnL0xp YnJhcnkvU3RhbmRhbG9uZU1tQ29yZUVudHJ5UG9pbnQvQXJtL1N0YW5kYWxvbmVNbUNvcmVFbnRy eVBvaW50LmMNCj4gPiArKysgYi9TdGFuZGFsb25lTW1Qa2cvTGlicmFyeS9TdGFuZGFsb25lTW1D b3JlRW50cnlQb2ludC9Bcm0vU3RhbmRhbG9uZU1tQ29yZUVudHJ5UG9pbnQuYw0KPiA+IEBAIC04 Nyw3ICs4Nyw3IEBAIEdldEFuZFByaW50Qm9vdGluZm9ybWF0aW9uICgNCj4gPiAgICBERUJVRyAo KERFQlVHX0lORk8sICJTcFBjcHVTdGFja1NpemUgLSAweCV4XG4iLCBQYXlsb2FkQm9vdEluZm8t PlNwUGNwdVN0YWNrU2l6ZSkpOw0KPiA+ICAgIERFQlVHICgoREVCVUdfSU5GTywgIlNwSGVhcFNp emUgICAgICAtIDB4JXhcbiIsIFBheWxvYWRCb290SW5mby0+U3BIZWFwU2l6ZSkpOw0KPiA+ICAg IERFQlVHICgoREVCVUdfSU5GTywgIlNwTnNDb21tQnVmU2l6ZSAtIDB4JXhcbiIsIFBheWxvYWRC b290SW5mby0+U3BOc0NvbW1CdWZTaXplKSk7DQo+ID4gLSAgREVCVUcgKChERUJVR19JTkZPLCAi U3BQY3B1U2hhcmVkQnVmU2l6ZSAtIDB4JXhcbiIsIFBheWxvYWRCb290SW5mby0+U3BQY3B1U2hh cmVkQnVmU2l6ZSkpOw0KPiA+ICsgIERFQlVHICgoREVCVUdfSU5GTywgIlNwU2hhcmVkQnVmU2l6 ZSAtIDB4JXhcbiIsIFBheWxvYWRCb290SW5mby0+U3BTaGFyZWRCdWZTaXplKSk7DQo+ID4NCj4g PiAgICBERUJVRyAoKERFQlVHX0lORk8sICJOdW1DcHVzICAgICAgICAgLSAweCV4XG4iLCBQYXls b2FkQm9vdEluZm8tPk51bUNwdXMpKTsNCj4gPiAgICBERUJVRyAoKERFQlVHX0lORk8sICJDcHVJ bmZvICAgICAgICAgLSAweCVwXG4iLCBQYXlsb2FkQm9vdEluZm8tPkNwdUluZm8pKTsNCj4gPiAt LQ0KPiA+IDIuMTcuMQ0KPiA+DQogDQogDQoNCiANCiANCiANCg== ------=_001_NextPart784364182155_=---- Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
You may try to enlarger stmm_ns_comm_buf_size i= n Optee to check if it could solve ASSERT issue.

fanjianfeng@byosoft.com.cn
 
Subject: Re: [edk2-devel] [PATCH edk2 v1 1/3] StandaloneMmPkg= : Fix issue about SpPcpuSharedBufSize field
Hi A= rd,
 
On Wed, 15 Dec 2021 at 17:45, Ard Biesheuvel <ardb@kernel.org> w= rote:
>
> (+ Masahisa, Masami)
>
>
> On Fri, 15 Oct 2021 at 11:07, Ming Huang <huangming@linux.alib= aba.com> wrote:
> >
> > TF-A: TrustedFirmware-A
> > SPM: Secure Partition Manager(MM)
> >
> > In TF-A, the name of this field is sp_shared_buf_size. This = field is
> > the size of range for transmit data from TF-A to standaloneM= M when
> > SPM enable.
> >
> > SpPcpuSharedBufSize is pass from TF-A while StandaloneMM ini= tialize.
> > So, SpPcpuSharedBufSize should be rename to SpSharedBufSize = and this field
> > should no multiply by PayloadBootInfo->NumCpus;
> >
> > Signed-off-by: Ming Huang <huangming@linux.alibaba.com>= ;
>
> Could someone please check how this change of interpretation affe= cts
> standalone MM running on SynQuacer?
 
In conclusion, this patch does not affect the standalone MM implementa= tion
on SynQuacer.
 
In my check, this buffer is used for data sharing between EL3 and Secu= re-EL1/0.
Currently this buffer is only used to pass the struct spm_mm_boot_info= _t
from EL3 to StMM during Stmm initialization, I could not find other us= e cases.
 
TF-A maps the buffer only 64KB, not multiplied by the number of cores.=
https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/= socionext/synquacer/include/platform_def.h#n98
So the following definition is something strange and leads to
misunderstanding, but there is no problem.
   #define PLAT_SPM_BUF_BASE (BL32_LIMIT - 32 * PLAT_SPM_BUF= _SIZE)
Arm platform statically allocates 1MB buffer in TF-A,
so I think it is better to follow the arm platform definition.
 
 
This is different topic, but assertion occurs in DEBUG build if StMM
and SECURE_BOOT_ENABLED=3DTRUE.
 
=3D=3D=3D
Loading driver at 0x000FABB0000 EntryPoint=3D0x000FABC447C CapsuleRunt= imeDxe.efi
add-symbol-file
/home/ubuntu/src/sbsa-qemu/Build/DeveloperBox/DEBUG_GCC5/AARCH64/Secur= ityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe/DEBUG/= SecureBootConfigDxe.dll
0xFA6BA000
Loading driver at 0x000FA6B9000 EntryPoint=3D0x000FA6C9610 SecureBootC= onfigDxe.efi
add-symbol-file
/home/ubuntu/src/sbsa-qemu/Build/DeveloperBox/DEBUG_GCC5/AARCH64/MdeMo= dulePkg/Universal/BdsDxe/BdsDxe/DEBUG/BdsDxe.dll
0xFA69D000
Loading driver at 0x000FA69C000 EntryPoint=3D0x000FA6A7E98 BdsDxe.efi<= /div>
DxeCapsuleLibFmp: Failed to lock variable
39B68C46-F7FB-441B-B6EC-16B0F69821F3 CapsuleMax.  Status =3D Inva= lid
Parameter
 
ASSERT_EFI_ERROR (Status =3D Invalid Parameter)
ASSERT [BdsDxe]
/home/ubuntu/src/sbsa-qemu/edk2/MdeModulePkg/Library/DxeCapsuleLibFmp/= DxeCapsuleReportLib.c(133):
!(((INTN)(RETURN_STATUS)(Status)) < 0)
=3D=3D=3D
 
Probably it is due to the missing support of VariablePolicy, StMM
outputs the following log output.
=3D=3D=3D
CommBuffer - 0xFC85CC90, CommBufferSize - 0x52
!!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away = soon!
!!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
!!! DEPRECATED INTERFACE !!! Variable:
8BE4DF61-93CA-11D2-AA0D-00E098032B8C PlatformRecovery0000
=3D=3D=3D
 
That's all for now.
 
Thanks,
Masahisa Kojima
 
>
>
> > ---
> >  StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEn= tryPoint.h           = ;         | 2 +-
> >  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm= /CreateHobList.c          = ;    | 2 +-
> >  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm= /StandaloneMmCoreEntryPoint.c | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/StandaloneMmPkg/Include/Library/Arm/StandaloneM= mCoreEntryPoint.h b/StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEnt= ryPoint.h
> > index c44f7066c6..f1683ecb61 100644
> > --- a/StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEn= tryPoint.h
> > +++ b/StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEn= tryPoint.h
> > @@ -41,7 +41,7 @@ typedef struct {
> >    UINT64      =             &nb= sp;     SpPcpuStackSize;
> >    UINT64      =             &nb= sp;     SpHeapSize;
> >    UINT64      =             &nb= sp;     SpNsCommBufSize;
> > -  UINT64       &nbs= p;            &= nbsp;   SpPcpuSharedBufSize;
> > +  UINT64       &nbs= p;            &= nbsp;   SpSharedBufSize;
> >    UINT32      =             &nb= sp;     NumSpMemRegions;
> >    UINT32      =             &nb= sp;     NumCpus;
> >    EFI_SECURE_PARTITION_CPU_INFO *CpuInfo;
> > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPo= int/Arm/CreateHobList.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoin= t/Arm/CreateHobList.c
> > index 85f8194687..93773c9fe8 100644
> > --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm= /CreateHobList.c
> > +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm= /CreateHobList.c
> > @@ -173,7 +173,7 @@ CreateHobListFromBootInfo (
> >    // Base and size of buffer shared with pri= vileged Secure world software
> >    MmramRanges[1].PhysicalStart =3D PayloadBo= otInfo->SpSharedBufBase;
> >    MmramRanges[1].CpuStart   &= nbsp;  =3D PayloadBootInfo->SpSharedBufBase;
> > -  MmramRanges[1].PhysicalSize  =3D PayloadBootInf= o->SpPcpuSharedBufSize * PayloadBootInfo->NumCpus;
> > +  MmramRanges[1].PhysicalSize  =3D PayloadBootInf= o->SpSharedBufSize;
> >    MmramRanges[1].RegionState   =3D= EFI_CACHEABLE | EFI_ALLOCATED;
> >
> >    // Base and size of buffer used for synchr= onous communication with Normal
> > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPo= int/Arm/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMm= CoreEntryPoint/Arm/StandaloneMmCoreEntryPoint.c
> > index 49cf51a789..5db7019dda 100644
> > --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm= /StandaloneMmCoreEntryPoint.c
> > +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm= /StandaloneMmCoreEntryPoint.c
> > @@ -87,7 +87,7 @@ GetAndPrintBootinformation (
> >    DEBUG ((DEBUG_INFO, "SpPcpuStackSize - 0x%= x\n", PayloadBootInfo->SpPcpuStackSize));
> >    DEBUG ((DEBUG_INFO, "SpHeapSize  = ;    - 0x%x\n", PayloadBootInfo->SpHeapSize));
> >    DEBUG ((DEBUG_INFO, "SpNsCommBufSize - 0x%= x\n", PayloadBootInfo->SpNsCommBufSize));
> > -  DEBUG ((DEBUG_INFO, "SpPcpuSharedBufSize - 0x%x\n", = PayloadBootInfo->SpPcpuSharedBufSize));
> > +  DEBUG ((DEBUG_INFO, "SpSharedBufSize - 0x%x\n", Payl= oadBootInfo->SpSharedBufSize));
> >
> >    DEBUG ((DEBUG_INFO, "NumCpus  &n= bsp;      - 0x%x\n", PayloadBootInfo->NumCpus))= ;
> >    DEBUG ((DEBUG_INFO, "CpuInfo  &n= bsp;      - 0x%p\n", PayloadBootInfo->CpuInfo))= ;
> > --
> > 2.17.1
> >
 
 
 
 
 
------=_001_NextPart784364182155_=------