From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.3002.1639720204576469339 for ; Thu, 16 Dec 2021 21:50:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DNOFVw3r; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639720203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Vk1JsBMdLVcRAanW3cDGKkXlqidqza5Wy3+P/rJjFY=; b=DNOFVw3rLoBCpLNhIEml7AB9/PlrEf+/EiWhPpLUHSJZxT8qDccOJHQdhu7ezZTv6nwmpd 9A5RUHKce4Zafcoq4Xx0mr3cD0uAFONHdZ93sQxwDHOq3oRhfwN1uBS78ujwJe91MsJKRn skp5AIZ9UdOi3UqO/hI4dyfol17/KN0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-gxOpXum0PqKWysmt677YJg-1; Fri, 17 Dec 2021 00:49:59 -0500 X-MC-Unique: gxOpXum0PqKWysmt677YJg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82BAE1023F4E; Fri, 17 Dec 2021 05:49:58 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F265D10694FB; Fri, 17 Dec 2021 05:49:42 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 425A61800097; Fri, 17 Dec 2021 06:49:41 +0100 (CET) Date: Fri, 17 Dec 2021 06:49:41 +0100 From: "Gerd Hoffmann" To: Stefan Berger Cc: devel@edk2.groups.io, marcandre.lureau@redhat.com, shivanshu3@gmail.com, Ard Biesheuvel , Jiewen Yao , Jordan Justen Subject: Re: [PATCH] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case Message-ID: <20211217054941.l4trgxmz23dmfwwf@sirius.home.kraxel.org> References: <20211215154408.248444-1-stefanb@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <20211215154408.248444-1-stefanb@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi, > + // > + // GPU passthrough only allows console enablement after ROM image load > + // > + PlatformInitializeConsole ( > + XenDetected() ? gXenPlatformConsole : gPlatformConsole); > + AmdSev build breaks: /home/kraxel/projects/edk2/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c: In function ‘PlatformBootManagerBeforeConsole’: /home/kraxel/projects/edk2/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c:399:5: error: implicit declaration of function ‘XenDetected’ [-Werror=implicit-function-declaration] 399 | XenDetected() ? gXenPlatformConsole : gPlatformConsole); | ^~~~~~~~~~~ cc1: all warnings being treated as errors Otherwise it seems to work fine, no bad side effects from calling PlatformInitializeConsole() twice. take care, Gerd