public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: devel@edk2.groups.io, marcandre.lureau@redhat.com,
	shivanshu3@gmail.com, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case
Date: Fri, 17 Dec 2021 06:51:54 +0100	[thread overview]
Message-ID: <20211217055154.ksyo6omrzgdw4jjh@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211217024140.281271-1-stefanb@linux.ibm.com>

On Thu, Dec 16, 2021 at 09:41:40PM -0500, Stefan Berger wrote:
> For GPU passthrough support we have to initialize the console after
> EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after
> this. This was the calling order before the TCG physical presence support
> had to be moved and the console initialized earlier so user interaction
> could be supported before processing TCG physical presence opcodes.
> 
> Fixes: b8675deaa819631db2667df63f89799fe65fc906
> Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3771
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> Tested-by: Shivanshu Goyal <shivanshu3@gmail.com>

> +  //
> +  // GPU passthrough only allows Console enablement after ROM image load
> +  //
> +  PlatformInitializeConsole (gPlatformConsole);

Ah, fixed already.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd


  parent reply	other threads:[~2021-12-17  5:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17  2:41 [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case Stefan Berger
2021-12-17  2:44 ` Stefan Berger
2021-12-17  2:45 ` [edk2-devel] " Yao, Jiewen
2021-12-17  5:51 ` Gerd Hoffmann [this message]
2021-12-17 17:37   ` Ard Biesheuvel
2021-12-17 19:20     ` Shivanshu Goyal
2021-12-17 21:31       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211217055154.ksyo6omrzgdw4jjh@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox