From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.3019.1639720327212748838
 for <devel@edk2.groups.io>;
 Thu, 16 Dec 2021 21:52:07 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KCc1Zg/M;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639720326;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Jvkr0A5JgtBp8+l1r4WnKrnvPVlh0fddzFUJl7cO2c4=;
	b=KCc1Zg/MfRfvN3CHz1yjwE2fFhZVapKrcKDkJnLv3mKwpA5ekEScAvyMzAzxMu8j5KjnEP
	xa8sxKpZjAj33jpYbzCFlK+AbudX6gJOYlWGJyeN5ZeDawLsReGd/f5KK+HLEG6J6hhyMn
	Ds8EJfneoFZ2V9pY4qGNqmtt4jUj6ok=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-584-btBpvLXGNiWFpEwDB6a0Hw-1; Fri, 17 Dec 2021 00:52:01 -0500
X-MC-Unique: btBpvLXGNiWFpEwDB6a0Hw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7EDE1006AA1;
	Fri, 17 Dec 2021 05:51:59 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.14])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 1BD8E7EDAB;
	Fri, 17 Dec 2021 05:51:56 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 5FB241800097; Fri, 17 Dec 2021 06:51:54 +0100 (CET)
Date: Fri, 17 Dec 2021 06:51:54 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: devel@edk2.groups.io, marcandre.lureau@redhat.com, shivanshu3@gmail.com,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case
Message-ID: <20211217055154.ksyo6omrzgdw4jjh@sirius.home.kraxel.org>
References: <20211217024140.281271-1-stefanb@linux.ibm.com>
MIME-Version: 1.0
In-Reply-To: <20211217024140.281271-1-stefanb@linux.ibm.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 16, 2021 at 09:41:40PM -0500, Stefan Berger wrote:
> For GPU passthrough support we have to initialize the console after
> EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after
> this. This was the calling order before the TCG physical presence support
> had to be moved and the console initialized earlier so user interaction
> could be supported before processing TCG physical presence opcodes.
> 
> Fixes: b8675deaa819631db2667df63f89799fe65fc906
> Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3771
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> Tested-by: Shivanshu Goyal <shivanshu3@gmail.com>

> +  //
> +  // GPU passthrough only allows Console enablement after ROM image load
> +  //
> +  PlatformInitializeConsole (gPlatformConsole);

Ah, fixed already.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd