From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.4548.1640002315455448244 for ; Mon, 20 Dec 2021 04:11:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ezk+PM75; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640002314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ontbWVpNQKYJhRVda9fu76LRqwsqME21pskyK5GDu3E=; b=ezk+PM75+nrNp84FGBQTpaDbBj9aGLwcaikwKwGxafk10KODcoDSNGKWa1EZR6GZCTGqpR +N//yuEpiP2WZHErz2NL4f58gw8VMIipKmoVA1dkgJ+eySaB8WJuzBuymdDBuZqheFfQcK C+JaBYwzIWbFpG3TZ8CtnMgQpUxJfd0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-bH3K7l8fOcy3y221a-DRCw-1; Mon, 20 Dec 2021 07:11:51 -0500 X-MC-Unique: bH3K7l8fOcy3y221a-DRCw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64014192FDA7; Mon, 20 Dec 2021 12:11:49 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 738AE171FF; Mon, 20 Dec 2021 12:11:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 32499180063A; Mon, 20 Dec 2021 13:11:45 +0100 (CET) Date: Mon, 20 Dec 2021 13:11:45 +0100 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH 08/10] OvmfPkg: Update Sec to support Tdvf Config-B Message-ID: <20211220121145.aiqcqs6vd2hb2sb4@sirius.home.kraxel.org> References: <20211214134126.869-1-min.m.xu@intel.com> <20211214134126.869-9-min.m.xu@intel.com> <20211215102753.m4bp56bdxzgmdzkr@sirius.home.kraxel.org> <20211216142525.pkaxszwaevlpg4ap@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > > Why? Booting non-tdx guests without PEI shouldn't be fundamentally > > different from a TDX guest. Memory detection needs fw_cfg instead of the > > td_hob, and you have to skip some tdx setup steps, but that should be it. > > Code for all that exists in PlatformPei, it only needs to be moved to a place > > where SEC can use it too. > We would like to split TDVF Config-B into below stages. > 1. Basic Config-B (wave-3) > 1.1 A standalone IntelTdxX64.dsc/.fdf. Un-used drivers/libs are removed from the fdf, such as network components, SMM drivers, TPM drivers, etc. > 1.2 PEI FV is excluded from the build. Only DxeFV is included. > 1.3 Since PEI FV is excluded from the build, so Basic Config-B can only bring up Tdx guest. It *CAN NOT* bring up legacy guest. What blocks legacy guest bringup? See above, I think it should not be hard to do, and given that TDX-capable hardware is not yet production ready I find it rather important that testing the PEI-less boot workflow does not require TDX. It'll also make it much easier to add CI coverage. > 3.1 Add *basic* Ovmf feature without PEI, to achieve *ONE Binary* goal. (here basic means S3 is not supported without PEI) Sure, pei-less ovmf has to drop some features, that is perfectly fine. take care, Gerd