From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web12.754.1640050452880002752 for ; Mon, 20 Dec 2021 17:34:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=L28vcAtD; spf=pass (domain: gmail.com, ip: 209.85.214.179, mailfrom: kuqin12@gmail.com) Received: by mail-pl1-f179.google.com with SMTP id n16so8702486plc.2 for ; Mon, 20 Dec 2021 17:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6vN3yWYQSZ4lxeICmC8NPP/PWIkkqOdsrx3pHNn2zio=; b=L28vcAtDgz3l1EatERzp5L+82Xv9HsHgdsb9jiSTBLf/PHzgxJW69j9ZfdnAMkAsJE rrw1y/ZRi7PeEXZCJ4dr73EBCkBTa/O56d7uwTfKRO3VZEkjfQfzc+vsifnB/WXfNdOn dmLf/KIXXbOBYn2QCPPY400LPzXMegqKjoDp/W/7p+O6f6IY7Mbq0ZH+4LgKCLklxOGa gnKA2lNmp0O+gerSu3kIBZ0TLdd3g2HMnC7xXoR4JygWu4X0rI9IqplVuvrW8u5eOaGG oy4FP7JI1OWiwWnPTyxCIAM6zmhfTHUkOF4NPP2LjoCf3pI1YLMhYUKt5rCuSW2nIJsu B/8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6vN3yWYQSZ4lxeICmC8NPP/PWIkkqOdsrx3pHNn2zio=; b=16lqtCdh0lVCJKr1TtUiVVsR7Mxxkh35fSNvqQPB4gsSdPiEIbuY25573xwylPk7kQ SYKCvJ1OVh1ZG2WzStSgn20kyTjDTIM9QxlxNEdN18yQCDUrmbikd5lUbInXpVwXpvIr 9DvpQVcb+bCNK/W4UhTK2pMkt0pRfgITuhuzoufFIIyfRVClSuj5mSVqJCeNW/d8pD0F 8DVcbAH/PNROTN/IADkWnEhx7m8O2EUn8RQ1MbvTRTKK27ZDxHXw4/aV3n94SrEh+6Kp aerk8XyLR1QC2QAjdbvKRT3+N2DZ/aK87X4Dn/asi47V+onlqteQzjJ75KZpCG7DZ9cc Q5XQ== X-Gm-Message-State: AOAM530XMjmTvW+NN8QjQxDKUZeXjQL8WwBF/JE9FYlzkq3nucGjubWL w0lm0oZyYoqWf3ahNK7b9697/NLdyjlXWQ== X-Google-Smtp-Source: ABdhPJxlUfNH+rYyi9LtaiUoLZJj4ZJcSpQU2P0SLXyd6afyNHZnF2n6fvZ9S37azRVzPouJKpoEMA== X-Received: by 2002:a17:90a:1bc1:: with SMTP id r1mr1021780pjr.66.1640050452365; Mon, 20 Dec 2021 17:34:12 -0800 (PST) Return-Path: Received: from localhost.localdomain ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id m10sm17389189pgv.75.2021.12.20.17.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 17:34:12 -0800 (PST) From: "Kun Qin" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Bret Barkelew , Michael Kubacki Subject: [PATCH v2 3/6] ArmPkg: MmCommunicationDxe: MM communicate function argument attributes Date: Mon, 20 Dec 2021 17:33:31 -0800 Message-Id: <20211221013334.1751-4-kuqin12@gmail.com> X-Mailer: git-send-email 2.32.0.windows.1 In-Reply-To: <20211221013334.1751-1-kuqin12@gmail.com> References: <20211221013334.1751-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Current MM communicate2 function from ArmPkg described input arguments `CommBufferPhysical`, `CommBufferVirtual` and `CommSize` as input only, which mismatches with the "input and output type" as in PI specification. This change updated function descriptions of MM communite2 to match input argument types. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bret Barkelew Cc: Michael Kubacki Signed-off-by: Kun Qin --- Notes: v2: - Splitting patch into 1 of 4 [Ard] ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c index 7c8284104d87..7f756a32d4e0 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c @@ -41,12 +41,13 @@ STATIC EFI_HANDLE mMmCommunicateHandle; This function provides a service to send and receive messages from a registered UEFI service. - @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance. - @param[in] CommBufferPhysical Physical address of the MM communication buffer - @param[in] CommBufferVirtual Virtual address of the MM communication buffer - @param[in] CommSize The size of the data buffer being passed in. On exit, the size of data - being returned. Zero if the handler does not wish to reply with any data. - This parameter is optional and may be NULL. + @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance. + @param[in, out] CommBufferPhysical Physical address of the MM communication buffer + @param[in, out] CommBufferVirtual Virtual address of the MM communication buffer + @param[in, out] CommSize The size of the data buffer being passed in. On exit, the + size of data being returned. Zero if the handler does not + wish to reply with any data. This parameter is optional + and may be NULL. @retval EFI_SUCCESS The message was successfully posted. @retval EFI_INVALID_PARAMETER CommBufferPhysical was NULL or CommBufferVirtual was NULL. -- 2.32.0.windows.1