From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45])
 by mx.groups.io with SMTP id smtpd.web10.8487.1653394124549645604
 for <devel@edk2.groups.io>;
 Tue, 24 May 2022 05:08:44 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=sf754fai;
 spf=pass (domain: nuviainc.com, ip: 209.85.208.45, mailfrom: graeme@nuviainc.com)
Received: by mail-ed1-f45.google.com with SMTP id j4so18355842edq.6
        for <devel@edk2.groups.io>; Tue, 24 May 2022 05:08:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20210112.gappssmtp.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=cipTQyOMglk64sVJqLOnpqlbhVjPmAzxYbR/ZYhO8Wc=;
        b=sf754faiJOrjT+ix9iR4ZMrLSRPSQAuesn30eL2S4LRWq+j04PvTTeQpFZ5UDAXsJh
         /7MShiJ3ddc0ATyJuRR4UGb+8gP+Zr4u/3nizjQ9q7r99oV3hsURi39JZb2Vwl4xPc+e
         9E3zUCD8TobHnY1ZPLhI7SvgijGzhjQx6Fxvys9nkSfAIZAGntz1lWwBjwjl1pumfc1M
         NoZVNKVqz8OQy9CyPiO1eze6K7L9Tuat0d3abUK3CLtiQGN2cgBPrFXbhWUiazLUKhFZ
         9SViy52IhUg1wneRA58FZ6/sBeCIJFTqeM0RuMLbhSfFa8a4Im1mb5o0RyMi45UxsvyY
         +vfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=cipTQyOMglk64sVJqLOnpqlbhVjPmAzxYbR/ZYhO8Wc=;
        b=l785Ifbr++jU99WUYgGquNcP6k3ArQwSehepzNy+seRYozVzclXRGHvvNvR4hKd+RT
         XnXTDQorkGYmdONJnqWkoX2j2EaTTD8lMLR1FHiS/KcRIT2mWUo1mih/Yy+grTJE3WDV
         DJUcRjk6+60ApnkxFTwKihm6Nhhve24Fut1udXxzNqvG9LUdx1iPffIB9JUjTijErAUe
         9zmtOLPuxYGNdwTrRf5YxvAEuUgvH41dIPWvkbWgrmDWqS6lh4MSuEbQVxyiUiK/Rr1l
         HBgec6rUn5mv/MmUQIsEDdfuiszQTRe33wcVE/g2bwaMCVyH3MrPeRv6WwpFwq4RMR99
         TqgQ==
X-Gm-Message-State: AOAM530JWD65l5K6Ya6DFOpcbLIU1igE301Y+p4lYl0ie8ZbTXmM4/DD
	TSeZdtINlLeA/GvqHS+Nsu/Tow==
X-Google-Smtp-Source: ABdhPJwkJMxZoNrQqW4t1TmJ+zOrUn7rny4wc0s5eTCdUVpqfc8Fi9TwWG4cxqF1a67/mOHp6DytXg==
X-Received: by 2002:a05:6402:50c7:b0:42b:3a68:e1 with SMTP id h7-20020a05640250c700b0042b3a6800e1mr17217248edb.326.1653394123045;
        Tue, 24 May 2022 05:08:43 -0700 (PDT)
Return-Path: <graeme@nuviainc.com>
Received: from localhost ([62.3.69.143])
        by smtp.gmail.com with ESMTPSA id z7-20020a05640235c700b0042b0fcfe966sm6805800edc.37.2022.05.24.05.08.41
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 24 May 2022 05:08:42 -0700 (PDT)
Date: Tue, 21 Dec 2021 14:34:23 +0000
From: Graeme Gregory <graeme@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Wenyi Xie <xiewenyi2@huawei.com>, Peng Xie <xiepeng@phytium.com.cn>,
	Ling Jia <jialing@phytium.com.cn>,
	Yiqi Shu <shuyiqi@phytium.com.cn>,
	Nhi Pham <nhi@os.amperecomputing.com>,
	Vu Nguyen <vunguyen@os.amperecomputing.com>,
	Thang Nguyen <thang@os.amperecomputing.com>,
	Chuong Tran <chuong@os.amperecomputing.com>,
	Pete Batard <pete@akeo.ie>,
	Masami Hiramatsu <masami.hiramatsu@linaro.org>,
	Radoslaw Biernacki <rad@semihalf.com>,
	Marcin Wojtas <mw@semihalf.com>
Subject: Re: [PATCH v2 08/17] Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change
Message-ID: <20211221143423.GA212596@ggregory-linuxws>
References: <20211216220800.9628-1-rebecca@nuviainc.com>
 <20211216220800.9628-9-rebecca@nuviainc.com>
MIME-Version: 1.0
In-Reply-To: <20211216220800.9628-9-rebecca@nuviainc.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 16, 2021 at 03:07:51PM -0700, Rebecca Cran wrote:
> The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
> field instead of separate cluster/core fields. Update the initializer.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>

Looks sane to me

Reviewed-by: Graeme Gregory <quic_ggregory@quicinc.com>

> ---
>  Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c
> index fa9047020e6c..411f653913bd 100644
> --- a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c
> +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c
> @@ -15,7 +15,7 @@
>  ARM_CORE_INFO mArmPlatformNullMpCoreInfoTable[] = {
>    {
>      // Cluster 0, Core 0
> -    0x0, 0x0,
> +    0x000,
>  
>      // MP Core MailBox Set/Get/Clear Addresses and Clear Value
>      (EFI_PHYSICAL_ADDRESS)0,
> @@ -25,7 +25,7 @@ ARM_CORE_INFO mArmPlatformNullMpCoreInfoTable[] = {
>    },
>    {
>      // Cluster 0, Core 1
> -    0x0, 0x1,
> +    0x001,
>  
>      // MP Core MailBox Set/Get/Clear Addresses and Clear Value
>      (EFI_PHYSICAL_ADDRESS)0,
> @@ -35,7 +35,7 @@ ARM_CORE_INFO mArmPlatformNullMpCoreInfoTable[] = {
>    },
>    {
>      // Cluster 0, Core 2
> -    0x0, 0x2,
> +    0x002,
>  
>      // MP Core MailBox Set/Get/Clear Addresses and Clear Value
>      (EFI_PHYSICAL_ADDRESS)0,
> @@ -45,7 +45,7 @@ ARM_CORE_INFO mArmPlatformNullMpCoreInfoTable[] = {
>    },
>    {
>      // Cluster 0, Core 3
> -    0x0, 0x3,
> +    0x003,
>  
>      // MP Core MailBox Set/Get/Clear Addresses and Clear Value
>      (EFI_PHYSICAL_ADDRESS)0,
> -- 
> 2.31.1
>