* [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field
@ 2021-12-21 15:06 Rebecca Cran
2021-12-21 16:31 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Rebecca Cran @ 2021-12-21 15:06 UTC (permalink / raw)
To: devel, Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann,
Peter Grehan
Cc: Rebecca Cran
According to the ACPI Specification version 6.0 and newer, the SSDT
Revision field should be 2. Fix AcpiTables/Ssdt.aml.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
index 175ab3b7e66d..761b8267b9a5 100644
--- a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
+++ b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
@@ -11,5 +11,5 @@
**/
-DefinitionBlock ("Ssdt.aml", "SSDT", 1, "REDHAT", "OVMF ", 1) {
+DefinitionBlock ("Ssdt.aml", "SSDT", 2, "REDHAT", "OVMF ", 1) {
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field
2021-12-21 15:06 [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field Rebecca Cran
@ 2021-12-21 16:31 ` Ard Biesheuvel
2021-12-21 16:57 ` Rebecca Cran
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2021-12-21 16:31 UTC (permalink / raw)
To: Rebecca Cran
Cc: edk2-devel-groups-io, Ard Biesheuvel, Jiewen Yao, Jordan Justen,
Gerd Hoffmann, Peter Grehan
On Tue, 21 Dec 2021 at 16:06, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> According to the ACPI Specification version 6.0 and newer, the SSDT
> Revision field should be 2. Fix AcpiTables/Ssdt.aml.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
> index 175ab3b7e66d..761b8267b9a5 100644
> --- a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
> +++ b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
> @@ -11,5 +11,5 @@
>
> **/
>
> -DefinitionBlock ("Ssdt.aml", "SSDT", 1, "REDHAT", "OVMF ", 1) {
> +DefinitionBlock ("Ssdt.aml", "SSDT", 2, "REDHAT", "OVMF ", 1) {
> }
Wouldn't it be better to simply remove this file?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field
2021-12-21 16:31 ` Ard Biesheuvel
@ 2021-12-21 16:57 ` Rebecca Cran
0 siblings, 0 replies; 3+ messages in thread
From: Rebecca Cran @ 2021-12-21 16:57 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: edk2-devel-groups-io, Ard Biesheuvel, Jiewen Yao, Jordan Justen,
Gerd Hoffmann, Peter Grehan
On 12/21/21 09:31, Ard Biesheuvel wrote:
> On Tue, 21 Dec 2021 at 16:06, Rebecca Cran <rebecca@bsdio.com> wrote:
>> According to the ACPI Specification version 6.0 and newer, the SSDT
>> Revision field should be 2. Fix AcpiTables/Ssdt.aml.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
>> index 175ab3b7e66d..761b8267b9a5 100644
>> --- a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
>> +++ b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
>> @@ -11,5 +11,5 @@
>>
>> **/
>>
>> -DefinitionBlock ("Ssdt.aml", "SSDT", 1, "REDHAT", "OVMF ", 1) {
>> +DefinitionBlock ("Ssdt.aml", "SSDT", 2, "REDHAT", "OVMF ", 1) {
>> }
> Wouldn't it be better to simply remove this file?
It's no longer used, so yes I'll remove it.
--
Rebecca Cran
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-21 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-21 15:06 [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field Rebecca Cran
2021-12-21 16:31 ` Ard Biesheuvel
2021-12-21 16:57 ` Rebecca Cran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox