public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Abner Chang <abner.chang@hpe.com>
Cc: devel@edk2.groups.io, Daniel Schaefer <daniel.schaefer@hpe.com>
Subject: Re: [PATCH 65/79] RiscVPkg/PlatformPei: Fix the build error
Date: Sun, 9 Jan 2022 19:58:46 +0530	[thread overview]
Message-ID: <20220109142846.GB4879@sunil-ThinkPad-T490> (raw)
In-Reply-To: <20220108041420.16064-4-abner.chang@hpe.com>

On Sat, Jan 08, 2022 at 12:14:06PM +0800, Abner Chang wrote:
> Fix the build error caused by the dependency with edk2-platform code.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  .../Universal/Pei/PlatformPei/PlatformPei.inf         |  3 ---
>  RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.h | 11 +++++++++++
>  RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.c |  2 --
>  3 files changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/RiscVPlatformPkg/Universal/Pei/PlatformPei/PlatformPei.inf b/RiscVPlatformPkg/Universal/Pei/PlatformPei/PlatformPei.inf
> index 4b8e074b16..7a88099150 100644
> --- a/RiscVPlatformPkg/Universal/Pei/PlatformPei/PlatformPei.inf
> +++ b/RiscVPlatformPkg/Universal/Pei/PlatformPei/PlatformPei.inf
> @@ -37,7 +37,6 @@
>  
>  [Guids]
>    gEfiMemoryTypeInformationGuid
> -  gSiFiveU5SeriesPlatformsPkgTokenSpaceGuid
>  
>  [LibraryClasses]
>    DebugLib
> @@ -62,8 +61,6 @@
>    gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVDxeFvSize
>    gUefiRiscVPlatformPkgTokenSpaceGuid.PcdTemporaryRamBase
>    gUefiRiscVPlatformPkgTokenSpaceGuid.PcdTemporaryRamSize
> -  gSiFiveU5SeriesPlatformsPkgTokenSpaceGuid.PcdNumberofU5Cores
> -  gSiFiveU5SeriesPlatformsPkgTokenSpaceGuid.PcdE5MCSupported
>  
>  [Ppis]
>    gEfiPeiMasterBootModePpiGuid
> diff --git a/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.h b/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.h
> index c2cdd6d75b..00cf7f9dd7 100644
> --- a/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.h
> +++ b/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.h
> @@ -83,4 +83,15 @@ InitializeXen (
>    VOID
>    );
>  
> +/**
> +  Build processor and platform information for the U5 platform

Update the comment to remove U5? 

Regards
Sunil
> +
> +  @return EFI_SUCCESS     Status.
> +
> +**/
> +EFI_STATUS
> +BuildRiscVSmbiosHobs (
> +  VOID
> +);
> +
>  #endif // _PLATFORM_PEI_H_INCLUDED_
> diff --git a/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.c b/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.c
> index 8586a94b62..1cc64b3e9c 100644
> --- a/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.c
> +++ b/RiscVPlatformPkg/Universal/Pei/PlatformPei/Platform.c
> @@ -30,8 +30,6 @@
>  #include <Ppi/MasterBootMode.h>
>  #include <IndustryStandard/Pci22.h>
>  
> -#include <SiFiveU5MCCoreplex.h>
> -
>  #include "Platform.h"
>  
>  EFI_MEMORY_TYPE_INFORMATION mDefaultMemoryTypeInformation[] = {
> -- 
> 2.31.1
> 

  parent reply	other threads:[~2022-01-09 14:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220108041420.16064-1-abner.chang@hpe.com>
     [not found] ` <20220108041420.16064-2-abner.chang@hpe.com>
2022-01-09 14:27   ` [PATCH 63/79] RiscVPkg: Rename ProcessorPkg to RiscVPkg Sunil V L
     [not found] ` <20220108041420.16064-4-abner.chang@hpe.com>
2022-01-09 14:28   ` Sunil V L [this message]
     [not found] ` <20220108041420.16064-6-abner.chang@hpe.com>
2022-01-09 14:42   ` [PATCH 67/79] RiscVPlatformPkg: Address Core CI ECC errors Sunil V L
     [not found] ` <20220108041420.16064-7-abner.chang@hpe.com>
2022-01-09 14:53   ` [PATCH 68/79] RiscVPlatformVPkg: Address Core CI Spelling errors Sunil V L
     [not found] ` <20220108041420.16064-12-abner.chang@hpe.com>
2022-01-09 15:32   ` [PATCH 73/79] RiscVPkg: Address Core CI ECC errors Sunil V L
     [not found] ` <20220108041420.16064-14-abner.chang@hpe.com>
2022-01-09 15:39   ` [PATCH 75/79] RiscVPkg: Address Core CI Spelling errors Sunil V L
2022-01-08  7:27 [PATCH 62/79] RiscVPlatformPkg: Rename PlatformPkg to RiscVPlatformPkg Abner Chang
2022-01-08  7:27 ` [PATCH 65/79] RiscVPkg/PlatformPei: Fix the build error Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220109142846.GB4879@sunil-ThinkPad-T490 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox