From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mx.groups.io with SMTP id smtpd.web09.19130.1641742331085627331 for ; Sun, 09 Jan 2022 07:32:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Z2R3HV9L; spf=pass (domain: ventanamicro.com, ip: 209.85.216.49, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f49.google.com with SMTP id l10-20020a17090a384a00b001b22190e075so19468431pjf.3 for ; Sun, 09 Jan 2022 07:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=N+5y07AD9NK1OwHlvhrU59LYuRXPc/PxVQ+t11xr/Ik=; b=Z2R3HV9LAvChaLrnAgVobnJ2VEDKd7UUmxNqluGW5ZYHg7aYfX/uPiFJBgehOFHQx4 piVWmwX4yOrdl1L1ZjDkUxE05dZgU0GULEnV8ZfCXN18cmP2OSjatXXWa7RrusTRXK+6 oxogltMBr7aTKuA7l2yh7oDxtJ00JSHpWDS5MhuBm5TfexuZZ628/gvkyvweOBRucU70 yEDto6ow5tLjNXGj0LNOo1BK9henZbkWB2yWk52uI6FWJJfNujm3B+nrJ9s7z/RM1I31 6Aic6WksLrCqJDXYesvBM7lZivTw1IjsdBgdo2VajrhmQOhzK9LaO09kY/sYd/ndrzdT PpcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N+5y07AD9NK1OwHlvhrU59LYuRXPc/PxVQ+t11xr/Ik=; b=0rIyy8NT6tWqv2yE0eR4cg820cy8oNeVvqLO3pXw5ZhGUohJNdLmkRYspkJND4XiV8 Nf57ws0+cp2x4rjTGqABuFVtDx4e9DL9eXXhnsUgsMSQ8JnN5OPYzi7YROyTC5bEWR+T HuzUXEZE4QwCFLH5yI+oGn6IDLtxwYbkF/pcJcJtCjVXibUIdvg8gHlUiSQQGjOIhGdH rz6mZB67OnzP6ESuw5mptk0WIXiT4J4oiYQFj46qE493H14X+ZB7sd1M2hEg95UwGSjh dO5rLdBJ8hwrXKaG2ZK8KfbGlQR/R3As7KwiptroLQ31Q+b5TnqvIfwW6c6/pVLZjMRC 08pQ== X-Gm-Message-State: AOAM531TdCCe7EHetOoVv6yjB2BhCB0XFiZif+yod7R9WZAeeCKhYht1 QzFSthS83dsAout02+PsLp95lQ== X-Google-Smtp-Source: ABdhPJziNRMSPkKZJBQu+HLYKCKoOFzT5v3+cWMhwPF++0AcBRMBa+uA8ezNpgUl1cmtf+zCC+4Iqw== X-Received: by 2002:a17:903:1ce:b0:148:ca49:b017 with SMTP id e14-20020a17090301ce00b00148ca49b017mr70907256plh.18.1641742330621; Sun, 09 Jan 2022 07:32:10 -0800 (PST) Return-Path: Received: from sunil-ThinkPad-T490 ([49.206.3.187]) by smtp.gmail.com with ESMTPSA id v10sm5895283pjs.8.2022.01.09.07.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jan 2022 07:32:10 -0800 (PST) Date: Sun, 9 Jan 2022 21:02:05 +0530 From: "Sunil V L" To: Abner Chang Cc: devel@edk2.groups.io, Daniel Schaefer Subject: Re: [PATCH 73/79] RiscVPkg: Address Core CI ECC errors. Message-ID: <20220109153205.GE4879@sunil-ThinkPad-T490> References: <20220108041420.16064-1-abner.chang@hpe.com> <20220108041420.16064-12-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <20220108041420.16064-12-abner.chang@hpe.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 08, 2022 at 12:14:14PM +0800, Abner Chang wrote: > Signed-off-by: Abner Chang > Cc: Daniel Schaefer > Cc: Sunil V L > --- > RiscVPkg/RiscVPkg.dec | 2 ++ > RiscVPkg/RiscVPkg.dsc | 4 ++-- > .../RiscVFirmwareContextSbiLib.inf | 2 +- > .../Include/Library/MachineModeTimerLib.h | 15 +++++++++++++ > .../Include/Library/RiscVPlatformTimerLib.h | 21 +++++++++++++++++++ > .../CpuExceptionHandlerLib.h | 2 +- > RiscVPkg/RiscVPkg.uni | 18 +++++++++++++++- > 7 files changed, 59 insertions(+), 5 deletions(-) > create mode 100644 RiscVPkg/Include/Library/MachineModeTimerLib.h > create mode 100644 RiscVPkg/Include/Library/RiscVPlatformTimerLib.h > > diff --git a/RiscVPkg/RiscVPkg.dec b/RiscVPkg/RiscVPkg.dec > index f23d3c0135..1e2d2fac0d 100644 > --- a/RiscVPkg/RiscVPkg.dec > +++ b/RiscVPkg/RiscVPkg.dec > @@ -26,6 +26,8 @@ > RiscVCpuLib|Include/Library/RiscVCpuLib.h > RiscVEdk2SbiLib|Include/Library/RiscVEdk2SbiLib.h > RiscVFirmwareContextLib|Include/Library/RiscVFirmwareContextLib.h > + RiscVPlatformTimerLib|Include/Library/RiscVPlatformTimerLib.h > + MachineModeTimerLib|Include/Library/MachineModeTimerLib.h > > [Guids] > gUefiRiscVPkgTokenSpaceGuid = { 0x4261e9c8, 0x52c0, 0x4b34, { 0x85, 0x3d, 0x48, 0x46, 0xea, 0xd3, 0xb7, 0x2c}} > diff --git a/RiscVPkg/RiscVPkg.dsc b/RiscVPkg/RiscVPkg.dsc > index 7e8c8f599c..c1cd11a161 100644 > --- a/RiscVPkg/RiscVPkg.dsc > +++ b/RiscVPkg/RiscVPkg.dsc > @@ -1,11 +1,11 @@ > -#/** @file > +## @file > # RISC-V package. > # > # Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > -#**/ > +# > > ################################################################################ > # > diff --git a/RiscVPkg/Library/RiscVFirmwareContextSbiLib/RiscVFirmwareContextSbiLib.inf b/RiscVPkg/Library/RiscVFirmwareContextSbiLib/RiscVFirmwareContextSbiLib.inf > index db30d7e551..e3dbc05007 100644 > --- a/RiscVPkg/Library/RiscVFirmwareContextSbiLib/RiscVFirmwareContextSbiLib.inf > +++ b/RiscVPkg/Library/RiscVFirmwareContextSbiLib/RiscVFirmwareContextSbiLib.inf > @@ -12,7 +12,7 @@ > [Defines] > INF_VERSION = 0x0001001b > BASE_NAME = RiscVFirmwareContextSbiLib > - FILE_GUID = 3709E048-6794-427A-B728-BFE3FFD6D461 > + FILE_GUID = 308117C0-400A-79C5-6ED4-AB9763A202E5 Any reason to have new GUID? > MODULE_TYPE = PEIM > VERSION_STRING = 1.0 > LIBRARY_CLASS = RiscVFirmwareContextLib|PEIM PEI_CORE > diff --git a/RiscVPkg/Include/Library/MachineModeTimerLib.h b/RiscVPkg/Include/Library/MachineModeTimerLib.h > new file mode 100644 > index 0000000000..a27391cca3 > --- /dev/null > +++ b/RiscVPkg/Include/Library/MachineModeTimerLib.h > @@ -0,0 +1,15 @@ > +/** @file > + RISC-V Machine Mode Timer Library Definition > + > + Copyright (c) 2022, Hewlett Packard Enterprise Development LP. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef MACHINE_MODE_TIMER_LIB_H_ > +#define MACHINE_MODE_TIMER_LIB_H_ > + > +UINT64 > +RiscVReadMachineTimerInterface (VOID); > + > +#endif > diff --git a/RiscVPkg/Include/Library/RiscVPlatformTimerLib.h b/RiscVPkg/Include/Library/RiscVPlatformTimerLib.h > new file mode 100644 > index 0000000000..dcd8734eb5 > --- /dev/null > +++ b/RiscVPkg/Include/Library/RiscVPlatformTimerLib.h > @@ -0,0 +1,21 @@ > +/** @file > + RISC-V Platform Timer library definitions. > + > + Copyright (c) 2022, Hewlett Packard Enterprise Development LP. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef RISCV_PLATFORM_TIMER_LIB_H_ > +#define RISCV_PLATFORM_TIMER_LIB_H_ > + > +UINT64 > +RiscVReadMachineTimer (VOID); > + > +VOID > +RiscVSetMachineTimerCmp (UINT64); > + > +UINT64 > +RiscVReadMachineTimerCmp(VOID); > + > +#endif > diff --git a/RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerLib.h b/RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerLib.h > index 3e480e9b09..b316510020 100644 > --- a/RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerLib.h > +++ b/RiscVPkg/Library/RiscVExceptionLib/CpuExceptionHandlerLib.h > @@ -1,4 +1,4 @@ > -/**@file > +/** @file > > RISC-V Exception Handler library definition file. > > diff --git a/RiscVPkg/RiscVPkg.uni b/RiscVPkg/RiscVPkg.uni > index 7e470eb531..d459272444 100644 > --- a/RiscVPkg/RiscVPkg.uni > +++ b/RiscVPkg/RiscVPkg.uni > @@ -8,6 +8,22 @@ > // **/ > > #string STR_PACKAGE_ABSTRACT #language en-US "Provides UEFI compatible RISC-V processor modules and libraries" > - > #string STR_PACKAGE_DESCRIPTION #language en-US "This Package provides UEFI compatible RISC-V processor modules and libraries." > > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSpecificDataGuidHobGuid_PROMPT #language en-US "Processor Specific Data HOB GUID" > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSpecificDataGuidHobGuid_HELP #language en-US "This is the GUID definition of HOB that passes the " > + "processor specific data to DXE phase." > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSmbiosGuidHobGuid_PROMPT #language en-US "RISC-V SMBIOS Data HOB GUID" > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSmbiosGuidHobGuid_HELP #language en-US "This is the GUID definition of HOB that passes RISC-V SMBIOS" > + "Data to DXE phase." I think space is required between multi line help string. Same comment for other places. > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSmbiosType4GuidHobGuid_PROMPT #language en-US "RISC-V SMBIOS Type 4 Data HOB GUID" > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSmbiosType4GuidHobGuid_HELP #language en-US "This is the GUID definition of HOB that passes RISC-V SMBIOS" > + "Type 4 information to DXE phase for building up SMBIOS record." > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSmbiosType7GuidHobGuid_PROMPT #language en-US "RISC-V SMBIOS Type 7 Data HOB GUID" > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdProcessorSmbiosType7GuidHobGuid_HELP #language en-US "This is the GUID definition of HOB that passes RISC-V SMBIOS" > + "Type 7 information to DXE phase for building up SMBIOS record." > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdRiscVMachineTimerTickInNanoSecond_PROMPT #language en-US "RISC-V Machine Mode Timer Duration" > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdRiscVMachineTimerTickInNanoSecond_HELP #language en-US "RISC-V Machine Mode Timer Duration in nanosecond." > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdRiscVMachineTimerFrequencyInHerz_PROMPT #language en-US "RISC-V Machine Mode Timer frequency." > +#string STR_gUefiRiscVPkgTokenSpaceGuid_PcdRiscVMachineTimerFrequencyInHerz_HELP #language en-US "RISC-V Machine Mode Timer frequency in Herz" Should this Hertz instead of Herz? Regards Sunil > + > -- > 2.31.1 >