From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, maggie.chu@intel.com
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v3] MdePkg: Add registers of boot partition feature
Date: Thu, 13 Jan 2022 12:02:25 +0100 [thread overview]
Message-ID: <20220113110225.v7g3slpobimqqzny@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220105103506.2056-1-maggie.chu@intel.com>
On Wed, Jan 05, 2022 at 06:35:06PM +0800, Maggie Chu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3757
>
> Add registers of boot partition feature which defined in NVM Express 1.4 Spec
nvme boot in qemu broke, and git bisect landed at this commit.
Error message:
NvmeControllerInit: the controller doesn't support NVMe command set
> // These register offsets are defined as 0x1000 + (N * (4 << CAP.DSTRD))
> @@ -51,11 +55,14 @@ typedef struct {
> UINT8 To; // Timeout
> UINT16 Dstrd : 4;
> UINT16 Nssrs : 1; // NVM Subsystem Reset Supported NSSRS
> - UINT16 Css : 4; // Command Sets Supported - Bit 37
> - UINT16 Rsvd3 : 7;
> + UINT16 Css : 8; // Command Sets Supported - Bit 37
> + UINT16 Bps : 1; // Boot Partition Support - Bit 45 in NVMe1.4
> + UINT16 Rsvd3 : 2;
This looks very suspicious ...
take care,
Gerd
next prev parent reply other threads:[~2022-01-13 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 10:35 [PATCH v3] MdePkg: Add registers of boot partition feature Maggie Chu
2022-01-13 11:02 ` Gerd Hoffmann [this message]
[not found] <16C7596FAB5B38CF.28870@groups.io>
2022-01-05 10:36 ` [edk2-devel] " Maggie Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113110225.v7g3slpobimqqzny@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox