public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Guomin Jiang <guomin.jiang@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>
Subject: Re: [PATCH 1/8] CryptoPkg/CrtLibSupport: add fcntl.h
Date: Mon, 17 Jan 2022 12:07:05 +0100	[thread overview]
Message-ID: <20220117110705.mgru4su7nsiyujp2@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220117105234.1981719-2-kraxel@redhat.com>

On Mon, Jan 17, 2022 at 11:52:27AM +0100, Gerd Hoffmann wrote:
> Add fcntl.h header file.
> Will be needed by openssl 3.0.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  CryptoPkg/Library/Include/fcntl.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 CryptoPkg/Library/Include/fcntl.h
> 
> diff --git a/CryptoPkg/Library/Include/fcntl.h b/CryptoPkg/Library/Include/fcntl.h
> new file mode 100644
> index 000000000000..040ecfa5193d
> --- /dev/null
> +++ b/CryptoPkg/Library/Include/fcntl.h
> @@ -0,0 +1,9 @@
> +/** @file
> +  Include file to support building the third-party cryptographic library.
> +
> +Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <CrtLibSupport.h>

Hmm, CI throws codestyle errors (see below) on this one even though it
looks identical to the stdio.h next to it.  Apparently stdio.h is
whitelisted somewhere but I can't find the place ...

Hints anyone?

thanks,
  Gerd

------------------- cut here -----------------
ERROR - 
ERROR - EFI coding style error
ERROR - *Error code: 6001
ERROR - *All include file contents should be guarded by a #ifndef statement.
ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/CryptoPkg/Library/Include/fcntl.h
ERROR - *Line number: 1
ERROR - *
ERROR - 
ERROR - EFI coding style error
ERROR - *Error code: 8004
ERROR - *Path name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters
ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/CryptoPkg/Library/Include/fcntl.h
ERROR - *Line number: 1
ERROR - *The file path [fcntl.h] does not follow the rules
ERROR - 


  reply	other threads:[~2022-01-17 11:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 10:52 [PATCH 0/8] CryptoPkg updates for openssl 3.0 Gerd Hoffmann
2022-01-17 10:52 ` [PATCH 1/8] CryptoPkg/CrtLibSupport: add fcntl.h Gerd Hoffmann
2022-01-17 11:07   ` Gerd Hoffmann [this message]
2022-01-17 10:52 ` [PATCH 2/8] CryptoPkg/CrtLibSupport: add strstr() Gerd Hoffmann
2022-01-17 10:52 ` [PATCH 3/8] CryptoPkg/CrtLibSupport: add INT_MIN Gerd Hoffmann
2022-01-17 10:52 ` [PATCH 4/8] CryptoPkg/CrtLibSupport: add UINT_MAX Gerd Hoffmann
2022-01-17 10:52 ` [PATCH 5/8] CryptoPkg/CrtLibSupport: add MODULESDIR Gerd Hoffmann
2022-01-17 10:52 ` [PATCH 6/8] CryptoPkg/CrtLibSupport: add off_t Gerd Hoffmann
2022-01-17 10:52 ` [PATCH 7/8] CryptoPkg/CrtLibSupport: fix strcpy Gerd Hoffmann
2022-01-17 10:52 ` [PATCH 8/8] CryptoPkg/UnitTest: fix DH testcase Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220117110705.mgru4su7nsiyujp2@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox