From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.9824.1642417632191035426 for ; Mon, 17 Jan 2022 03:07:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E22m642M; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642417631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zniiQGSwm9bcviGDnfm6LECejLXuB4vUi0lCgVIBz2M=; b=E22m642Mj9E/OunAissxUvxi6ipsHg/5/USU92rjhdCLmqjKkRvVN2j9H60pri1Z5CenB0 tcxQL8Av0jLFUZ8gslw979eRSFXP6j71ohPUy5rAlOu5r8omtoZP1ubdTVkAyZfTqvH0kT mN/YOaOveARJeWSqt20Ns9ffEaMAdyM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-ugJYAtPqONebN96htc2Fmg-1; Mon, 17 Jan 2022 06:07:08 -0500 X-MC-Unique: ugJYAtPqONebN96htc2Fmg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3273D1017968; Mon, 17 Jan 2022 11:07:07 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9ED67CAFE; Mon, 17 Jan 2022 11:07:06 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 30D92180060F; Mon, 17 Jan 2022 12:07:05 +0100 (CET) Date: Mon, 17 Jan 2022 12:07:05 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Xiaoyu Lu , Pawel Polawski , Guomin Jiang , Jiewen Yao , Jian J Wang Subject: Re: [PATCH 1/8] CryptoPkg/CrtLibSupport: add fcntl.h Message-ID: <20220117110705.mgru4su7nsiyujp2@sirius.home.kraxel.org> References: <20220117105234.1981719-1-kraxel@redhat.com> <20220117105234.1981719-2-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220117105234.1981719-2-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 17, 2022 at 11:52:27AM +0100, Gerd Hoffmann wrote: > Add fcntl.h header file. > Will be needed by openssl 3.0. > > Signed-off-by: Gerd Hoffmann > --- > CryptoPkg/Library/Include/fcntl.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > create mode 100644 CryptoPkg/Library/Include/fcntl.h > > diff --git a/CryptoPkg/Library/Include/fcntl.h b/CryptoPkg/Library/Include/fcntl.h > new file mode 100644 > index 000000000000..040ecfa5193d > --- /dev/null > +++ b/CryptoPkg/Library/Include/fcntl.h > @@ -0,0 +1,9 @@ > +/** @file > + Include file to support building the third-party cryptographic library. > + > +Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include Hmm, CI throws codestyle errors (see below) on this one even though it looks identical to the stdio.h next to it. Apparently stdio.h is whitelisted somewhere but I can't find the place ... Hints anyone? thanks, Gerd ------------------- cut here ----------------- ERROR - ERROR - EFI coding style error ERROR - *Error code: 6001 ERROR - *All include file contents should be guarded by a #ifndef statement. ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/CryptoPkg/Library/Include/fcntl.h ERROR - *Line number: 1 ERROR - * ERROR - ERROR - EFI coding style error ERROR - *Error code: 8004 ERROR - *Path name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/CryptoPkg/Library/Include/fcntl.h ERROR - *Line number: 1 ERROR - *The file path [fcntl.h] does not follow the rules ERROR -