From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.62]) by mx.groups.io with SMTP id smtpd.web08.4216.1642633435181489234 for ; Wed, 19 Jan 2022 15:03:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=vP2gi9Aq; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.62, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J9P/tJgu5w6Ko6KOmgWi82mPtyVmgK5EawqEzZBYWqUMK3wTOvlVyHLK024P8cC/vIKFJaqNwUVs3q4XYsTk8VymIYAX7EbhEPRBy9a14RQfYbQCejTQRwCBK2vKW8m5MYDw0yw3yDoAJJH9E0TdQzZ1YgI4VrSbPBWjGNp+e2te+sauYLLXl23AY4ltMcPvZF5ell1aD/Ih3Oe8sFb9GpWaUQW6H62GDq+XuDmpcivO/jsVkZbLEzEMF5HpjPrqLJYDVYk3uz8a+VPg6x1zks8si65Aa+9Vz3pB9MtTgo68OBLEwFnzgdmN01E00b4jlyWtlvRPPaurOvIV3EIyeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IGtOPk2gd2QeVAzdlm7tW0jAox5Lr0Mjbx5Fm3+LR04=; b=DPvJLS8FxjiQFBzq1BUxLr8Qmi5LAtGRzvDT0Ddg4crYjB6Wck+7L1eXIGszogXEIrzslz+oBf7yFjfSsnt2uGMI9LgxhbfULmgVbzw8O56qfN3jwXcnBzDr7zX347ZgqwgcHCDuvLjjMG+FWUI0k8ly4eoUoiV12OPcKmiLYWfeLau8iL5/FSn44BLiOF1jG2+O5+TYfv83N/M6NybhY9RC4DsmUcohfgow2OWvRyDiZeB94Elpib/eM0xdCOPzhokHkgCqVuPLdmiUvGwiOdDnnriM9huqpl2b+v+BQEwHD87QrRYpThF/6SLfZNMaLfuGAJA8W0iNbtm9R4gFEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IGtOPk2gd2QeVAzdlm7tW0jAox5Lr0Mjbx5Fm3+LR04=; b=vP2gi9AqOPZKI8GT6ylk3XCgXax45aV4hn6lEZmP8f3fU/wUngD2veDcTZrfhWgLmdg+ivyfPYkh5e6D2hs93gxZ3BXKWP/wwMv+1g+YtQ3un5gUD23RTf1tdJ3d/Bn2YU363z0z0rbzcKn1N3a2g6HhMfA2hzgWJd5uX3Bbzm0= Received: from DS7PR05CA0044.namprd05.prod.outlook.com (2603:10b6:8:2f::10) by BN9PR12MB5130.namprd12.prod.outlook.com (2603:10b6:408:137::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Wed, 19 Jan 2022 23:03:52 +0000 Received: from DM6NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::fc) by DS7PR05CA0044.outlook.office365.com (2603:10b6:8:2f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.3 via Frontend Transport; Wed, 19 Jan 2022 23:03:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT013.mail.protection.outlook.com (10.13.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4909.7 via Frontend Transport; Wed, 19 Jan 2022 23:03:52 +0000 Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 19 Jan 2022 17:03:50 -0600 From: "Brijesh Singh" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , Brijesh Singh Subject: [PATCH 0/2] SEV BaseMemEncryptLib cleanup Date: Wed, 19 Jan 2022 17:03:30 -0600 Message-ID: <20220119230332.44888-1-brijesh.singh@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Return-Path: brijesh.singh@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60e04b4f-81b5-4994-3c45-08d9db9ff5fc X-MS-TrafficTypeDiagnostic: BN9PR12MB5130:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v6qEUgPxmob04oGV6CKE1o71tmcoUWpi+R7bltguzVEMqmroOcbfl9Q1T1kE5l9tp2+UDctlwahQkbTbb54yWSdAA4IACRy2xmYLGFow7W6WLGkhsi01VEpzJvhbA0McJLzwMbXncSFeFEP2jmlFSaZqpFivuzkbXV4Q02gQx4F30VsPYkdLidmGioTuv+KnVvap8Lx4W8bfYpMKcv4kcFZpIWw9ymSZ9ktPyUvsCX9gq9ZV9Ces9Sv2vtqrxVtjWw6DPo6iKmba2FVeJJ0MSJ5ETXtJGrWHOfHXdMsU78WRZIFZKgvQfrDGhiZHqLRYD0uX6CLAnhpzgPEl6pxmeq1zGtZqZutnU3gTfEsDeQS+nQ7RLBD6qp80WhDGuIPgqUv7AkMIlffPU9D7hZrh8hTJsohkRDUYSf5hOwxwIkTFbZXQhrGgqhtyynAALCbIfqTwV8VFtLm6YBp2yia5A9qwACBkC724X7BCRFi0iZLk9ruDB+jpyAwCtEWGTZg+fkk4SuVh4WVekAA9ZXA23lLaxIDHB2+HhRpc9kQH8s6WAVlytbfozGwRcCzs2FvqaGCL6Rr1OCi95Olq56myiyT3ZLfZQagQGmDfgd2ODXNZRAmueoNPa8fewbSFg91K4QjO1SrDGO60c0V4+m0wu8uNX/a8wEsiTI7r6tXRmdT++dvgG6PP1oStiPPAD/NCsYXF41XwiSzsqbb9e6OHcZ6RNxzjqTsM19dbpHuDi0LM22tKt2VdCX3slbrWv/AVpKmasNqoasnUuOTHxYiB1JkBX1SgNmaCCmgkgh+Lecya8l6PhyookaK2NZ9Sg6cOExt1HweOJwPwVfvu130l9LXZGPARQ/NKpIGsAd0x1glzDZGfxVuZ8HUmfKeoiO8Z X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(40470700002)(36840700001)(5660300002)(2906002)(7696005)(1076003)(44832011)(86362001)(4326008)(70206006)(54906003)(6916009)(6666004)(316002)(82310400004)(426003)(81166007)(8676002)(40460700001)(36860700001)(36756003)(356005)(508600001)(19627235002)(16526019)(2616005)(966005)(186003)(26005)(83380400001)(70586007)(47076005)(336012)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 23:03:52.1929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60e04b4f-81b5-4994-3c45-08d9db9ff5fc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5130 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain This is the first of cleanup for SEV MemEncryptLib. The library uses the CPUID followed by the MSR read to determine whether SEV is enabled. Now that we have a workarea concept, the logic can be simplified to store the msr status in workarea and use that to build PCDs and then later simply use the PCDs instead of going through the CPUID and RDMSR. The complete branch is available at https://github.com/codomania/edk2/tree/sev-workarea-cleanup Brijesh Singh (2): OvmfPkg/ResetVector: cache the SEV status MSR value in workarea OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from workarea .../DxeMemEncryptSevLib.inf | 1 + .../PeiMemEncryptSevLib.inf | 1 + .../SecMemEncryptSevLib.inf | 1 + OvmfPkg/Include/WorkArea.h | 12 +- .../DxeMemEncryptSevLibInternal.c | 142 ++++++++---------- .../PeiMemEncryptSevLibInternal.c | 139 ++++++----------- .../SecMemEncryptSevLibInternal.c | 80 +++++----- OvmfPkg/Sec/AmdSev.c | 2 +- OvmfPkg/ResetVector/Ia32/AmdSev.asm | 38 +++-- OvmfPkg/ResetVector/Ia32/Flat32ToFlat64.asm | 3 +- OvmfPkg/ResetVector/ResetVector.nasmb | 3 + 11 files changed, 189 insertions(+), 233 deletions(-) --=20 2.25.1