From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web09.9143.1642752263921736416
 for <devel@edk2.groups.io>;
 Fri, 21 Jan 2022 00:04:24 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=coj6WUeu;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1642752263;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=yJ+tuUXwqjt9Lvuzgu1wQStdfhgP5D+hIKVHkjXJrF4=;
	b=coj6WUeu3W8gm+BAlmTRpDMkXgf7mF8gIZl0orxdmTnz36oBF0HU/3e8gfYr/t6C7mPUB3
	jZWWT0myxgV31FD8t/Nvhm6xtI+vqFm9aFh3NYBcwDG5ZKQQLLqMzM310AIlwRXv6ZYt4z
	J5XzDhNx0d8eWpbCj/pWHJJb1blEIn4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-475-wGrO-_iIPCutfFUNGdEFkQ-1; Fri, 21 Jan 2022 03:04:12 -0500
X-MC-Unique: wGrO-_iIPCutfFUNGdEFkQ-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A5F6835B4B;
	Fri, 21 Jan 2022 08:04:10 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.47])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FE8770D28;
	Fri, 21 Jan 2022 08:04:10 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 9F99F180009C; Fri, 21 Jan 2022 09:04:08 +0100 (CET)
Date: Fri, 21 Jan 2022 09:04:08 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library
Message-ID: <20220121080408.75lupx2n7e5iwbsa@sirius.home.kraxel.org>
References: <cover.1639399598.git.min.m.xu@intel.com>
 <fda3d7ba592915a48ba4dadf808709c4e408bef6.1639399598.git.min.m.xu@intel.com>
 <20211215091600.q63ltwlbliwjbm4q@sirius.home.kraxel.org>
 <PH0PR11MB5064C4CD01FE7D236B38F28DC55B9@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB5064C4CD01FE7D236B38F28DC55B9@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > Can we move most of the code to a (x64) page table library instead of
> > cut+pasting like this, please?

> As I explained in https://edk2.groups.io/g/devel/message/85582, there
> has already been a same feature requirement.
> https://bugzilla.tianocore.org/show_bug.cgi?id=847 . (Create page
> table library to abstract all page table manipulations) I discussed
> with the feature owner (Ni, Ray).  He said this feature is in his plan
> of 2022. He suggest I can wait for the library.

Ok.  Can you add a comment to the source code saying this is temporary
until the lib is there, and a link to the bug?

thanks,
  Gerd