From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.9951.1642759755206802840
 for <devel@edk2.groups.io>;
 Fri, 21 Jan 2022 02:09:15 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JZYqF6En;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1642759754;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RUJiQmkHR1XYX0dg4roWlBHggKD/ySYExRS/nkXtjGA=;
	b=JZYqF6En+TMnXSZID0gZNeD+jUJir/l4F1HD3duFgcqzEIUSXV2X+iUBBv/vE1ltfI3uTW
	V47auV+EfxLnu8xP4ggwFdLxbu3LKr3/X1khsR/bseErtcisgTQiqdqNpWxMyR2226F1Ra
	QrQO/v3F421yCrvfJb1d6OgH+ZfxMY0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-250-S6vV4OwCMm6hgJFdv6tlRg-1; Fri, 21 Jan 2022 05:09:11 -0500
X-MC-Unique: S6vV4OwCMm6hgJFdv6tlRg-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0985218B6141;
	Fri, 21 Jan 2022 10:09:10 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.47])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id B0ABD6F16B;
	Fri, 21 Jan 2022 10:09:09 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 207AE180009C; Fri, 21 Jan 2022 11:09:08 +0100 (CET)
Date: Fri, 21 Jan 2022 11:09:08 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Nicolas Ojeda Leon <ncoleon@amazon.com>
Cc: devel@edk2.groups.io, atugup@amazon.com,
	Alexander Graf <graf@amazon.de>
Subject: Re: [PATCH v2 3/8] Ovmf/HardwareInfoLib: Add core to parse heterogenous data
Message-ID: <20220121100908.jf6kppwyexf3rzd3@sirius.home.kraxel.org>
References: <cover.1642697670.git.ncoleon@amazon.com>
 <c2ba5b7b324a21372d23e7948c44e717fa2cb2a5.1642697671.git.ncoleon@amazon.com>
MIME-Version: 1.0
In-Reply-To: <c2ba5b7b324a21372d23e7948c44e717fa2cb2a5.1642697671.git.ncoleon@amazon.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +++ b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoLib.inf

> +[Sources]
> +  HardwareInfoLib.c
> +  HardwareInfoPciHostBridgeLib.c
> +  QemuFwCfgHardwareInfoLib.c

> +  HardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/HardwareInfoLib.inf
>    QemuFwCfgHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/QemuFwCfgHardwareInfoLib.inf

Hmm, the QemuFwCfgHardwareInfoLib.inf file created by patch #2 has
HardwareInfoPciHostBridgeLib.c + QemuFwCfgHardwareInfoLib.c too.

I'm wondering why you add two inf files in the first place?

take care,
  Gerd