From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Abner Chang <abner.chang@hpe.com>
Cc: devel@edk2.groups.io, Daniel Schaefer <daniel.schaefer@hpe.com>
Subject: Re: [edk2-platforms][PATCH V2 00/14] Address edk2 Core CI issues
Date: Sat, 22 Jan 2022 15:49:31 +0530 [thread overview]
Message-ID: <20220122101931.GA28509@sunil-ThinkPad-T490> (raw)
In-Reply-To: <20220122065318.21808-1-abner.chang@hpe.com>
The series looks good to me.
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Regards
Sunil
On Sat, Jan 22, 2022 at 02:53:04PM +0800, Abner Chang wrote:
> This patch set addresses edk2 Core CI on RISC-V ProcessorPkg
> and PlatformPkg.
>
>
> V2: Address comments to V1.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
>
> Abner Chang (14):
> RiscVProcessorPkg: Fix build fail on RiscVProcessorPkg package
> PlatformPkg/PlatformPei: Fix the build error
> RISC-V/PlatformPkg: Address ECC errors
> RISC-V/PlatformPkg: Address Spelling check errors.
> RISC-V/PlatformPkg: Address Core CI package dependency check errors
> RISC-V/PlatformPkg: Address Core CI license check errors.
> RISC-V/PlatformPkg: Address Core CI library header check errors
> RISC-V/PlatformPkg: Address Core CI Uncrustify errors
> RISC-V/ProcessorPkg: Address Core CI ECC errors.
> RISC-V/ProcessorPkg: Address Core CI library header check errors
> RISC-V/ProcessorPkg: Address Core CI Spelling errors.
> RISC-V/ProcessorPkg: Address Core CI Uncrustify errors
> Silicon/SiFive: Fix build error
> Platform/U5Series: Fix build error
>
> .../RISC-V/PlatformPkg/RiscVPlatformPkg.dec | 7 +-
> .../RISC-V/ProcessorPkg/RiscVProcessorPkg.dec | 7 +-
> .../RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 4 +-
> .../RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 5 +-
> .../FirmwareContextProcessorSpecificLib.inf | 7 +-
> .../OpensbiPlatformLib/OpensbiPlatformLib.inf | 2 +-
> .../PeiCoreEntryPoint/PeiCoreEntryPoint.inf | 1 -
> .../PlatformBootManagerLib.inf | 13 +-
> .../PlatformMemoryTestLibNull.inf | 6 +-
> .../PlatformSecPpiLibNull.inf | 8 +-
> .../PlatformUpdateProgressLibNull.inf | 7 +-
> .../Library/ResetSystemLib/ResetSystemLib.inf | 1 -
> .../PlatformPkg/Universal/FdtPeim/FdtPeim.inf | 5 +-
> .../Universal/Pei/PlatformPei/PlatformPei.inf | 14 +-
> .../PlatformPkg/Universal/Sec/SecMain.inf | 1 +
> .../RiscVFirmwareContextSbiLib.inf | 8 +-
> .../RiscVFirmwareContextSscratchLib.inf | 4 +-
> .../Library/Edk2OpensbiPlatformWrapperLib.h | 2 +-
> .../FirmwareContextProcessorSpecificLib.h | 25 +-
> .../Include/Library/PlatformSecPpiLib.h | 2 +-
> .../Library/RiscVPlatformTempMemoryInitLib.h | 18 +-
> .../PlatformBootManager.h | 44 +-
> .../Universal/Pei/PlatformPei/Platform.h | 39 +-
> .../PlatformPkg/Universal/Sec/SecMain.h | 37 +-
> .../Include/IndustryStandard/RiscV.h | 156 ++---
> .../Include/IndustryStandard/RiscVOpensbi.h | 28 +-
> .../Include/Library/MachineModeTimerLib.h | 17 +
> .../Include/Library/RiscVCpuLib.h | 76 ++-
> .../Include/Library/RiscVEdk2SbiLib.h | 138 ++--
> .../Include/Library/RiscVFirmwareContextLib.h | 6 +-
> .../Include/Library/RiscVPlatformTimerLib.h | 25 +
> .../ProcessorPkg/Include/OpensbiTypes.h | 73 ++-
> .../Include/ProcessorSpecificHobData.h | 105 +--
> .../RISC-V/ProcessorPkg/Include/RiscVImpl.h | 52 +-
> .../Include/SmbiosProcessorSpecificData.h | 50 +-
> .../CpuExceptionHandlerLib.h | 171 ++---
> .../ProcessorPkg/Universal/CpuDxe/CpuDxe.h | 45 +-
> .../Universal/SmbiosDxe/RiscVSmbiosDxe.h | 3 +-
> .../Edk2OpensbiPlatformWrapperLib.c | 394 +++++------
> .../FirmwareContextProcessorSpecificLib.c | 42 +-
> .../OpensbiPlatformLib/OpensbiPlatform.c | 270 ++++++++
> .../Library/OpensbiPlatformLib/Platform.c | 225 -------
> .../PeiCoreEntryPoint/PeiCoreEntryPoint.c | 20 +-
> .../PeiCoreInfoHobLibNull/CoreInfoHob.c | 2 +-
> .../PlatformBootManager.c | 79 ++-
> .../PlatformBootManagerLib/PlatformData.c | 20 +-
> .../PlatformMemoryTestLibNull.c | 2 +-
> .../PlatformSecPpiLibNull/PlatformSecPpiLib.c | 2 +-
> .../Library/ResetSystemLib/ResetSystemLib.c | 40 +-
> .../RiscVSpecialPlatformLib.c | 9 +-
> .../PlatformPkg/Universal/FdtPeim/FdtPeim.c | 33 +-
> .../Universal/Pei/PlatformPei/Fv.c | 9 +-
> .../Universal/Pei/PlatformPei/MemDetect.c | 21 +-
> .../Universal/Pei/PlatformPei/Platform.c | 168 +++--
> .../PlatformPkg/Universal/Sec/SecMain.c | 379 +++++------
> .../Library/PeiCoreInfoHobLib/CoreInfoHob.c | 2 +-
> .../PeiServicesTablePointerOpenSbi.c | 22 +-
> .../Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.c | 617 ++++++++++--------
> .../CpuExceptionHandlerLib.c | 34 +-
> .../RiscVFirmwareContextSbiLib.c | 4 +-
> .../RiscVFirmwareContextSscratchLib.c | 6 +-
> .../RiscVFirmwareContextStvecLib.c | 8 +-
> .../Library/RiscVTimerLib/RiscVTimerLib.c | 24 +-
> .../ProcessorPkg/Universal/CpuDxe/CpuDxe.c | 72 +-
> .../ProcessorPkg/Universal/FdtDxe/FdtDxe.c | 66 +-
> .../Universal/PciCpuIo2Dxe/PciCpuIo2Dxe.c | 47 +-
> .../Universal/SmbiosDxe/RiscVSmbiosDxe.c | 165 +++--
> .../Library/PeiCoreInfoHobLib/CoreInfoHob.c | 4 +-
> Platform/RISC-V/PlatformPkg/Readme.md | 14 +-
> .../RISC-V/PlatformPkg/RiscVPlatformPkg.uni | 71 +-
> .../Universal/Sec/Riscv64/SecEntry.S | 19 +-
> .../PeiServicesTablePointerLibOpenSbi.uni | 15 +-
> .../RISC-V/ProcessorPkg/RiscVProcessorPkg.uni | 18 +-
> 73 files changed, 2297 insertions(+), 1838 deletions(-)
> create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/Library/MachineModeTimerLib.h
> create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/Library/RiscVPlatformTimerLib.h
> create mode 100644 Platform/RISC-V/PlatformPkg/Library/OpensbiPlatformLib/OpensbiPlatform.c
> delete mode 100644 Platform/RISC-V/PlatformPkg/Library/OpensbiPlatformLib/Platform.c
>
> --
> 2.31.1
>
prev parent reply other threads:[~2022-01-22 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 6:53 [edk2-platforms][PATCH V2 00/14] Address edk2 Core CI issues Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 01/14] RiscVProcessorPkg: Fix build fail on RiscVProcessorPkg package Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 02/14] PlatformPkg/PlatformPei: Fix the build error Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 03/14] RISC-V/PlatformPkg: Address ECC errors Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 04/14] RISC-V/PlatformPkg: Address Spelling check errors Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 05/14] RISC-V/PlatformPkg: Address Core CI package dependency " Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 06/14] RISC-V/PlatformPkg: Address Core CI license " Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 07/14] RISC-V/PlatformPkg: Address Core CI library header " Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 08/14] RISC-V/PlatformPkg: Address Core CI Uncrustify errors Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 09/14] RISC-V/ProcessorPkg: Address Core CI ECC errors Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 10/14] RISC-V/ProcessorPkg: Address Core CI library header check errors Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 11/14] RISC-V/ProcessorPkg: Address Core CI Spelling errors Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 12/14] RISC-V/ProcessorPkg: Address Core CI Uncrustify errors Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 13/14] Silicon/SiFive: Fix build error Abner Chang
2022-01-22 6:53 ` [edk2-platforms][PATCH V2 14/14] Platform/U5Series: " Abner Chang
2022-01-22 10:19 ` Sunil V L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220122101931.GA28509@sunil-ThinkPad-T490 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox