From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web12.6962.1642846778301261691 for ; Sat, 22 Jan 2022 02:19:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=G04M+Roy; spf=pass (domain: ventanamicro.com, ip: 209.85.216.41, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f41.google.com with SMTP id s2-20020a17090ad48200b001b501977b23so10841834pju.2 for ; Sat, 22 Jan 2022 02:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fYsWew8AQvNl15TDCbLCIXD6TFN1q5wCAMnE1sYRAqc=; b=G04M+RoyznIt+ejtg/d1dJH4gLQKrz4WjNzyKAqbRdh8nPOl1r0wKFCOqRfgnOX7ao JebfuXLr0iuTTWPt1ha10ZWj1dnsyNl4OO+dmXULQihFUNQGYq7Ckz64RvVpyI28xypb +NqgqON1oYig8Z3rf8d5R1UcGnNAXxsStwvMnaznIr3SWYdgjbRm3LK3Qte9hEBapfgZ mqCqSj//KhJAsNoIgIUWOtn5Z9cuBhS1f1oWvFnXRjAi0tzsR7eKdxIIVSsPPO3LJTYu LsshyE57bmA+9GgFFY0zbRHBsBQZEGVTN/C7/jmNs4QwothNr0vQdOdDA3JHha8nRcTm JEag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fYsWew8AQvNl15TDCbLCIXD6TFN1q5wCAMnE1sYRAqc=; b=aeE7j6Ypq44AwN7cIvgXhvU0/YTK28Xz+ZzDZKFi6/NpdxfldTFTYx+k/rSLmhOvkT N+Z8Ern0BL4Henw+9kZHKeHFeu04iw17QKgSn9to7O0HD67j1Td6p6K+NBj2Uf6QSnde sDXkFOkq+AGZEBksavb2u1zXy2osOgWrgSfXkce74XLUZAw4VqMvMRKX6+HOJaUi4Rrj YINcS9olQjlcHjen9aMA4+MZiDfg2VsrXm1wxz4oDLh97q0rcm4ykpOPuRP+X+fy3GgF o7T1BApQBtJaS7lPU8xOr6pySUXa8BX6lMhK9b0jImJSSTHT4ei/jtAlxigSF7Kt+1fg lOTg== X-Gm-Message-State: AOAM532EXrEiQ32WWMuHSkyXTte0xq0J50s0MS71GQPt0JlVQdhxMCUY 4Er5k5Y1kMhumf7I7CoiTMAI1w== X-Google-Smtp-Source: ABdhPJzI367nwSpxMYS/N3IEvfUSf7R+MmjW+sBSBQuxEh+mZ4P5EctuDkGAIs9yNvaVYbaW/D4q7g== X-Received: by 2002:a17:903:2287:b0:149:fa57:ea87 with SMTP id b7-20020a170903228700b00149fa57ea87mr7416437plh.94.1642846777774; Sat, 22 Jan 2022 02:19:37 -0800 (PST) Return-Path: Received: from sunil-ThinkPad-T490 ([49.206.3.187]) by smtp.gmail.com with ESMTPSA id k22sm2305440pff.5.2022.01.22.02.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jan 2022 02:19:37 -0800 (PST) Date: Sat, 22 Jan 2022 15:49:31 +0530 From: "Sunil V L" To: Abner Chang Cc: devel@edk2.groups.io, Daniel Schaefer Subject: Re: [edk2-platforms][PATCH V2 00/14] Address edk2 Core CI issues Message-ID: <20220122101931.GA28509@sunil-ThinkPad-T490> References: <20220122065318.21808-1-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <20220122065318.21808-1-abner.chang@hpe.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The series looks good to me. Reviewed-by: Sunil V L Regards Sunil On Sat, Jan 22, 2022 at 02:53:04PM +0800, Abner Chang wrote: > This patch set addresses edk2 Core CI on RISC-V ProcessorPkg > and PlatformPkg. > > > V2: Address comments to V1. > > Signed-off-by: Abner Chang > Cc: Daniel Schaefer > Cc: Sunil V L > > Abner Chang (14): > RiscVProcessorPkg: Fix build fail on RiscVProcessorPkg package > PlatformPkg/PlatformPei: Fix the build error > RISC-V/PlatformPkg: Address ECC errors > RISC-V/PlatformPkg: Address Spelling check errors. > RISC-V/PlatformPkg: Address Core CI package dependency check errors > RISC-V/PlatformPkg: Address Core CI license check errors. > RISC-V/PlatformPkg: Address Core CI library header check errors > RISC-V/PlatformPkg: Address Core CI Uncrustify errors > RISC-V/ProcessorPkg: Address Core CI ECC errors. > RISC-V/ProcessorPkg: Address Core CI library header check errors > RISC-V/ProcessorPkg: Address Core CI Spelling errors. > RISC-V/ProcessorPkg: Address Core CI Uncrustify errors > Silicon/SiFive: Fix build error > Platform/U5Series: Fix build error > > .../RISC-V/PlatformPkg/RiscVPlatformPkg.dec | 7 +- > .../RISC-V/ProcessorPkg/RiscVProcessorPkg.dec | 7 +- > .../RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 4 +- > .../RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 5 +- > .../FirmwareContextProcessorSpecificLib.inf | 7 +- > .../OpensbiPlatformLib/OpensbiPlatformLib.inf | 2 +- > .../PeiCoreEntryPoint/PeiCoreEntryPoint.inf | 1 - > .../PlatformBootManagerLib.inf | 13 +- > .../PlatformMemoryTestLibNull.inf | 6 +- > .../PlatformSecPpiLibNull.inf | 8 +- > .../PlatformUpdateProgressLibNull.inf | 7 +- > .../Library/ResetSystemLib/ResetSystemLib.inf | 1 - > .../PlatformPkg/Universal/FdtPeim/FdtPeim.inf | 5 +- > .../Universal/Pei/PlatformPei/PlatformPei.inf | 14 +- > .../PlatformPkg/Universal/Sec/SecMain.inf | 1 + > .../RiscVFirmwareContextSbiLib.inf | 8 +- > .../RiscVFirmwareContextSscratchLib.inf | 4 +- > .../Library/Edk2OpensbiPlatformWrapperLib.h | 2 +- > .../FirmwareContextProcessorSpecificLib.h | 25 +- > .../Include/Library/PlatformSecPpiLib.h | 2 +- > .../Library/RiscVPlatformTempMemoryInitLib.h | 18 +- > .../PlatformBootManager.h | 44 +- > .../Universal/Pei/PlatformPei/Platform.h | 39 +- > .../PlatformPkg/Universal/Sec/SecMain.h | 37 +- > .../Include/IndustryStandard/RiscV.h | 156 ++--- > .../Include/IndustryStandard/RiscVOpensbi.h | 28 +- > .../Include/Library/MachineModeTimerLib.h | 17 + > .../Include/Library/RiscVCpuLib.h | 76 ++- > .../Include/Library/RiscVEdk2SbiLib.h | 138 ++-- > .../Include/Library/RiscVFirmwareContextLib.h | 6 +- > .../Include/Library/RiscVPlatformTimerLib.h | 25 + > .../ProcessorPkg/Include/OpensbiTypes.h | 73 ++- > .../Include/ProcessorSpecificHobData.h | 105 +-- > .../RISC-V/ProcessorPkg/Include/RiscVImpl.h | 52 +- > .../Include/SmbiosProcessorSpecificData.h | 50 +- > .../CpuExceptionHandlerLib.h | 171 ++--- > .../ProcessorPkg/Universal/CpuDxe/CpuDxe.h | 45 +- > .../Universal/SmbiosDxe/RiscVSmbiosDxe.h | 3 +- > .../Edk2OpensbiPlatformWrapperLib.c | 394 +++++------ > .../FirmwareContextProcessorSpecificLib.c | 42 +- > .../OpensbiPlatformLib/OpensbiPlatform.c | 270 ++++++++ > .../Library/OpensbiPlatformLib/Platform.c | 225 ------- > .../PeiCoreEntryPoint/PeiCoreEntryPoint.c | 20 +- > .../PeiCoreInfoHobLibNull/CoreInfoHob.c | 2 +- > .../PlatformBootManager.c | 79 ++- > .../PlatformBootManagerLib/PlatformData.c | 20 +- > .../PlatformMemoryTestLibNull.c | 2 +- > .../PlatformSecPpiLibNull/PlatformSecPpiLib.c | 2 +- > .../Library/ResetSystemLib/ResetSystemLib.c | 40 +- > .../RiscVSpecialPlatformLib.c | 9 +- > .../PlatformPkg/Universal/FdtPeim/FdtPeim.c | 33 +- > .../Universal/Pei/PlatformPei/Fv.c | 9 +- > .../Universal/Pei/PlatformPei/MemDetect.c | 21 +- > .../Universal/Pei/PlatformPei/Platform.c | 168 +++-- > .../PlatformPkg/Universal/Sec/SecMain.c | 379 +++++------ > .../Library/PeiCoreInfoHobLib/CoreInfoHob.c | 2 +- > .../PeiServicesTablePointerOpenSbi.c | 22 +- > .../Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.c | 617 ++++++++++-------- > .../CpuExceptionHandlerLib.c | 34 +- > .../RiscVFirmwareContextSbiLib.c | 4 +- > .../RiscVFirmwareContextSscratchLib.c | 6 +- > .../RiscVFirmwareContextStvecLib.c | 8 +- > .../Library/RiscVTimerLib/RiscVTimerLib.c | 24 +- > .../ProcessorPkg/Universal/CpuDxe/CpuDxe.c | 72 +- > .../ProcessorPkg/Universal/FdtDxe/FdtDxe.c | 66 +- > .../Universal/PciCpuIo2Dxe/PciCpuIo2Dxe.c | 47 +- > .../Universal/SmbiosDxe/RiscVSmbiosDxe.c | 165 +++-- > .../Library/PeiCoreInfoHobLib/CoreInfoHob.c | 4 +- > Platform/RISC-V/PlatformPkg/Readme.md | 14 +- > .../RISC-V/PlatformPkg/RiscVPlatformPkg.uni | 71 +- > .../Universal/Sec/Riscv64/SecEntry.S | 19 +- > .../PeiServicesTablePointerLibOpenSbi.uni | 15 +- > .../RISC-V/ProcessorPkg/RiscVProcessorPkg.uni | 18 +- > 73 files changed, 2297 insertions(+), 1838 deletions(-) > create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/Library/MachineModeTimerLib.h > create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/Library/RiscVPlatformTimerLib.h > create mode 100644 Platform/RISC-V/PlatformPkg/Library/OpensbiPlatformLib/OpensbiPlatform.c > delete mode 100644 Platform/RISC-V/PlatformPkg/Library/OpensbiPlatformLib/Platform.c > > -- > 2.31.1 >