From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web09.2044.1643139557605453788 for ; Tue, 25 Jan 2022 11:39:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aj2d/bkG; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id h12so20951502pjq.3 for ; Tue, 25 Jan 2022 11:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5t1hCQI8x+znkjZRBRucmWCjheaOT0TmNAr9JyYsUZg=; b=aj2d/bkG3GT/ptIlo1HlVTMbuML1y6c1mmFDryYAIyrta6Qaz0LbfKSdpJl49bRwFy 3OdURXEaVSS2Izk3GOyRQGH0XdsIIVv4p8DF0CWCFzzSWZq1FfKviQVf6jjAUtjFvm34 hkI9O5ZGAFVFInqu4MogCdyJ70S/uAPzJWj69sd+zcmHfUN5LWg29atMIc2fLgFiMv5W lbQFXitkbSASR1ZQYc/j01QbFt6USpctT96rU8qvbrGp6Cjh7f/O9TyCRXY2MrS47Nco 1w4KMfrsxCRs5Bqv8Ma1WBrBSXPFCEI7A+9u4rAF6WvZZS/gL0gPtRBqpUHZnVdFrB1O 0MIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5t1hCQI8x+znkjZRBRucmWCjheaOT0TmNAr9JyYsUZg=; b=dC9NPrxVd/dxiU/lKZrMaz8aTHXyxU6GyoKAmpaAXG1XIUDgGlKpR2H17JCoHQZ9Qo e9gyGbgVUtKlXdz1TqQRSuGpfw+i9BoNnm9h9H5gD72xVjj3L4uVEUWjmkNEivAIT83z bEI1IqJJI+pY2GBF9fMcZK/PzgKW+hzkSyzEWbWo0Ws1OuCcOw3jDIUf68NaNZ9KqLB6 VoyROKWbp4fVDmja+6ewBn2RJwe90vz9pqGttRVV376FWOTJMrL6bIca/zuhmdKqCjPV Guz6yL609OvCJo0sFI9N4TrKjg7qX2j2JNenZe7skekRswwhrPbvg3/bnJOZomUItvZW 0Njw== X-Gm-Message-State: AOAM5301SBefzYXi6rnST+4NkHelv0wDFM6xfqSOkxUwn6St0qCbioMp Is0dOak9QT0OprKPndwUbjIT34uurgw= X-Google-Smtp-Source: ABdhPJwHbrwQ5SKkfkyil7ACFwC4VvEr/8/z1p5062TV/l6abSca0JKNw8laZU5t1GMyED8VkW1q0w== X-Received: by 2002:a17:902:a50f:b0:149:bc1a:2c98 with SMTP id s15-20020a170902a50f00b00149bc1a2c98mr20047348plq.35.1643139556877; Tue, 25 Jan 2022 11:39:16 -0800 (PST) Return-Path: Received: from gem-name-lb-02.localdomain ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id v8sm1036929pju.51.2022.01.25.11.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 11:39:16 -0800 (PST) From: "Kun Qin" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Bret Barkelew , Michael Kubacki , Sami Mujawar Subject: [PATCH v3 3/6] ArmPkg: MmCommunicationDxe: MM communicate function argument attributes Date: Tue, 25 Jan 2022 11:39:06 -0800 Message-Id: <20220125193909.491-4-kuqin12@gmail.com> X-Mailer: git-send-email 2.34.1.windows.1 In-Reply-To: <20220125193909.491-1-kuqin12@gmail.com> References: <20220125193909.491-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Current MM communicate2 function from ArmPkg described input arguments `CommBufferPhysical`, `CommBufferVirtual` and `CommSize` as input only, which mismatches with the "input and output type" as in PI specification. This change updated function descriptions of MM communite2 to match input argument types. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bret Barkelew Cc: Michael Kubacki Cc: Sami Mujawar Signed-off-by: Kun Qin Reviewed-by: Sami Mujawar --- Notes: v2: - Splitting patch into 1 of 4 [Ard] v3: - Added cc entry and reviewed-by tag [Sami] ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c index 7c8284104d87..7f756a32d4e0 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c @@ -41,12 +41,13 @@ STATIC EFI_HANDLE mMmCommunicateHandle; This function provides a service to send and receive messages from a registered UEFI service. - @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance. - @param[in] CommBufferPhysical Physical address of the MM communication buffer - @param[in] CommBufferVirtual Virtual address of the MM communication buffer - @param[in] CommSize The size of the data buffer being passed in. On exit, the size of data - being returned. Zero if the handler does not wish to reply with any data. - This parameter is optional and may be NULL. + @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance. + @param[in, out] CommBufferPhysical Physical address of the MM communication buffer + @param[in, out] CommBufferVirtual Virtual address of the MM communication buffer + @param[in, out] CommSize The size of the data buffer being passed in. On exit, the + size of data being returned. Zero if the handler does not + wish to reply with any data. This parameter is optional + and may be NULL. @retval EFI_SUCCESS The message was successfully posted. @retval EFI_INVALID_PARAMETER CommBufferPhysical was NULL or CommBufferVirtual was NULL. -- 2.34.1.windows.1