From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.28559.1643289619845028178 for ; Thu, 27 Jan 2022 05:20:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AWvE5W0/; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643289618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y2utH0Rq2A4AREfUPZBFdOrAm9zp998o+HNCdjw2BU0=; b=AWvE5W0/BcWBpg9geLo1saD1aZhN82chRQ4oPEK9dnaEmec9p7Sq/7O+CKS/RWc8Y+G2wu riH2+tNctQSkxwsnPOrVeo7J6nMdCzk2eF7diSbOhRUGfemiE/TUcbMQ28b2nBJCZmshd6 pWA2a/4hw7tvqKEom0WjlCPx7T20Dic= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-Lwc5Z9FCOkKLgAhpuF4o4Q-1; Thu, 27 Jan 2022 08:20:15 -0500 X-MC-Unique: Lwc5Z9FCOkKLgAhpuF4o4Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA377100C662; Thu, 27 Jan 2022 13:20:13 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B92C6E20C; Thu, 27 Jan 2022 13:20:13 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8AB661800094; Thu, 27 Jan 2022 14:20:11 +0100 (CET) Date: Thu, 27 Jan 2022 14:20:11 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Daniel Schaefer , Sunil V L , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Leif Lindholm , Sami Mujawar Subject: Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib Message-ID: <20220127132011.36dcsj5hx4jtjdvx@sirius.home.kraxel.org> References: <20220124135209.8371-1-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <20220124135209.8371-1-abner.chang@hpe.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 24, 2022 at 09:52:07PM +0800, Abner Chang wrote: > Clone BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg. > RISC-V Virt platform can leverage the same library to access PCI Express > registers through PCI Express base address set in PcdPciExpressBaseAddress > and cached in a global variable. Also remove the one under ArmVirtPkg. > > Signed-off-by: Abner Chang > Cc: Daniel Schaefer > Cc: Sunil V L > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Leif Lindholm > Cc: Sami Mujawar Given you are mostly moving code around as git noticed ... > rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf (87%) > rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%) ... it doesn't make sense to split that into two patches. Just using "git mv" instead has the additional advantage to keep the git history intact (using 'git log --follow'). take care, Gerd