From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.28613.1643289961643606227
 for <devel@edk2.groups.io>;
 Thu, 27 Jan 2022 05:26:02 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ELXKnJ/W;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1643289960;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fxd+mmO4jFb9Je4+dMdyjWDn523ykZlW5Cc3vXxYai0=;
	b=ELXKnJ/Wo7lVUdVwRjI2xgWBsKqzCbPStgNzVKIWv7kLqFwco7AAGl/J4Bg4a2T+txujZe
	JdqIp09u4cwffwnrsz0HBEnmCqpkGGsQ/fWAypj0dqxQIMeNHB7nKGH79Yg8x5BCgrWipS
	DtElYdoa3SfJCyBahfRWlGarvKEWrrQ=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-618-P1bSOyfKO9SZUDSl4dYebQ-1; Thu, 27 Jan 2022 08:25:55 -0500
X-MC-Unique: P1bSOyfKO9SZUDSl4dYebQ-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37DC21F6B0;
	Thu, 27 Jan 2022 13:25:54 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.47])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id DC95F7D73C;
	Thu, 27 Jan 2022 13:25:53 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 45FE21800094; Thu, 27 Jan 2022 14:25:52 +0100 (CET)
Date: Thu, 27 Jan 2022 14:25:52 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V2 03/10] OvmfPkg: Add TdxWorkArea definition
Message-ID: <20220127132552.trn5bwlouxhoda3y@sirius.home.kraxel.org>
References: <20220125063318.862-1-min.m.xu@intel.com>
 <20220125063318.862-4-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20220125063318.862-4-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +//
> +// The TDX work area definition
> +//
> +typedef struct _SEC_TDX_WORK_AREA {
> +  UINT32    PageTableReady;
> +  UINT32    Gpaw;
> +  UINT64    HobList;
> +} SEC_TDX_WORK_AREA;
> +
> +typedef struct _TDX_WORK_AREA {
> +  CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER    Header;
> +  SEC_TDX_WORK_AREA                          SecTdxWorkArea;
> +} TDX_WORK_AREA;
> +
>  typedef union {
>    CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER    Header;
>    SEV_WORK_AREA                              SevWorkArea;
> +  TDX_WORK_AREA                              TdxWorkArea;
>  } OVMF_WORK_AREA;

Now you have the CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER twice ...

take care,
  Gerd