From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web08.28096.1643290381727510086
 for <devel@edk2.groups.io>;
 Thu, 27 Jan 2022 05:33:01 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MbvWoSrf;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1643290380;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RFooOetNyYDkcpsQaaOQrr0u9djVYvTQgKhhiIVBgtg=;
	b=MbvWoSrfoX45wiJ3o8KwxnGWzLVHP7jIFYWJsyFapGa6TZmafhGhMAGJCXf4E4GQtGyoNb
	ikY8CpFO2BCepvixepTrCWxJ8TIfRRHbD51/hJTCDaYr6+Y/3QTCVQ/rJOBba1CeftI2b+
	yiAeJGYJNaz43U4RDmwzHdy2+9n3C6Q=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-635-_tcWJqWANEWIpRpHwURpzA-1; Thu, 27 Jan 2022 08:32:57 -0500
X-MC-Unique: _tcWJqWANEWIpRpHwURpzA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A83A3D9C;
	Thu, 27 Jan 2022 13:32:56 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.47])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id AB6FF6F95C;
	Thu, 27 Jan 2022 13:32:55 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 03F1C1800094; Thu, 27 Jan 2022 14:32:54 +0100 (CET)
Date: Thu, 27 Jan 2022 14:32:53 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V2 05/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings
Message-ID: <20220127133253.kiytvih2iiamzwah@sirius.home.kraxel.org>
References: <20220125063318.862-1-min.m.xu@intel.com>
 <20220125063318.862-6-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20220125063318.862-6-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> This patch-sets is to bring up Legacy guest and Tdx guest without
> PEI phase. So platform initialization has to be done in SEC phase.
> It is similar with the work of OvmfPkg/PlatformPei. In
> OvmfPkg/PlatformPei some PCDs are set during platform initialization,
> such as PcdPciMmio64Base. But in PEI-less boot, PCDs cannot be set.
> So these values are saved in EFI_HOB_PLATFORM_INFO. Then in the early
> stage of DXE phase this hob will be parsed and PCDs are set accordingly.

> --- a/OvmfPkg/Include/IndustryStandard/IntelTdx.h
> +++ b/OvmfPkg/Include/IndustryStandard/IntelTdx.h

With this being more widely used it doesn't make sense to have it in IntelTdx.h ...

take care,
  Gerd