From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io,
Michael D Kinney <michael.d.kinney@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob
Date: Thu, 27 Jan 2022 14:48:50 +0100 [thread overview]
Message-ID: <20220127134850.q5rrxeefqyh3yrru@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220125063318.862-10-min.m.xu@intel.com>
Hi,
> + EFI_HOB_GUID_TYPE *GuidHob;
> + EFI_HOB_PLATFORM_INFO *PlatformInfo = NULL;
> // Query Host Bridge DID to determine platform type
> + // Tdx guest stores the HostBridgePciDevId in a GuidHob.
> + // So we first check if this HOB exists
Hmm, wouldn't it be better to create and use the PlatformInfo for both
PEI-based and PEI-less boot?
> - HostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId);
> + GuidHob = GetFirstGuidHob (&gUefiOvmfPkgTdxPlatformGuid);
> + if (GuidHob != NULL) {
> + PlatformInfo = (EFI_HOB_PLATFORM_INFO *)GET_GUID_HOB_DATA (GuidHob);
> + HostBridgeDevId = PlatformInfo->HostBridgePciDevId;
> + } else {
> + HostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId);
> + }
We would not need that kind of checks in the first place then.
take care,
Gerd
next prev parent reply other threads:[~2022-01-27 13:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 6:33 [PATCH V2 00/10] Introduce TDVF Config-B (basic) in OvmfPkg Min Xu
2022-01-25 6:33 ` [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Min Xu
2022-01-25 15:09 ` [edk2-devel] " Abner Chang
2022-01-27 0:43 ` Abner Chang
2022-01-27 0:58 ` Min Xu
2022-01-27 1:55 ` Abner Chang
2022-01-27 2:39 ` Min Xu
2022-01-27 3:01 ` Abner Chang
2022-01-27 3:38 ` Min Xu
2022-01-25 6:33 ` [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase Min Xu
2022-01-27 13:24 ` Gerd Hoffmann
2022-01-28 8:02 ` Min Xu
2022-01-28 10:20 ` Gerd Hoffmann
2022-02-14 1:51 ` Min Xu
2022-02-14 9:58 ` Gerd Hoffmann
2022-01-25 6:33 ` [PATCH V2 03/10] OvmfPkg: Add TdxWorkArea definition Min Xu
2022-01-27 13:25 ` Gerd Hoffmann
2022-01-28 8:01 ` Min Xu
2022-01-28 10:21 ` [edk2-devel] " Gerd Hoffmann
2022-01-25 6:33 ` [PATCH V2 04/10] OvmfPkg: Add PrePiHobListPointerLibTdx Min Xu
2022-01-25 6:33 ` [PATCH V2 05/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings Min Xu
2022-01-27 13:32 ` Gerd Hoffmann
2022-02-14 2:34 ` Min Xu
2022-02-14 10:00 ` Gerd Hoffmann
2022-01-25 6:33 ` [PATCH V2 06/10] OvmfPkg: Add TdxStartupLib Min Xu
2022-01-25 6:33 ` [PATCH V2 07/10] OvmfPkg/IntelTdx: Add Sec to bring up both Legacy and Tdx guest Min Xu
2022-01-27 13:42 ` Gerd Hoffmann
2022-02-08 8:43 ` Min Xu
2022-01-25 6:33 ` [PATCH V2 08/10] OvmfPkg: Update TdxDxe to set TDX PCDs Min Xu
2022-01-25 6:33 ` [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob Min Xu
2022-01-27 13:48 ` Gerd Hoffmann [this message]
2022-02-08 8:20 ` Min Xu
2022-02-14 10:03 ` Gerd Hoffmann
2022-02-14 13:09 ` Min Xu
2022-01-25 6:33 ` [PATCH V2 10/10] OvmfPkg: Introduce IntelTdxX64 for TDVF Config-B Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127134850.q5rrxeefqyh3yrru@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox